Re: [pgAdmin][RM6177] ERD download image related fixes

2021-01-28 Thread Akshay Joshi
Thanks, patch applied. On Fri, Jan 29, 2021 at 12:05 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > Attached is the patch based on the latest code base. > > On Fri, Jan 29, 2021 at 11:58 AM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Aditya >> >> I th

pgAdmin 4 commit: Fixed an issue where the dependencies tab showing mul

2021-01-28 Thread Akshay Joshi
Fixed an issue where the dependencies tab showing multiple owners for the objects having shared dependencies. Fixes #6087 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=358af42c503a86a89a38a02b006f8af9a7234467 Modified Files -- d

pgAdmin 4 commit: Fixed an issue while downloading ERD images in Safari

2021-01-28 Thread Akshay Joshi
Fixed an issue while downloading ERD images in Safari and Firefox. Fixes #6177 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a0271c76560da80431b65a5d273810229095468d Author: Aditya Toshniwal Modified Files -- docs/en_US/release_

Re: [pgAdmin][RM6177] ERD download image related fixes

2021-01-28 Thread Aditya Toshniwal
Hi, Attached is the patch based on the latest code base. On Fri, Jan 29, 2021 at 11:58 AM Akshay Joshi wrote: > Hi Aditya > > I think you forgot to attach the patch. > > On Thu, Jan 28, 2021 at 4:35 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attache

Re: [pgAdmin][RM-6045]: Autocomplete is not showing any suggestions if the schema name contains escape characters.

2021-01-28 Thread Akshay Joshi
Thanks, patch applied. On Fri, Jan 29, 2021 at 10:23 AM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Team, > > Please find the attached patch for RM-6045: > Autocomplete is not showing > any suggestions if the schema name contains escape

Re: [pgAdmin] RM5871 Show username in 'Connect to Server' pop up when server is created using service & user.

2021-01-28 Thread Akshay Joshi
Thanks, patch applied. On Mon, Jan 25, 2021 at 5:29 PM Rahul Shirsat < rahul.shir...@enterprisedb.com> wrote: > Hi Hackers, > > Please find the attached patch for this issue. > -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Principal Software Architect* *EDB Postgres

Re: SonarQube Fixes #4 Database & Foreign Tables

2021-01-28 Thread Akshay Joshi
Thanks, patch applied. On Thu, Jan 21, 2021 at 5:25 PM Rahul Shirsat < rahul.shir...@enterprisedb.com> wrote: > > > On Thu, Jan 21, 2021 at 2:47 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Rahul >> >> Following are the review comments: >> >>- Change the name of the funct

Re: [patch][pgAdmin] Multiple ERD related fixes

2021-01-28 Thread Akshay Joshi
Thanks, patch applied. On Fri, Jan 29, 2021 at 11:43 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > Please find the rebased patch based on the latest code. > > On Wed, Jan 27, 2021 at 4:17 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Hackers

pgAdmin 4 commit: 1) Fixed an issue where Zoom to fit button only works

2021-01-28 Thread Akshay Joshi
1) Fixed an issue where Zoom to fit button only works if the diagram is larger than the canvas. Fixes #6163 2) Ensure that the diagram should not vanish entirely if zooming out too far in ERD. Fixes #6164 3) Fixed an issue where Generate SQL displayed twice in the ERD tool. Fixes #6179 4) Update

pgAdmin 4 commit: Ensure that username should be visible in the 'Connec

2021-01-28 Thread Akshay Joshi
Ensure that username should be visible in the 'Connect to Server' popup when service and user name both specified. Fixes #5871 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ab642344d4a9697d3bb62e047c8484aade4a2793 Author: Rahul Shirsat Mod

pgAdmin 4 commit: Fixed SonarQube issues.

2021-01-28 Thread Akshay Joshi
Fixed SonarQube issues. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e230787f21e9204382248c7437f15f4b9a62e819 Author: Rahul Shirsat Modified Files -- .../server_groups/servers/databases/__init__.py| 16 +- .../databases/sch

pgAdmin 4 commit: Fixed autocomplete issue where it is not showing any

2021-01-28 Thread Akshay Joshi
Fixed autocomplete issue where it is not showing any suggestions if the schema name contains escape characters. Fixes #6045. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=36f76f5e2cfcef0ada2b1168ef082849c0e7de7b Author: Nikhil Mohite Modif

Re: [pgAdmin][RM6177] ERD download image related fixes

2021-01-28 Thread Akshay Joshi
Hi Aditya I think you forgot to attach the patch. On Thu, Jan 28, 2021 at 4:35 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to: > 1) Icons were not visible in downloaded images. Fixed. > 2) Download image will now work on Safari and Fire

Re: [patch][pgAdmin] Multiple ERD related fixes

2021-01-28 Thread Aditya Toshniwal
Hi, Please find the rebased patch based on the latest code. On Wed, Jan 27, 2021 at 4:17 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached patch fixes: > 1. Documentation missing for 'Download Image' option in ERD. Fixes #6180. > 2. Generate SQL displayed

[pgAdmin][RM-6045]: Autocomplete is not showing any suggestions if the schema name contains escape characters.

2021-01-28 Thread Nikhil Mohite
Hi Team, Please find the attached patch for RM-6045: Autocomplete is not showing any suggestions if the schema name contains escape characters. -- *Thanks & Regards,* *Nikhil Mohite* *Software Engineer.* *EDB Postgres*

pgAdmin 4 commit: Tag REL-4_30 has been created.

2021-01-28 Thread Akshay Joshi
Tag REL-4_30 has been created. View: https://git.postgresql.org/gitweb?p=pgadmin4.git;a=tag;h=refs/tags/REL-4_30 Log Message --- Tag v4.30

pgAdmin 4 v4.30 released

2021-01-28 Thread Akshay Joshi
The pgAdmin Development Team is pleased to announce pgAdmin 4 version 4.30. This release of pgAdmin 4 includes 38 bug fixes and new features. For more details please see the release notes at: https://www.pgadmin.org/docs/pgadmin4/4.30/release_notes_4_30.html. pgAdmin is the leading Open Sourc

Re: pgAdmin4 v4.30 candidate builds

2021-01-28 Thread Fahar Abbas
@Akshay Joshi One round of testing has been done, pgadmin4 4.30 product is ready for the release. Kind Regards, On Mon, Jan 25, 2021 at 7:46 PM Akshay Joshi wrote: > Hi All, > > We have found one showstopper issue, so have to generate candidate > build again. > The latest candidate builds and

[pgAdmin][RM6177] ERD download image related fixes

2021-01-28 Thread Aditya Toshniwal
Hi Hackers, Attached is the patch to: 1) Icons were not visible in downloaded images. Fixed. 2) Download image will now work on Safari and Firefox also. 3) Added the icon of foreign key to the "many" endpoint of one to many links. [image: image.png] Please review. -- Thanks, Aditya Toshniwal pg