[pgAdmin]: Patch for SonarQube fixes

2021-01-18 Thread Nikhil Mohite
Hi Team, I have fixed a few sonarQube issues, PFA patch Details as follows: Schema diff: - Refactor this function to reduce its Cognitive Complexity from 17 to the 15 allowed. - Refactor this function to reduce its Cognitive Complexity from 44 to the 15 allowed. - Refactor this fu

[pgAdmin]: Fix for kerberos test cases.

2021-01-18 Thread Nikhil Mohite
Hi Team, Please find the patch to fix the failing test cases. -- *Thanks & Regards,* *Nikhil Mohite* *Software Engineer.* *EDB Postgres* *Mob.No: +91-7798364578.* test_case_fix.patch Description: Binary data

[pgAdmin] RM6098 Manually deleting from table view hangs

2021-01-18 Thread Rahul Shirsat
Hi Hackers, Please find the attached patch which resolves the issue of deleting records when the user tries to delete multiple records step by step. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM6098.patch Description: Binary data

Re: [pgAdmin][RM1802] ERD Tool (Beta)

2021-01-18 Thread Akshay Joshi
Thanks, patch applied. On Mon, Jan 18, 2021 at 5:08 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > OK, So the changes have worked. But still failing at one more place. > Attached the patch fixes it. > > On Mon, Jan 18, 2021 at 4:40 PM Akshay Joshi < > akshay.jo...@enterprisedb.

pgAdmin 4 commit: One more attempt to fix jasmine test cases of ERD Too

2021-01-18 Thread Akshay Joshi
One more attempt to fix jasmine test cases of ERD Tool. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9229156cf6f3ebd8bf1e45f419909461fc5a1729 Author: Aditya Toshniwal Modified Files -- web/regression/javascript/erd/ui_component

Re: [pgAdmin][RM1802] ERD Tool (Beta)

2021-01-18 Thread Aditya Toshniwal
OK, So the changes have worked. But still failing at one more place. Attached the patch fixes it. On Mon, Jan 18, 2021 at 4:40 PM Akshay Joshi wrote: > Thanks, patch applied. > > On Mon, Jan 18, 2021 at 2:58 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi, >> >> The jas

Re: There is an error when checking the major version of servers in schema diff

2021-01-18 Thread Akshay Joshi
Thanks, patch applied. On Sun, Jan 17, 2021 at 6:28 PM Huang, Jun wrote: > Hi, > > The function get_round_val() outputs the wrong value when major version is > before 10. > For example, >Source server version: 90500 >Target server version: 90502 > Or >Source server version: 90502 >

Re: [pgAdmin][RM1802] ERD Tool (Beta)

2021-01-18 Thread Akshay Joshi
Thanks, patch applied. On Mon, Jan 18, 2021 at 2:58 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > The jasmine test cases are working fine on my local machine. The test > cases are successful on jenkins other than on linux, not sure why. > I have made some fixes by look

pgAdmin 4 commit: 1) Added support for Kerberos authentication, using S

2021-01-18 Thread Akshay Joshi
1) Added support for Kerberos authentication, using SPNEGO to forward the Kerberos tickets through a browser. Fixes #5457 2) Fixed incorrect log information for AUTHENTICATION_SOURCES. Fixes #5829 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;

pgAdmin 4 commit: Fixed an issue while checking the major version of se

2021-01-18 Thread Akshay Joshi
Fixed an issue while checking the major version of servers in schema diff. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a60cfd3cc33a9ba0486ae4fb517ea8187ebf8fda Author: Huang Jun Modified Files -- web/pgadmin/tools/schema_diff/

pgAdmin 4 commit: Fixed jasmine test cases of ERD Tool.

2021-01-18 Thread Akshay Joshi
Fixed jasmine test cases of ERD Tool. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=02f9b72d3efab89a443818a898205ff0b83ff6ef Author: Aditya Toshniwal Modified Files -- web/regression/javascript/erd/onetomany_port_spec.js | 2 +-

Re: [pgAdmin4][Patch] - RM 5457 - Kerberos Authentication - Phase 1

2021-01-18 Thread Dave Page
On Mon, Jan 18, 2021 at 9:37 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Mon, Jan 18, 2021 at 2:45 PM Dave Page wrote: > >> Hi >> >> On Mon, Jan 18, 2021 at 7:30 AM Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> Hi, >>> >>> Please find the attached upd

Re: [pgAdmin4][Patch] - RM 5457 - Kerberos Authentication - Phase 1

2021-01-18 Thread Khushboo Vashi
On Mon, Jan 18, 2021 at 2:45 PM Dave Page wrote: > Hi > > On Mon, Jan 18, 2021 at 7:30 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> Please find the attached updated patch with the below changes: >> >> - Dependencies are added into Linux packages in the RPM/DEBs. >>

Re: [pgAdmin][RM1802] ERD Tool (Beta)

2021-01-18 Thread Aditya Toshniwal
Hi, The jasmine test cases are working fine on my local machine. The test cases are successful on jenkins other than on linux, not sure why. I have made some fixes by looking at the log. Please review and try. On Mon, Jan 18, 2021 at 1:10 PM Akshay Joshi wrote: > Thanks, patch applied. > > On M

Re: [pgAdmin4][Patch] - RM 5457 - Kerberos Authentication - Phase 1

2021-01-18 Thread Dave Page
Hi On Mon, Jan 18, 2021 at 7:30 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached updated patch with the below changes: > > - Dependencies are added into Linux packages in the RPM/DEBs. > - Dev packages are added in the setup scripts for Linux. > - The