Re: [pgAdmin][RM1802] ERD Tool (Beta)

Thanks, patch applied. On Mon, Jan 18, 2021 at 10:34 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Akshay, > > I forgot to remove few of the dependencies which are not required as of > now (may be in future). Attached patch removes those dependencies from > package.json. >

Re: Patch for SonarQube fixes.

Thanks, patch applied. On Mon, Jan 18, 2021 at 11:15 AM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Team, > > I have fixed a few sonarQube issues, PFA patch > Details as follows: > > 1. Preferences: > >- Refactor this function to reduce its Cognitive Complexity from 18 to >

pgAdmin 4 commit: Fixed issues reported by SonarQube.

Fixed issues reported by SonarQube. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d4a3e4d92c397fc8789f3f5dde45c61c04138bf1 Author: Nikhil Mohite Modified Files -- .../browser/register_browser_preferences.py| 10 ++--- web

pgAdmin 4 commit: Remove few dependencies which are not required for ER

Remove few dependencies which are not required for ERD Tool. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5afa4f1995d7d1fa5d2641f62e166b47101aa30f Author: Aditya Toshniwal Modified Files -- web/package.json | 3 --- web/yarn.lo

Re: [pgAdmin4][Patch] - RM 5457 - Kerberos Authentication - Phase 1

Hi, Please find the attached updated patch with the below changes: - Dependencies are added into Linux packages in the RPM/DEBs. - Dev packages are added in the setup scripts for Linux. - The required packages are added in the Dockerfile. - Conditional gssapi 1.6.2 dependency is added for Python

Patch for SonarQube fixes.

Hi Team, I have fixed a few sonarQube issues, PFA patch Details as follows: 1. Preferences: - Refactor this function to reduce its Cognitive Complexity from 18 to the 15 allowed. - Merge this if statement with the enclosing one. - Define a constant instead of duplicating this literal

Re: [pgAdmin][RM1802] ERD Tool (Beta)

Hi Akshay, I forgot to remove few of the dependencies which are not required as of now (may be in future). Attached patch removes those dependencies from package.json. On Sat, Jan 16, 2021 at 5:08 PM Akshay Joshi wrote: > Thanks, patch applied. > > On Fri, Jan 15, 2021 at 7:01 PM Aditya Toshniw

There is an error when checking the major version of servers in schema diff

Hi, The function get_round_val() outputs the wrong value when major version is before 10. For example, Source server version: 90500 Target server version: 90502 Or Source server version: 90502 Target server version: 90602 The attached patch shows the changes. -- Thanks && regards Hua