Re: [pgAdmin4][Patch] - RM 5457 - Kerberos Authentication - Phase 1

Hi, Please find the attached updated patch. Thanks, Khushboo On Thu, Jan 14, 2021 at 12:00 PM Akshay Joshi wrote: > Hi Khushboo > > Seems you have attached the wrong patch. Please send the updated patch. > > On Wed, Jan 13, 2021 at 2:35 PM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wr

Re: [pgAdmin4][Patch] - RM 5457 - Kerberos Authentication - Phase 1

Hi Khushboo Seems you have attached the wrong patch. Please send the updated patch. On Wed, Jan 13, 2021 at 2:35 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached updated patch. > > Thanks, > Khushboo > > On Fri, Jan 1, 2021 at 1:07 PM Aditya Toshniwa

[pgAdmin][RM-6120]: Adding/updating user should not allow to add an older date in account expires.

Hi Team, Please find the attached patch for RM-6120 : Adding/updating user should not allow to add an older date in account expires. Added UI validation if a user enters the account expiration date manually. -- *Thanks & Regards,* *Nikhil Mohite* *Soft

Is there a mistake in line 22 of Make.bat?

Hi, The following code is line 22 of Make.bat: if "%Platform%" == "X86" ( I tried `echo %Platform%` in VS2017 x86 native Tools Command Prompt, the result is "x86"(not "X86"). If it's a mistake, the attached patch adds the changes. Regrads, Huang Fix-Platfrom.patch Description: Fix-

pgAdmin 4 commit: Timestamp servers are few and far between now :-/

Timestamp servers are few and far between now :-/ Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0bd77937debe2bf7ccebd3e2010e76d501cad4dd Modified Files -- Make.bat | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgAdmin 4 commit: Use a working timestamp server.

Use a working timestamp server. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6a43c3d90b422f5bb1213e510256612db35e500e Modified Files -- Make.bat | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgAdmin 4 commit: Fixed syntax error in print function

Fixed syntax error in print function Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9dd357a9ee538aac3a0c6e3472c14a33d11a2cdf Modified Files -- web/pgadmin/misc/bgprocess/process_executor.py | 2 +- 1 file changed, 1 insertion(+), 1

Re: [pgAdmin4][Patch] - RM 5457 - Kerberos Authentication - Phase 1

Hi, Please find the attached updated patch. Thanks, Khushboo On Fri, Jan 1, 2021 at 1:07 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Khushboo, > > I've just done the code review. Apart from below, the patch looks good to > me: > > 1) Move the auth source constants -ldap

Re: Somewhat excessive version checks

On Tue, Jan 12, 2021 at 7:50 PM Magnus Hagander wrote: > On Tue, Jan 12, 2021 at 9:57 AM Dave Page wrote: > > > > On Mon, Jan 11, 2021 at 10:06 PM Magnus Hagander > wrote: > >> > >> Hi! > >> > >> If I read the code correctly, pgadmin will (unless turned off) hit the > >> website to check the ve