Re: [pgAdmin] RM5875 template1 is shown after you use pg_upgrade

2020-12-15 Thread Akshay Joshi
Thanks, patch applied. On Tue, Dec 15, 2020 at 2:46 PM Rahul Shirsat < rahul.shir...@enterprisedb.com> wrote: > Hi Hackers, > > Please find the attached patch below which resolves the issue of showing > template1 after pg_upgrade. > > Testing of the patch has been done on : > >1. Windows Serv

Re: [pgAdmin][RM-5343]: [Code Coverage] Improve API test cases for Debugger

2020-12-15 Thread Akshay Joshi
Thanks, patch applied. On Tue, Dec 15, 2020 at 4:20 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Team, > > Please find the updated patch for debugger test cases. > 1. Added check to skip debugger test case if the plugin is not installed. > 2. Added code to delete the existing "p

pgAdmin 4 commit: 1) Dirty indicator and save button issues.

2020-12-15 Thread Akshay Joshi
1) Dirty indicator and save button issues. 2) Text replacements as suggested by Dave. 3) Replace outlined icons with solid ones. 4) Add correct pgAdmin version in .pgerd files. 5) Do not show the download image option till it is completed. Branch -- ERDTool Details --- https://git.postgre

pgAdmin 4 commit: Ensure that the 'template1' database should not be vi

2020-12-15 Thread Akshay Joshi
Ensure that the 'template1' database should not be visible after pg_upgrade. Fixes #5875 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=cb0a914099a6abd72b9a69d07f59d32a6a3f9104 Author: Rahul Shirsat Modified Files -- docs/en_US/

pgAdmin 4 commit: 1. Added check to skip debugger test case if the plug

2020-12-15 Thread Akshay Joshi
1. Added check to skip debugger test case if the plugin is not installed. 2. Added code to delete the existing "pldbgapi" extension and create a new extension. 3. Updated a few test cases that are falling on specific servers. 4. Fixed test cases for pgAgent. Fixed by: Nikhil & Yogesh Branch

[pgAdmin][RM-6046]: [Query Tool] state of Save File icon does not match dirty editor indicator.

2020-12-15 Thread Nikhil Mohite
Hi Team, Please find the attached patch for RM-6046: [Query Tool] state of Save File icon does not match the dirty editor indicator. -- *Thanks & Regards,* *Nikhil Mohite* *Software Engineer.* *EDB Postgres* *Mob.No:

Re: [pgAdmin][RM-5343]: [Code Coverage] Improve API test cases for Debugger

2020-12-15 Thread Nikhil Mohite
Hi Team, Please find the updated patch for debugger test cases. 1. Added check to skip debugger test case if the plugin is not installed. 2. Added code to delete the existing "pldbgapi" extension and create a new extension. 3. Updated a few test cases that are falling on specific servers. Regard

[pgAdmin] RM5875 template1 is shown after you use pg_upgrade

2020-12-15 Thread Rahul Shirsat
Hi Hackers, Please find the attached patch below which resolves the issue of showing template1 after pg_upgrade. Testing of the patch has been done on : 1. Windows Server 2016 (PostgreSQL 12.5, compiled by Visual C++ build 1914, 64-bit & PostgreSQL 13.1, compiled by Visual C++ build 1914,