Re: pgAdmin 4 commit: Fixed an issue where the validation error message is

2020-12-02 Thread Murtuza Zabuawala
On Thu, Dec 3, 2020 at 12:29 PM Rahul Shirsat < rahul.shir...@enterprisedb.com> wrote: > > > On Thu, Dec 3, 2020 at 11:18 AM Murtuza Zabuawala < > murtuza.zabuaw...@enterprisedb.com> wrote: > >> Hello, >> >> Another observation, >> >> +if(msg && handler) { >> + msg = msg || _.valu

Re: pgAdmin 4 commit: Fixed an issue where the validation error message is

2020-12-02 Thread Rahul Shirsat
On Thu, Dec 3, 2020 at 11:18 AM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hello, > > Another observation, > > +if(msg && handler) { > + msg = msg || _.values(handler.errorModel.attributes)[0]; > + > + handler.trigger('pgadmin-session:model:invalid',

Re: pgAdmin 4 commit: Fixed an issue where the validation error message is

2020-12-02 Thread Murtuza Zabuawala
Hello, Another observation, +if(msg && handler) { + msg = msg || _.values(handler.errorModel.attributes)[0]; + + handler.trigger('pgadmin-session:model:invalid', msg, handler); + $(parentTr).addClass('error-in-grid'); +} +return this; + }, 1

Re: pgAdmin 4 commit: Fixed an issue where the validation error message is

2020-12-02 Thread Murtuza Zabuawala
Hello, What is the reason for adding delay *setTimeout(, 120)*? This is causing issues in automation testing and makes buttons enable/disable with slight delay. -- Regards, Murtuza Zabuawala *EDB* *POWER TO POSTGRES* https://www.edbpostgres.com On Fri, Oct 30, 2020 at 3:10 PM Akshay Joshi wro

Re: [pgAdmin][RM-5982]: Minor Documentation Issue: Example JSON not valid in current docs.

2020-12-02 Thread Akshay Joshi
Thanks, patch applied. On Wed, Dec 2, 2020 at 5:51 PM Nikhil Mohite wrote: > Hi Team, > > Please find the patch for RM-5982 > : > Minor > Documentation Issue: Example JSON not valid in current docs. >

Re: [pgAdmin][RM-6022]: Shared servers import is failing.

2020-12-02 Thread Akshay Joshi
Thanks, patch applied. On Wed, Dec 2, 2020 at 5:23 PM Nikhil Mohite wrote: > Hi Team, > > Please find the patch for RM-6022 > : Shared servers import is > failing. > added missing shared server flag while loading servers. > > -- > *Thanks & Regards,* >

Re: [pgAdmin][RM-5343]: [Code Coverage] Improve API test cases for Debugger

2020-12-02 Thread Akshay Joshi
Thanks, patch applied. On Wed, Dec 2, 2020 at 11:25 AM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Akshay, > > please find the updated patch, sorry for the inconvenience. > > > Regards, > Nikhil Mohite. > > On Wed, Dec 2, 2020 at 11:03 AM Akshay Joshi < > akshay.jo...@enterprisedb

Re: [pgAdmin][Patch] Bug #6003 - exibição errada de tabela em trigger de view (Wrong table display in view trigger)

2020-12-02 Thread Akshay Joshi
Thanks, patch applied. On Tue, Dec 1, 2020 at 9:13 PM Yogesh Mahajan < yogesh.maha...@enterprisedb.com> wrote: > Hi, > > Please find a patch which fixes incorrect view trigger sql display for > table sql. > > Thanks, > Yogesh Mahajan > EnterpriseDB > -- *Thanks & Regards* *Akshay Joshi* *pgAdm

pgAdmin 4 commit: Improve code coverage and API test cases for Debugger

2020-12-02 Thread Akshay Joshi
Improve code coverage and API test cases for Debugger. Fixes #5343 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=794bd50ed107254b87404e70c665fac6f9231f79 Author: Nikhil Mohite Modified Files -- docs/en_US/release_notes_4_29.rst

pgAdmin 4 commit: Fixed an issue where shared servers import is failing

2020-12-02 Thread Akshay Joshi
Fixed an issue where shared servers import is failing. Fixes #6022 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1c5cb63affc20cb87bed2e86bca0f275df3856f2 Author: Nikhil Mohite Modified Files -- docs/en_US/release_notes_4_29.rst

pgAdmin 4 commit: Fixed documentation issue where JSON is not valid. Fi

2020-12-02 Thread Akshay Joshi
Fixed documentation issue where JSON is not valid. Fixes #5982 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=12dc2c418d51ee396833c55e5e4ded00fbd5246e Author: Nikhil Mohite Modified Files -- docs/en_US/import_export_servers.rst |

pgAdmin 4 commit: Fixed an issue where an illegal argument is showing f

2020-12-02 Thread Akshay Joshi
Fixed an issue where an illegal argument is showing for trigger SQL when a trigger is created for View. Fixes #6003 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=26b3bc3f748ec3bd9395a4acbf325c5cf6b60d19 Author: Yogesh Mahajan Modified File

[pgAdmin][RM-5982]: Minor Documentation Issue: Example JSON not valid in current docs.

2020-12-02 Thread Nikhil Mohite
Hi Team, Please find the patch for RM-5982 : Minor Documentation Issue: Example JSON not valid in current docs. -- *Thanks & Regards,* *Nikhil Mohite* *Software Engineer.* *EDB Postgres*

[pgAdmin][RM-6022]: Shared servers import is failing.

2020-12-02 Thread Nikhil Mohite
Hi Team, Please find the patch for RM-6022 : Shared servers import is failing. added missing shared server flag while loading servers. -- *Thanks & Regards,* *Nikhil Mohite* *Software Engineer.* *EDB Postgres* *Mob.No: +

Re: SameSite issues in Safari Browser (reference #RM5975)

2020-12-02 Thread Dave Page
Hi On Tue, Dec 1, 2020 at 5:51 PM Rahul Shirsat wrote: > Hi Dave, > > Could you please add below FAQ point for SameSite Safari issue: > > Question : > When I set new tab settings for query tool or schema-diff, I get > "Connection to server lost" or "CSRF tokens do not match" on Safari > versions