Re: [pgAdmin][RM-5983]:Add server type icon on new connection dialog.

2020-11-12 Thread Akshay Joshi
Thanks, patch applied. On Wed, Nov 11, 2020 at 5:12 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Team, > > Regarding RM-5983 : Add > server type icon on new connection dialog. > > > -- > *Thanks & Regards,* > *Nikhil Mohite* > *Softwar

Re: [pgAdmin4] Enhance the Schema diff GUI validation

2020-11-12 Thread Akshay Joshi
Thanks, patch applied. On Tue, Nov 10, 2020 at 6:53 PM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA minor patch to add the validation in schema diff which will not allow > the user to compare the same objects in source and target dropdowns. > > -- > Regards, > Murt

Re: Patch for SonarQube code scan fixes

2020-11-12 Thread Akshay Joshi
Thanks, patch applied. On Tue, Nov 10, 2020 at 3:44 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Team, > > I have fixed some code smell issues in the SonarQube scan, PFA patch. > Details as follows: > > 1. Schema dif dependency: > >- 'isChecked' is already declared in the up

Re: SonarQube Fixes #3 + RM5985[pgAdmin4] Bgprocess watcher dialog box disappers and error occurs after server is removed

2020-11-12 Thread Akshay Joshi
Thanks, patch applied. On Thu, Nov 12, 2020 at 2:15 AM Rahul Shirsat < rahul.shir...@enterprisedb.com> wrote: > Hi Hackers, > > Please find below attached patch which fixes: > 1. Bgprocess watcher dialog box disappearing after server is removed > 2. Removed 3 dots on Storage Manager Dialog box (S

Re: [pgAdmin][RM-5974]: Debugger tab title (placeholders) does not apply to debugger opened in the new browser tab.

2020-11-12 Thread Akshay Joshi
Thanks, patch applied. On Thu, Nov 12, 2020 at 12:22 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Team, > > Regarding RM-5974 : Debugger > tab title (placeholders) does not apply to debugger opened in the new > browser tab. Also added

pgAdmin 4 commit: Fixed cognitive complexity reported by SonarQube.

2020-11-12 Thread Akshay Joshi
Fixed cognitive complexity reported by SonarQube. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a026f339c3fb26be746602fbf1a988bedc1232e3 Author: Nikhil Mohite Modified Files -- .../foreign_servers/user_mappings/__init__.py

pgAdmin 4 commit: 1) Fixed an issue where the process watcher dialog th

2020-11-12 Thread Akshay Joshi
1) Fixed an issue where the process watcher dialog throws an error for the database server which is already removed. Fixes #5985 2) Fixed cognitive complexity reported by SonarQube. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=be386e77f2e

pgAdmin 4 commit: Added validation in schema diff which will not allow

2020-11-12 Thread Akshay Joshi
Added validation in schema diff which will not allow the user to compare the same objects. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5839e7cda87b0b40d188e71c199308f501e69a19 Author: Murtuza Zabuawala Modified Files -- web/p

pgAdmin 4 commit: Fixed an issue where the debugger's custom tab title

2020-11-12 Thread Akshay Joshi
Fixed an issue where the debugger's custom tab title not applied when opened in the new browser tab. Fixes #5974 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ebf5e871e084a848774eee09bf072d103bd04b97 Author: Nikhil Mohite Modified Files --

pgAdmin 4 commit: Added the appropriate server icon based on the server

2020-11-12 Thread Akshay Joshi
Added the appropriate server icon based on the server type in the new connection dialog. Fixes #5983 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5370bb45151551cf99f40efd908ad666374719c4 Author: Nikhil Mohite Modified Files --

pgAdmin 4 commit: Tag REL-4_28 has been created.

2020-11-12 Thread Akshay Joshi
Tag REL-4_28 has been created. View: https://git.postgresql.org/gitweb?p=pgadmin4.git;a=tag;h=refs/tags/REL-4_28 Log Message --- Tag v4.28

pgAdmin 4 v4.28 released

2020-11-12 Thread Akshay Joshi
The pgAdmin Development Team is pleased to announce pgAdmin 4 version 4.28. This release of pgAdmin 4 includes 19 bug fixes and new features. For more details please see the release notes at: https://www.pgadmin.org/docs/pgadmin4/4.28/release_notes_4_28.html. pgAdmin is the leading Open Sourc

Re: pgAdmin4 v4.28 candidate builds

2020-11-12 Thread Fahar Abbas
@Akshay Joshi One Round of testing has been done, Can you please publish pgadmin4 4.28? On Mon, Nov 9, 2020 at 2:56 PM Akshay Joshi wrote: > > On Mon, Nov 9, 2020 at 3:24 PM Akshay Joshi > wrote: > >> Hi All, >> >> pgAdmin4 v4.27 candidate builds and source can be found at >> https://develop