Re: [pgAdmin4][Patch] - Jasmine Tests Fixes

Thanks, patch applied. On Wed, Oct 21, 2020 at 7:08 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to fix the Jasmine tests failure. > It was due to 18cad32bd4541e1993a051028bee81a2310d020c commit. > > Thanks, > Khushboo > -- *Thanks & Rega

pgAdmin 4 commit: Fixed Jasmine test cases.

Fixed Jasmine test cases. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9b4317fb2519ab0ab9e441ceac92ddbb2a7c38b4 Author: Khushboo Vashi Modified Files -- .../javascript/file_manager/file_manager_specs.js | 59 ++

[pgAdmin4][Patch] - Jasmine Tests Fixes

Hi, Please find the attached patch to fix the Jasmine tests failure. It was due to 18cad32bd4541e1993a051028bee81a2310d020c commit. Thanks, Khushboo jasmine_test_fixes.patch Description: Binary data

Re: [pgAdmin][RM3794]:Allow User to Change Database Connection from an Open Query Tool Tab

Thanks, patch applied. On Wed, Oct 21, 2020 at 4:45 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Akshay, > > I have fixed the review comments, PFA the updated patch for the same. > > > Regards, > Nikhil Mohite. > > On Wed, Oct 21, 2020 at 2:55 PM Akshay Joshi < > akshay.jo...@en

pgAdmin 4 commit: Following issues have been resolved for the new conne

Following issues have been resolved for the new connection feature: 1. Show servers with server groups in the dropdown. 2. Highlighted current selected connection in the new connection dropdown. 3. Notify the user before changing the connection. refs #3794 Branch -- master Details

Re: [pgAdmin][RM3318] Download Backup Files

Hi Rahul Following are the review comments: - Add "..." to the Storage Manager menu. - Storage manager icon is not visible on process watcher if we provide file name without directory. - Renaming the directory not working from Storage Manager. Please fix and send the patch. On Tue,

Re: [pgAdmin][RM3794]:Allow User to Change Database Connection from an Open Query Tool Tab

Hi Akshay, I have fixed the review comments, PFA the updated patch for the same. Regards, Nikhil Mohite. On Wed, Oct 21, 2020 at 2:55 PM Akshay Joshi wrote: > Hi Nikhil > > Following are the review comments: > >- Connect to any server from the browser tree. Open the query tool and >th

Re: [pgAdmin][RM3794]:Allow User to Change Database Connection from an Open Query Tool Tab

Hi Nikhil Following are the review comments: - Connect to any server from the browser tree. Open the query tool and then open the new connection dialog. Click on the "OK" button without changing any field. It shows the popup for "Change connection" which should not be raised because t