Re: [pgAdmin][RM3794]:Allow User to Change Database Connection from an Open Query Tool Tab

2020-10-20 Thread Nikhil Mohite
Hi Akshay, I have updated the existing implementation as per suggestions. 1. Show servers in server groups in the dropdown. 2. Current selected connection in the new connection dropdown is now highlighted as selected. 3. Notification to the user before the change connection action. 4. If we connec

[pgAdmin][RM3318] Download Backup Files

2020-10-20 Thread Rahul Shirsat
Hi Hackers, Please find the below patch which allows users to download the backup and export files generated on shared drive. -- *Rahul Shirsat* Software Engineer | EnterpriseDB Corporation. RM3318.patch Description: Binary data

pgAdmin 4 commit: Fixed an issue where the suffix for Toast table size

2020-10-20 Thread Akshay Joshi
Fixed an issue where the suffix for Toast table size is not visible in the Statistics tab. Fixes #5895 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7b9504bdfb729ce22091271c1c91e70c3475f7b9 Author: Pradip Parkale Modified Files ---

Re: [pgAdmin][RM5895]Toast table size in Statistics tab has no suffix

2020-10-20 Thread Akshay Joshi
Thanks, patch applied. On Mon, Oct 19, 2020 at 10:57 AM Pradip Parkale < pradip.park...@enterprisedb.com> wrote: > Hi Hackers, > Please find the attached patch for #RM5895. Toast table size unit was > missing. > > -- > Thanks & Regards, > Pradip Parkale > Software Engineer | EnterpriseDB Corporat

Re: [pgAdmin4][RM4232]: Change what is shown by default in tab titles

2020-10-20 Thread Akshay Joshi
Thanks, patch applied. On Tue, Oct 20, 2020 at 9:07 AM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Akshay, > > I have resolved the review comments and also added a %ARGS% placeholder > for the debugger. > PFA patch v2. > > Regards, > Nikhil Mohite. > > On Mon, Oct 19, 2020 at 10:5

pgAdmin 4 commit: Ensure that some fields should be disabled for the tr

2020-10-20 Thread Akshay Joshi
Ensure that some fields should be disabled for the trigger in edit mode. Fixes #4639 Fixed illegal argument issue in the trigger for EPAS servers. Fixes #5799 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3413a42af41ccbdad71ea2ef38edd7fe5eb

pgAdmin 4 commit: Added tab title placeholder for Query Tool, View/Edit

2020-10-20 Thread Akshay Joshi
Added tab title placeholder for Query Tool, View/Edit Data, and Debugger. Fixes #4232 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=18cad32bd4541e1993a051028bee81a2310d020c Author: Nikhil Mohite Modified Files -- docs/en_US/ima

Re: [pgAdmin][5919] Fix security related issues

2020-10-20 Thread Akshay Joshi
Thanks, patch applied. On Mon, Oct 19, 2020 at 7:17 PM Ganesh Jaybhay < ganesh.jayb...@enterprisedb.com> wrote: > Thank you Dave for the suggestion. > > Please find the attached updated patch to make HSTS by default disabled > and conditional based on flag. > > Regards, > Ganesh Jaybhay > > On Mo

Re: [pgAdmin][RM4639]: Truncate Trigger option should enabled in properties sections if trigger is already created without each rows

2020-10-20 Thread Akshay Joshi
Thanks, patch applied. On Tue, Oct 20, 2020 at 2:59 PM Pradip Parkale < pradip.park...@enterprisedb.com> wrote: > Hi Hackers, > Please find the attached for RM4639 and RM5779. For the trigger, most of > the fields will be disabled in edit mode. > > > -- > Thanks & Regards, > Pradip Parkale > Soft

pgAdmin 4 commit: Added following security enhancements:

2020-10-20 Thread Akshay Joshi
Added following security enhancements: 1) Added ALLOWED_HOSTS list to limit the host address. 2) Added CSP and HSTS security header. 3) Hide the webserver/ development framework version. Fixes #5919 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=com

[pgAdmin][RM4639]: Truncate Trigger option should enabled in properties sections if trigger is already created without each rows

2020-10-20 Thread Pradip Parkale
Hi Hackers, Please find the attached for RM4639 and RM5779. For the trigger, most of the fields will be disabled in edit mode. -- Thanks & Regards, Pradip Parkale Software Engineer | EnterpriseDB Corporation RM4639.patch Description: Binary data

Re: small change to Documentation - Creating a table

2020-10-20 Thread Nidhi Bhammar
Sure, will do that. Thanks, Best Regards, Nidhi Bhammar www.enterprisedb.com On Tue, Oct 20, 2020 at 1:10 PM Akshay Joshi wrote: > Hi Nidhi > > On Tue, Oct 20, 2020 at 2:51 AM Corey Fehr wrote: > >> Hi >> The documentation doesn't seem to say where to send improvements related >> to the do

Re: small change to Documentation - Creating a table

2020-10-20 Thread Akshay Joshi
Hi Nidhi On Tue, Oct 20, 2020 at 2:51 AM Corey Fehr wrote: > Hi > The documentation doesn't seem to say where to send improvements related > to the documentation. > > New postgresql DB, I just wanted to create a simple table. > The Quick Start section suggests using Cast, which is unhelpful: > h