Re: [pgAdmin][RM3794]:Allow User to Change Database Connection from an Open Query Tool Tab

2020-10-06 Thread Nikhil Mohite
Hi Akshay, I checked the implementation and found 2 locations which I missed in the last patch to remove async: False. I have removed all occurrences of async: False now also added missing loader in required places. PFA updated the patch for the same. Regards, Nikhil Mohite. On Tue, Oct 6, 2020

pgAdmin 4 commit: Fixed API test cases failed for PG 9.5 due to change

2020-10-06 Thread Akshay Joshi
Fixed API test cases failed for PG 9.5 due to change in the order of ACL. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f27527a614fa7acb278afe1ac5bc304423d5f651 Modified Files -- .../schemas/functions/templates/functions/pg/sql/d

Re: [pgAdmin][RM3794]:Allow User to Change Database Connection from an Open Query Tool Tab

2020-10-06 Thread Akshay Joshi
Hi Nikhil Please verify and remove async = false wherever possible. On Tue, Oct 6, 2020 at 5:24 PM Dave Page wrote: > > > On Tue, Oct 6, 2020 at 12:51 PM Murtuza Zabuawala < > murtuza.zabuaw...@enterprisedb.com> wrote: > >> Hi Akshay, >> >> We have used aysnc=False in most ajax calls with this

Re: [pgAdmin][RM5395]: [Housekeeping]-Add RE-SQL/MSQL test cases for Functions

2020-10-06 Thread Akshay Joshi
Thanks, patch applied. Modified the behavior and also updated test cases accordingly. On Mon, Oct 5, 2020 at 6:24 PM Nikhil Mohite wrote: > Hi Team, > > I have added a few more RE-SQL/MSQL test cases as per RM-5395 > . > PFA patch. > > -- > *Thanks & R

Re: RM_5857 patch - Macros Documentation

2020-10-06 Thread Akshay Joshi
Thanks, patch applied. On Tue, Oct 6, 2020 at 4:10 PM Nidhi Bhammar wrote: > Hi, > > I have drafted the documentation for the Macros and attached the patch for > the same. Also, I have replaced all the query tool screenshots so that the > Macros icon is visible. > > Let me know your review comme

Re: [pgAdmin][RM5822]: Unable to change Start value for existing sequence

2020-10-06 Thread Akshay Joshi
Thanks, patch applied. On Mon, Oct 5, 2020 at 3:48 PM Pradip Parkale < pradip.park...@enterprisedb.com> wrote: > Hi Hackers, > > Please find the attached patch to allow the user to change the start value > of the existing sequence. > > -- > Thanks & Regards, > Pradip Parkale > Software Engineer |

Re: [pgAdmin][RM5835]: "can't execute an empty query" message displayed if user change the option of Auto FK index ? with No

2020-10-06 Thread Akshay Joshi
Thanks, patch applied. On Tue, Oct 6, 2020 at 1:51 PM Pradip Parkale < pradip.park...@enterprisedb.com> wrote: > Hi Hackers, > Attached is small patch to disable the Auto FK index? option to avoid > 'can't execute an empty query' message. > > -- > Thanks & Regards, > Pradip Parkale > Software Eng

pgAdmin 4 commit: Fixed 'can't execute an empty query' message if the u

2020-10-06 Thread Akshay Joshi
Fixed 'can't execute an empty query' message if the user change the option of Auto FK Index. Fixes #5835 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=82e912ffad8e3fab2dbe4c953055de704f966c97 Author: Pradip Parkale Modified Files -

pgAdmin 4 commit: Added documentation for Macro support. Fixes #5857

2020-10-06 Thread Akshay Joshi
Added documentation for Macro support. Fixes #5857 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=609904cfb324ff75f0207f9f3c5d27c830cd2030 Author: Nidhi Bhammar Modified Files -- docs/en_US/images/query_autocomplete.png

pgAdmin 4 commit: Added RESQL/MSQL test cases for Functions. Fixes #539

2020-10-06 Thread Akshay Joshi
Added RESQL/MSQL test cases for Functions. Fixes #5395 Initial patch sent by Nikhil Mohite. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6c4049f29a36e2193aca786c5f7db5c2fe997939 Modified Files -- docs/en_US/release_notes_4_27.r

Re: [pgAdmin][RM3794]:Allow User to Change Database Connection from an Open Query Tool Tab

2020-10-06 Thread Murtuza Zabuawala
Hi Akshay, We have used aysnc=False in most ajax calls with this feature, It is causing UI hang in case of slow server response. You can try adding a time.sleep() call at the python side response and check the UI hang, I think we should avoid sync calls as much as possible. -- Regards, Murtuza Z

Re: [pgAdmin][RM3794]:Allow User to Change Database Connection from an Open Query Tool Tab

2020-10-06 Thread Nikhil Mohite
Hi Akshay, I have updated the following points as per suggestions: 1. Updated connection success message. (Added database name in the success message.) 2. Resolve issue of the mouse pointer and dropdown will show below the connection string only. 3. Added loader for both new connections and load e

[pgAdmin][RM5835]: "can't execute an empty query" message displayed if user change the option of Auto FK index ? with No

2020-10-06 Thread Pradip Parkale
Hi Hackers, Attached is small patch to disable the Auto FK index? option to avoid 'can't execute an empty query' message. -- Thanks & Regards, Pradip Parkale Software Engineer | EnterpriseDB Corporation RM5835.patch Description: Binary data