Re: [pgAdmin][RM5843] [SQL] - Some 'options' values for function not shown in sql

2020-09-23 Thread Pradip Parkale
Hi Akshay, Please find the small patch for the ' Parallel Unsafe' option is missing in SQL. It was missing in first patch for PG96 and PG10. On Wed, Sep 23, 2020 at 1:25 PM Akshay Joshi wrote: > Thanks, patch applied. It's a small fix so I have fixed it. > > On Wed, Sep 23, 2020 at 12:14 PM Ak

Re: [pgAdmin4][Patch] - RM 1402 - Macro support like pgAdmin3

2020-09-23 Thread Akshay Joshi
Hi Khushboo Following are the GUI review comments: - If we provide anyone value either Name or SQL it throws Alertify error message with 'name' or 'SQL'. The error message should be correct. [image: Name_Error.png] - We should not enable the 'Save' button if the value of Nam

[pgAdmin][RM5861]:Remove server' option is not available through context click

2020-09-23 Thread Pradip Parkale
Hi Hackers, Please find the attached patch following the issue. 1. The 'Remove server' option is not available. 2. 'Shared server owner' property is visible in a desktop mode which shouldn't. -- Thanks & Regards, Pradip Parkale Software Engineer | EnterpriseDB Corporation RM5861.pat

Re: [pgAdmin][RM5843] [SQL] - Some 'options' values for function not shown in sql

2020-09-23 Thread Akshay Joshi
Thanks, patch applied. It's a small fix so I have fixed it. On Wed, Sep 23, 2020 at 12:14 PM Akshay Joshi wrote: > Hi Pradip > > RESQL tests are failing on EPAS 9.5, 9.6, and 10. Please fix and resend > the patch. > > On Tue, Sep 22, 2020 at 6:41 PM Pradip Parkale < > pradip.park...@enterprisedb

pgAdmin 4 commit: Fixed an issue where the 'PARALLEL UNSAFE' option is

2020-09-23 Thread Akshay Joshi
Fixed an issue where the 'PARALLEL UNSAFE' option is missing from reverse engineering SQL of function/procedure node. Fixes #5843. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2e55b1f660f4615fde8510f0358a528454b453a0 Author: Pradip Parkale

pgAdmin 4 commit: Fixed cognitive complexity issues reported by SonarQu

2020-09-23 Thread Akshay Joshi
Fixed cognitive complexity issues reported by SonarQube. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f3462e36a422ac7d4073e4881ebc7da994ba774b Author: Aditya Toshniwal Modified Files -- web/pgadmin/misc/file_manager/__init__.py