Re: RM5841: server.username can be empty when using .pg_service.conf

Hi Akshay, Please find the updated patch. On Mon, Sep 21, 2020 at 4:41 PM Pradip Parkale < pradip.park...@enterprisedb.com> wrote: > Hi Akshay, > > > On Mon, Sep 21, 2020 at 9:30 AM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Pradip >> >> Can you please review the patch as tha

Re: [pgAdmin][RM5330]: [Code Coverage] Improve API test cases for Functions

Hi Nikhil Test cases are failing for all the database server with the following error: return True, sql.strip('\n') AttributeError: 'tuple' object has no attribute 'strip' Please check and resend the patch. On Tue, Sep 22, 2020 at 10:56 AM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrot

[pgAdmin][SonarQube] Reduce cognitive complexity

Hi Hackers, Attached path will reduce the cognitive complexity as below:web/pgadmin/misc/file_manager/__init__.py 40 to 15; 43 to 15 Please review. -- Thanks, Aditya Toshniwal pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* "Don't Complain about Heat, Plant

[pgAdmin][RM5330]: [Code Coverage] Improve API test cases for Functions

Hi Team, I have added few more test cases for the "Functions" module as per RM-5330 PFA patch. -- *Thanks & Regards,* *Nikhil Mohite* *Software Engineer.* *EDB Postgres* *Mob.No: +91-7798364578.* RM_5330_v1.patch Desc

Re: pgAdmin 4 commit: Fixed an issue where the query tool is not fetching m

Murtuza, Please make sure this one is merged. — Ashesh On Tue, 22 Sep 2020 at 09:46, Akshay Joshi wrote: > Fixed an issue where the query tool is not fetching more than 1000 rows > for the table does not have any primary key. Fixes #5845 > > > > Branch > > -- > > master > > > > Details > >

Re: [pgAdmin][RM5739]: Export feature(COPY) does not work with SSH tunnel

Thanks, patch applied. On Mon, Sep 21, 2020 at 4:18 PM Pradip Parkale < pradip.park...@enterprisedb.com> wrote: > Hi Hackers, > > Export feature does not work with the SSH tunnel. Attached is the patch to > fix the issue. > > -- > Thanks & Regards, > Pradip Parkale > Software Engineer | Enterpris

Re: [pgAdmin][RM5845] Free query windows hard capped to 1000 results sometimes

Thanks, patch applied. On Mon, Sep 21, 2020 at 1:37 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to fix the issue where the query tool is not > fetching more than 1000 rows. The issue occurs only when a table does not > have any primary k

pgAdmin 4 commit: Fixed an issue where the query tool is not fetching m

Fixed an issue where the query tool is not fetching more than 1000 rows for the table does not have any primary key. Fixes #5845 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ed3c692b1fc7615a91910a1ea53411bced6b6176 Author: Aditya Toshniwal

pgAdmin 4 commit: Ensure that the import/export feature should work wit

Ensure that the import/export feature should work with SSH Tunnel. Fixes #5739 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1ee9cddcebcc2178c5ec80008790ffc055ad05a3 Author: Pradip Parkale Modified Files -- docs/en_US/release_no

Re: [pgAdmin][RM3794]:Allow User to Change Database Connection from an Open Query Tool Tab

Hi Nikhil Following are the initial review comments: - Open View/Edit data on any table and click on the same database connection and then click on the Execute button. Got "get_primary_keys() takes 1 positional argument but 2 were given" error. - In my opinion, we should hide the opti

Re: RM5841: server.username can be empty when using .pg_service.conf

Hi Akshay, On Mon, Sep 21, 2020 at 9:30 AM Akshay Joshi wrote: > Hi Pradip > > Can you please review the patch as that condition we have added for Shared > Server implementation? > Yes, we have added this for the shared server implementation. Please find the attached for this issue. > > On Sat

[pgAdmin][RM5739]: Export feature(COPY) does not work with SSH tunnel

Hi Hackers, Export feature does not work with the SSH tunnel. Attached is the patch to fix the issue. -- Thanks & Regards, Pradip Parkale Software Engineer | EnterpriseDB Corporation RM5739.patch Description: Binary data

[pgAdmin4][Patch] - RM 1402 - Macro support like pgAdmin3

Hi, Please find the attached patch for RM 1402 - Macro support like pgAdmin3. Thanks, Khushboo RM_1402.patch Description: Binary data

[pgAdmin][RM5845] Free query windows hard capped to 1000 results sometimes

Hi Hackers, Attached is the patch to fix the issue where the query tool is not fetching more than 1000 rows. The issue occurs only when a table does not have any primary key. Please review. -- Thanks, Aditya Toshniwal pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*