Re: [pgAdmin4][Patch] - SonarQube Issues - 15 (String literals should not be duplicated)

Thanks, patch applied. With small modification. On Fri, Aug 28, 2020 at 5:43 PM Yogesh Mahajan < yogesh.maha...@enterprisedb.com> wrote: > Hello, > > Please find patch which fixes issues related to rule from feature test > modules - > 1.String literals should not be duplicated - 15 issues > > Tha

Re: [pgAdmin][Patch] RM5426 - [pgagent]: Codemirror control height should use maximum space while creating jobstep

Thanks, patch applied. On Thu, Aug 27, 2020 at 9:00 PM Yogesh Mahajan < yogesh.maha...@enterprisedb.com> wrote: > Hello, > > Attached patch shows maximum available space in code tab in job-step > creation while creating a job. > > Thanks, > Yogesh Mahajan > QA - Team > EnterpriseDB Corporation >

Re: pgAdmin 4 commit: Fixed cognitive complexity issues and added some more

Thanks, patch applied. On Fri, Aug 28, 2020 at 5:50 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > Problem doesn't seem to go away for the newly added test cases. The > default roles like pg_monitor, etc. do not exist for PG9.6 and below, and > so the RESQL test cases a

pgAdmin 4 commit: Fixed RESQL test cases for Roles module.

Fixed RESQL test cases for Roles module. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=11d561386636770d5d01d3110db52c9023c6b083 Author: Aditya Toshniwal Modified Files -- .../roles/templates/roles/sql/9.4_plus/sql.sql | 2 +

pgAdmin 4 commit: Adjusted the height of jobstep code block to use maxi

Adjusted the height of jobstep code block to use maximum space. Fixes #5426. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e226b2fa7596e49eb645d0fdb5df9fba579b9f62 Author: Yogesh Mahajan Modified Files -- docs/en_US/release_note

pgAdmin 4 commit: Fixed code smell 'String literals should not be dupli

Fixed code smell 'String literals should not be duplicated'. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3984544bdba29c87f6225061ed5577ebd2eb77e6 Author: Yogesh Mahajan Modified Files -- .../browser/server_groups/servers/__ini

pgAdmin 4 commit: Added a new button to the query tool toolbar to open

Added a new button to the query tool toolbar to open a new query tool window. Fixes #4059 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e8b192be3edd5a4336407e94a4da078b130306c5 Author: Rahul Shirsat Modified Files -- docs/en_US

Re: pgAdmin 4 commit: Fixed cognitive complexity issues and added some more

Hi, Problem doesn't seem to go away for the newly added test cases. The default roles like pg_monitor, etc. do not exist for PG9.6 and below, and so the RESQL test cases are failing :(. I've modified the test cases to add 2 new roles for testing and then drop them later. Please review. On Thu,

[pgAdmin4][Patch] - SonarQube Issues - 15 (String literals should not be duplicated)

Hello, Please find patch which fixes issues related to rule from feature test modules - 1.String literals should not be duplicated - 15 issues Thanks, Yogesh Mahajan QA - Team EnterpriseDB Corporation Phone: +91-9741705709 SonarQubeFix15_v1.patch Description: Binary data