[pgAdmin][Patch] RM5426 - [pgagent]: Codemirror control height should use maximum space while creating jobstep

Hello, Attached patch shows maximum available space in code tab in job-step creation while creating a job. Thanks, Yogesh Mahajan QA - Team EnterpriseDB Corporation Phone: +91-9741705709 RM5426_v1.patch Description: Binary data

Re: Bug #5775: setup-web.sh don't works in debian 10?

Thanks, patch applied. I don't have Debian 10 machine but on eyeball, review code looks good to me. On Thu, Aug 27, 2020 at 6:14 PM Dave Page wrote: > Here's a patch for $SUBJECT. I've done some testing here, but please > double check it's correct before committing! > > Thanks. > > -- > Dave Pag

Re: pgAdmin 4 commit: Fixed cognitive complexity issues and added some more

Thanks, patch applied. On Thu, Aug 27, 2020 at 4:31 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached patch introduces a new key - replace_regex_pattern for RE-SQL > test cases. It will synchronize the expected SQL with the backend SQL based > on the regex

pgAdmin 4 commit: Fixed RE-SQL test cases failed due to the previous co

Fixed RE-SQL test cases failed due to the previous commit. Introduces a new key - replace_regex_pattern to synchronize the expected SQL with the backend SQL based on the regex string Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=28b637c99c60

pgAdmin 4 commit: Ensure that 'setup-web.sh' should work in Debian 10.

Ensure that 'setup-web.sh' should work in Debian 10. Fixes #5775. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8368eed645ebd710d48124c322cfff1acc8e27c0 Author: Dave Page Modified Files -- docs/en_US/release_notes_4_26.rst | 3

Re: #4059 Query tool new tab recurrence

On Thu, Aug 27, 2020 at 10:20 AM Rahul Shirsat < rahul.shir...@enterprisedb.com> wrote: > *Removing DL not related PG directly.* > > ++pgadmin-hackers. > > On Thu, Aug 27, 2020 at 1:48 PM Rahul Shirsat < > rahul.shir...@enterprisedb.com> wrote: > >> Hi Dave, >> >> Working on one of the features #4

Bug #5775: setup-web.sh don't works in debian 10?

Here's a patch for $SUBJECT. I've done some testing here, but please double check it's correct before committing! Thanks. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EDB: http://www.enterprisedb.com RM_5775.diff Description: Binary data

Re: pgAdmin 4 commit: Fixed cognitive complexity issues and added some more

Hi Hackers, Attached patch introduces a new key - replace_regex_pattern for RE-SQL test cases. It will synchronize the expected SQL with the backend SQL based on the regex string. This will help fix the timezone mismatch issue occurring in RESQL test cases for roles. Please review. On Thu, Aug 2

Re: #4059 Query tool new tab recurrence

*Removing DL not related PG directly.* ++pgadmin-hackers. On Thu, Aug 27, 2020 at 1:48 PM Rahul Shirsat < rahul.shir...@enterprisedb.com> wrote: > Hi Dave, > > Working on one of the features #4059 > , assume that query tool is > open in a new tab, and

Re: pgAdmin 4 commit: Fixed cognitive complexity issues and added some more

Hi, I'll look into it. On Thu, Aug 27, 2020 at 2:41 PM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > RE-SQL test for the role node is failing if the timezone of DB is > different. > > Traceback (most recent call last): > File > "/home/murtuza/projects/PEM/web/regress

Re: pgAdmin 4 commit: Fixed cognitive complexity issues and added some more

Hi, RE-SQL test for the role node is failing if the timezone of DB is different. Traceback (most recent call last): File "/home/murtuza/projects/PEM/web/regression/re_sql/tests/test_resql.py", line 500, in check_re_sql self.assertEquals(sql, resp_sql) File "/usr/lib/python3.6/unittest/cas

Re: [pgAdmin][Patch] RM4216 - Schema list does not support standard_conforming_strings set to off

Thanks, patch applied. On Wed, Aug 26, 2020 at 4:09 PM Yogesh Mahajan < yogesh.maha...@enterprisedb.com> wrote: > Hello, > > Please find a patch which enables pgAdmin4 to show schema names starting > with 'pg' under schema node when 'standard_conforming_strings = off'. > (Default is on) for datab

Re: [pgAdmin][SonarQube] Cognitive complexity roles + test cases

Thanks, patch applied. On Thu, Aug 27, 2020 at 12:49 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to reduce the cognitive complexity for > validate_request function in roles module from 258 to 15. I've also added a > few more test scenari

Re: [PATCH] Fix pgAdmin4 v4.25 ignoring user configuration. Fixes #5773

Thanks, patch applied. On Wed, Aug 26, 2020 at 11:13 PM Chris Mayo wrote: > --- > runtime/Runtime.cpp | 22 ++ > runtime/Runtime.h | 1 - > 2 files changed, 14 insertions(+), 9 deletions(-) > > -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Sr. Software Architec

pgAdmin 4 commit: Ensure that schema names starting with 'pg' should be

Ensure that schema names starting with 'pg' should be visible in browser tree when standard_conforming_strings is set to off. Fixes #4216 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f3bde7b5f184f8a6a5861212991d15dfa9651265 Author: Yogesh M

pgAdmin 4 commit: Fixed an issue where the application ignores the fixe

Fixed an issue where the application ignores the fixed port configuration value. Fixes #5773 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0998d349cae23c48324d5b8b53f5ed609ba834a5 Author: Chris Mayo Modified Files -- docs/en_US

pgAdmin 4 commit: Modified the 'Commit' and 'Rollback' query tool butto

Modified the 'Commit' and 'Rollback' query tool button icons. Fixes #5662 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8222bf64200b7fe2ae02f0a97ed22b8414b71a23 Author: Chethana Kumar Modified Files -- docs/en_US/release_notes_4

pgAdmin 4 commit: Fixed cognitive complexity issues and added some more

Fixed cognitive complexity issues and added some more RESQL test cases for roles module. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=53a54103379840795fc03f5940cb53dd99ff0ee9 Author: Aditya Toshniwal Modified Files -- .../serv

Re: SCSS Minor SonarQube fixes

Hi Pramod, - font-family: monospace, monospace; + font-family: 'Roboto Mono', monospace; We do not use Roboto for codemirror. Please revert the change. Regarding "monospace, monospace;", this is required by firefox. On Thu, Aug 27, 2020 at 1:06 PM Akshay Joshi wrote: > Hi Aditya > > Can you

Re: SCSS Minor SonarQube fixes

Hi Aditya Can you please review the patch? On Thu, Aug 27, 2020 at 11:25 AM Pramod Ahire wrote: > Hi, > > > > Please find attached minor fixes for sonarqube, which includes changes as > below: > > > >- Removed duplicate CSS declaration >- Added proper font with font-family > > > > Pleas

[pgAdmin][SonarQube] Cognitive complexity roles + test cases

Hi Hackers, Attached is the patch to reduce the cognitive complexity for validate_request function in roles module from 258 to 15. I've also added a few more test scenarios in the roles RE-SQL test cases to make sure the changes are tested. Please review. -- Thanks, Aditya Toshniwal pgAdmin hac