Re: [pgAdmin][SonarQube] Cognitive complexity

2020-08-24 Thread Akshay Joshi
Hi Aditya Please fix the following issues: - Add docstrings to the newly created functions. - Fix PEP8 issue. On Mon, Aug 24, 2020 at 5:02 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached patch reduces the cognitive complexity of functions for b

how to completely uninstall?

2020-08-24 Thread Kurt Snyder
Hi -- I have a pgAdmin 4 install on Mac now that is unusable as the app will not start and I was hoping to try a fresh reinstall after wiping everything, but I don't know where to find files it is using. I'm on MacOS 10.14.6. When I start the app it runs a bit with lots of CPU then says "The pgAdm

[pgAdmin][RM5751] Enable the runtime menu when the timeout occurs

2020-08-24 Thread Akshay Joshi
Hi Dave/Hackers Attached is the patch to fix the following issues: - Enable the 'Configure' and 'View log' menu option when the server taking longer than usual time to start. - When an error occurs from the backend, the configure window opens and if the user has changed the setting of

[pgAdmin][RM-5748][RESQL] Incorrect SQL for Foreign key when creating a table

2020-08-24 Thread Nikhil Mohite
Hi Team, I have resolved the issue in SQL statements to add foreign while creating table RM-5748 . PFA patch. Regards, Nikhil Mohite. RM_5748_v1.patch Description: Binary data

[pgAdmin][SonarQube] Cognitive complexity

2020-08-24 Thread Aditya Toshniwal
Hi Hackers, Attached patch reduces the cognitive complexity of functions for below: web/.../schemas/packages/edbfuncs/__init__.py 21 to 15 web/.../databases/schemas/types/__init__.py 39 to 15; 80 to 15 web/.../server_groups/servers/pgagent/__init__.py 39 to 15 web/pgadmin/misc/bgprocess/process_ex

Re: [pgAdmin][SonarQube]: Cognitive complexity

2020-08-24 Thread Pradip Parkale
Hi Akshay, Please find the updated patch. On Fri, Aug 21, 2020 at 11:53 AM Akshay Joshi wrote: > Hi Pradip > > Following are the review comments: > >- Change the function name to "_get_supported_browser" instead of >"_get_browser_supported". > > Fixed. > >- Added docstring to the fu

[pgAdmin][RM5722]: Not able to drop database.

2020-08-24 Thread Pradip Parkale
Hi Hackers, Please find the attached patch. Now, with this patch user can drop a database even if it is connected. -- Thanks & Regards, Pradip Parkale Software Engineer | EnterpriseDB Corporation RM5622.patch Description: Binary data