Re: pgAdmin debugger failure when search_path set

Hi Akshay, On Tue, Aug 11, 2020 at 12:13 PM Akshay Joshi wrote: > Hi Aditya > > On Thu, Aug 6, 2020 at 4:48 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Dave/Team, >> >> I've been working on an issue to make debugger work no matter what the >> search patch is set. I'

Re: pgAdmin debugger failure when search_path set

Hi Aditya On Thu, Aug 6, 2020 at 4:48 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Dave/Team, > > I've been working on an issue to make debugger work no matter what the > search patch is set. I've managed to call the appropriate functions from > pgAdmin using a schema qual

[pgAdmin][SonarQube] Reduce cognitive complexity

Hi Hackers, Attached patch will reduce cognitive complexity for functions as below: web/.../servers/pgagent/schedules/__init__.py - 17 to 15 web/.../servers/pgagent/steps/__init__.py - 21 to 15; 29 to 15 web/pgadmin/setup/user_info.py - 22 to 15 web/pgadmin/utils/preferences.py - 29 to 15; 44 to 1

pgAdmin 4 commit: Added missing comments in reverse engineering SQL for

Added missing comments in reverse engineering SQL for each column of a View. Fixes #3791 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2907a79dd7b33184ea81e868f2c82643fa1ee4c0 Author: Rahul Shirsat Modified Files -- docs/en_US/

pgAdmin 4 commit: Fixed API test cases for packages.

Fixed API test cases for packages. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=46af290b855fafb481fec3582e3cd04f15bbed1c Modified Files -- .../server_groups/servers/databases/schemas/packages/__init__.py| 2 ++ 1 file cha

Re: Patch for SonarQube code scan fixes.

Thanks, patch applied. On Mon, Aug 10, 2020 at 3:39 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Team, > > I have fixed some code smell issues in the SonarQube scan, PFA patch. > Details as follows: > > 1. Schema dif directory compare: > >- Refactor this function to reduce i

Re: Bug #5664 SQL DDL output generator for view

Thanks, patch applied. On Fri, Aug 7, 2020 at 8:00 PM Rahul Shirsat wrote: > Hi Hackers, > > Please find the attached patch below which resolves the following issue of > SQL DDL output generator for view (preserving default values of columns) > > Also, when changing VIEW's column's default value

Re: Use python3 ipaddress module to validate ipaddress

Thanks, patch applied. On Mon, Aug 10, 2020 at 4:25 AM Cyril Jouve wrote: > > -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Sr. Software Architect* *EDB Postgres * *Mobile: +91 976-788-8246*

Re: [pgAdmin][RM5526] Copy and paste multiline cells

Thanks, patch applied. On Mon, Aug 10, 2020 at 3:46 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to fix an issue where copying and pasting a cell > with multiple line data will result in multiple rows. This is a regression > of #3947. > T

pgAdmin 4 commit: Modified schema diff tool to compare two databases in

Modified schema diff tool to compare two databases instead of two schemas. Fixes #5126 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4f74609ecfc73826c418df95c173b7f87ce2917c Modified Files -- docs/en_US/images/schema_diff_DDL_co

pgAdmin 4 commit: Use Python3 'ipaddress' module to validate the IPv4 a

Use Python3 'ipaddress' module to validate the IPv4 and IPv6 addresses. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7a0bfecfc5ac6034cb183bf41a8fa07be81fecfe Author: Cyril Jouve Modified Files -- .../browser/server_groups/serve

pgAdmin 4 commit: Fixed an issue where 'ALTER VIEW' statement is missin

Fixed an issue where 'ALTER VIEW' statement is missing when the user sets the default value of a column for View. Fixes #5664 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=604937cf6688eca6e05070eb798c54ccc754f467 Author: Rahul Shirsat Modi

pgAdmin 4 commit: Fixed cognitive complexity issues reported by SonarQu

Fixed cognitive complexity issues reported by SonarQube. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9d006d0ec5deb8970e56554b39c8241b6d3aede1 Author: Nikhil Mohite Modified Files -- .../servers/databases/schemas/types/__init__

pgAdmin 4 commit: Fixed an issue where copying and pasting a cell with

Fixed an issue where copying and pasting a cell with multiple line data will result in multiple rows. Fixes #5526 Fixed an old issue where quotes are not escaped when copying the cells. As per CSV standards, if the string is in double quotes and there are double quotes inside the string then they

[pgAdmin][RM5526] Copy and paste multiline cells

Hi Hackers, Attached is the patch to fix an issue where copying and pasting a cell with multiple line data will result in multiple rows. This is a regression of #3947. This patch also fixes an old issue where quotes are not escaped when copying the cells. As per CSV standards, if string is in doub

Patch for SonarQube code scan fixes.

Hi Team, I have fixed some code smell issues in the SonarQube scan, PFA patch. Details as follows: 1. Schema dif directory compare: - Refactor this function to reduce its Cognitive Complexity from 27 to the 15 allowed. 2. Import-export: - Refactor this function to reduce its Cognitive

pgAgent commit: Fixed an issue - when two jobs starts at the same time,

Fixed an issue - when two jobs starts at the same time, and sometime - it ends up creating the same name as random string used as temporary directory, and because - they were fetched at the same time, the implemnetation does not find that directory exists. In order to solve the issue - we will be