[pgAdmin][Patch] RM3767 - pgAdmin4 loses the file format

Hi, Please find an attached patch which enables pgAdmin to retain original file format while saving the same file in SQL-Editor. However, if a new file is created with the 'Save as' option, a new fill will be created with utf-8 encoding. After editing the file having encoding 'UTF-8 with BOM' from

Re: WIP: SQL Formatter

Hi, On Thu, Jul 30, 2020 at 1:54 PM Dave Page wrote: > > > On Thu, Jul 30, 2020 at 6:29 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Dave, >> >> On Wed, Jul 29, 2020 at 9:34 PM Dave Page wrote: >> >>> The attached WIP patch adds a menu option to the Query Tool to fo

Re: [pgAdmin][SonarQube] Function returns same value

Thanks, patch applied. On Thu, Jul 30, 2020 at 1:09 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to: > - Refactor functions to not always return the same value > - Rename "cls" to "self" or add the missing "self" parameter. > - Remove use

pgAdmin 4 commit: Fixed an issue when comparing the table with a trigge

Fixed an issue when comparing the table with a trigger throwing error in schema diff. Fixes #5710 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=dd7eb54e904734cd5bb681c038f2c79ff7d3bf79 Modified Files -- docs/en_US/release_notes_

pgAdmin 4 commit: Fixed following SonarQube issues:

Fixed following SonarQube issues: - Refactor functions to not always return the same value. - Rename "cls" to "self" or add the missing "self" parameter. - Remove useless assignment to variables. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitd

Re: WIP: SQL Formatter

On Thu, Jul 30, 2020 at 6:29 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Dave, > > On Wed, Jul 29, 2020 at 9:34 PM Dave Page wrote: > >> The attached WIP patch adds a menu option to the Query Tool to format the >> SQL in the editor. It does so per options that can be set

[pgAdmin][SonarQube] Function returns same value

Hi Hackers, Attached is the patch to: - Refactor functions to not always return the same value - Rename "cls" to "self" or add the missing "self" parameter. - Remove useless assignment to variables And a minor UI foreign key dialog add columns. Please review. -- Thanks, Aditya Toshniwal pgAdmin