Re: Runtime refactoring

Hi Dave/Hackers, Attached is the patch to fix newly introduce SoanrQube code smells. Please review it. On Tue, Jul 28, 2020 at 4:22 PM Akshay Joshi wrote: > Thanks, patch applied with some fixes. I'll work on the SonarQube code > smell and commit them later. > > On Mon, Jul 27, 2020 at 5:55 PM

Re: Runtime refactoring

Thanks, patch applied with some fixes. I'll work on the SonarQube code smell and commit them later. On Mon, Jul 27, 2020 at 5:55 PM Dave Page wrote: > Hi Akshay, > > Updated patch attached. > > Thanks. > > On Mon, Jul 27, 2020 at 12:08 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: >

Re: [pgAdmin][SonarQube] Rule - variable shadows a builtin

Thanks, patch applied. On Tue, Jul 28, 2020 at 10:51 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to rename all the variables which shadows any python > builtin. > Please review. > > -- > Thanks, > Aditya Toshniwal > pgAdmin hacker | Sr.

pgAdmin 4 commit: Fixed code smell 'variable shadows a builtin' reporte

Fixed code smell 'variable shadows a builtin' reported by SonarQube. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a0893fe43bb86dd8ab4a3b0730ec2c342a5a2810 Author: Aditya Toshniwal Modified Files -- pkg/mac/dmg-license.py

pgAdmin 4 commit: Make the runtime configuration dialog non-modal. Fixe

Make the runtime configuration dialog non-modal. Fixes #5490 Major refactoring of the runtime code, Specifically:   - Move the bulk of the core code from main() into a new Runtime class.   - Break up the mass of code that was main() into a number of relatively simple functions.   - Make the Config