Re: [pgAdmin][RM3904] Replace charting library Flotr2 with ChartJS using React

2020-07-24 Thread Dave Page
Hi Some further thoughts/comments: - There should be a comment block in every source file, containing the copyright info etc. - Looks like the "new-" in "new-dashboard-graphs" is probably a development artefact and should be removed? - We should probably use .jsx as the extension for React JS fil

Re: [pgAdmin][RM5646] User can not see RLS policies in the search object

2020-07-24 Thread Akshay Joshi
Thanks, patch applied. On Wed, Jul 22, 2020 at 11:01 AM Rahul Shirsat < rahul.shir...@enterprisedb.com> wrote: > Hi Hackers, > > Just for the information, the additional issue was the *incorrect node > path set in RLS policy*, and not the search objects itself. > > On Tue, Jul 21, 2020 at 9:23 PM

Re: [pgAdmin][Code Coverage] RM5324 - Improve API test cases for Foreign Servers and User Mappings

2020-07-24 Thread Akshay Joshi
Thanks, patch applied. On Thu, Jul 23, 2020 at 10:59 AM Satish V wrote: > Hi Hackers, > Kindly find the revised patch in the attachments. Please ignore the > previous patch. > > Thanks, > Sathish V > >> -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Sr. Software Architect* *EDB Postgre

Re: [pgAdmin][Patch] RM4810 - Cannot save new row if table is empty

2020-07-24 Thread Akshay Joshi
Thanks, patch applied. On Wed, Jul 22, 2020 at 1:36 PM Yogesh Mahajan < yogesh.maha...@enterprisedb.com> wrote: > Hello, > > Please find a patch which enables 'Save button' in SQL editor on > defocusing grid cell in case of a single column table with data type > number/integer etc. > > > Thanks,

pgAdmin 4 commit: Fixed an issue where the user is not able to save the

2020-07-24 Thread Akshay Joshi
Fixed an issue where the user is not able to save the new row if the table is empty. Fixes #4810 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=043025d1eb57b586da5eaf32f49655c180b95716 Author: Yogesh Mahajan Modified Files -- do

pgAdmin 4 commit: Ensure that RLS Policy node should be searchable usin

2020-07-24 Thread Akshay Joshi
Ensure that RLS Policy node should be searchable using search object. Fixes #5646 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=937877e841d20948c6a78cc06b81be984060fd34 Author: Rahul Shirsat Modified Files -- docs/en_US/release

pgAdmin 4 commit: Fixed 'cannot unpack non-iterable Response object' is

2020-07-24 Thread Akshay Joshi
Fixed 'cannot unpack non-iterable Response object' issue. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7a22cff28cc59c58f2af05d5443bb78085265d5a Modified Files -- .../server_groups/servers/databases/schemas/views/__init__.py | 11

pgAdmin 4 commit: Improve code coverage and API test cases for Foreign

2020-07-24 Thread Akshay Joshi
Improve code coverage and API test cases for Foreign Servers and User Mappings. Fixes #5324 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4cf8c2f3a9e2663a486e8308e91501999fd8 Author: Satish V Modified Files -- docs/en_US/re