[pgAdmin][SonarQube] Complete the implementation of empty methods

2020-07-22 Thread Aditya Toshniwal
Hi Hackers, Attached is the patch to close all the 32 SonarQube issues under the rule - "Add a nested comment explaining why this method is empty, or complete the implementation." Please review. -- Thanks, Aditya Toshniwal pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com*

[pgAdmin4][Patch] - SonarQube Issues - 11 (Unused local variables should be removed)

2020-07-22 Thread Yogesh Mahajan
Hello, Please find an attached patch fixing 17 sonarqube issues related to below rule - - Unused local variables should be removed. Thanks, Yogesh Mahajan QA - Team EnterpriseDB Corporation Phone: +91-9741705709 SonarQubeFix11_v1.patch Description: Binary data

pgAdmin 4 commit: Fix typo.

2020-07-22 Thread Dave Page
Fix typo. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=310450cfa7d5e605108f6343b7821ac384d97d9d Modified Files -- tools/update_selenoid_browsers.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

[pgAdmin][Patch] RM4810 - Cannot save new row if table is empty

2020-07-22 Thread Yogesh Mahajan
Hello, Please find a patch which enables 'Save button' in SQL editor on defocusing grid cell in case of a single column table with data type number/integer etc. Thanks, Yogesh Mahajan QA - Team EnterpriseDB Corporation Phone: +91-9741705709 RM4810_v1.patch Description: Binary data