pgAdmin 4 commit: Fix typo.

2020-07-17 Thread Dave Page
Fix typo. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9174db2024d7c0325c7edcb564df6dafb536bdc1 Modified Files -- pkg/mac/build-functions.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: Translators: Release next week

2020-07-17 Thread fred . escallier
hello french translation for upcoming release Fred - Mail original - De: "Akshay Joshi" À: "pgadmin-hackers" Envoyé: Vendredi 17 Juillet 2020 14:36:10 Objet: Translators: Release next week Hi Translators, We will have a release next week, so updates to translations before

pgAdmin 4 commit: Fix PEP-8 issue.

2020-07-17 Thread Dave Page
Fix PEP-8 issue. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=69e2ec806bd9c366ef19e889cddcfa88dfe88645 Modified Files -- tools/dependency_inventory.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

pgAdmin 4 commit: Include LICENSE and DEPENDENCIES [inventory] files in

2020-07-17 Thread Dave Page
Include LICENSE and DEPENDENCIES [inventory] files in official packages. Fixes #5577 Whilst passing, rename libraries.txt to DEPENDENCIES and update the list of static packages. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=04ce8b2c7129bce

Translators: Release next week

2020-07-17 Thread Akshay Joshi
Hi Translators, We will have a release next week, so updates to translations before release would be helpful. The template and catalogs have been updated in git. -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246

Re: RM 5235 - Support external config files

2020-07-17 Thread Akshay Joshi
Thanks, patch applied. Tested on OSX only. On Fri, Jul 17, 2020 at 3:56 PM Dave Page wrote: > > > On Fri, Jul 17, 2020 at 11:23 AM Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> >> On Fri, Jul 17, 2020 at 3:45 PM Dave Page wrote: >> >>> The

pgAdmin 4 commit: Update message catalogs.

2020-07-17 Thread Akshay Joshi
Update message catalogs. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2bfb7c20c8249d1096a3118540d4f26c94081051 Modified Files -- web/pgadmin/messages.pot | 2556 ++--- .../translations/cs/LC_MESS

pgAdmin 4 commit: Support configuration files that are external to the

2020-07-17 Thread Akshay Joshi
Support configuration files that are external to the application installation. Fixes #5235 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fb2178e5d3f732117b1de038b701d3b9d70aa295 Author: Dave Page Modified Files -- docs/en_US/co

Re: RM 5235 - Support external config files

2020-07-17 Thread Dave Page
On Fri, Jul 17, 2020 at 11:23 AM Ashesh Vashi wrote: > > On Fri, Jul 17, 2020 at 3:45 PM Dave Page wrote: > >> The attached patch adds support for config_system.py files stored outside >> of the application installation directory to allow sysadmins (and u

Re: RM 5235 - Support external config files

2020-07-17 Thread Ashesh Vashi
On Fri, Jul 17, 2020 at 3:45 PM Dave Page wrote: > The attached patch adds support for config_system.py files stored outside > of the application installation directory to allow sysadmins (and users > with appropriate permissions) to override configuration

RM 5235 - Support external config files

2020-07-17 Thread Dave Page
The attached patch adds support for config_system.py files stored outside of the application installation directory to allow sysadmins (and users with appropriate permissions) to override configuration options system wide and without invalidating signatures such as those found on the macOS app bund

Re: Patch for SonarQube code scan fixes

2020-07-17 Thread Akshay Joshi
Thanks, patch applied. On Thu, Jul 16, 2020 at 9:29 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Team, > > I have fixed some code smell issues in the SonarQube scan, PFA patch. > Details as follows: > 1. Servers file(utils): > >- Refactor this function to reduce its Cognitiv

Re: Runtime refactoring

2020-07-17 Thread Dave Page
BTW, this will fix https://redmine.postgresql.org/issues/5490 On Thu, Jul 16, 2020 at 10:41 AM Dave Page wrote: > Here's a pretty large patch that implements a major refactoring of the > runtime code. Specifically: > > - Move the bulk of the core code from main() into a new Runtime class. > - Br

Re: RM5554 - Fix runtime sizing

2020-07-17 Thread Akshay Joshi
Thanks, patch applied. On Thu, Jul 16, 2020 at 9:02 PM Dave Page wrote: > The attached patch replaces the current light/dark themes for the runtime > with the default Qt theme for light mode and the qdarkstyle theme for dark > mode. This fixes sizing issues reported in #5444. > > -- > Dave Page

Re: [pgAdmin][RM5675] csrf token error on safari iframe

2020-07-17 Thread Akshay Joshi
Thanks, patch applied. On Thu, Jul 16, 2020 at 5:48 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to fix CSRF errors when pgAdmin opened in an iframe > on safari browser. > Please review. > > -- > Regards, > Aditya Toshniwal > pgAdmin hack

Re: [pgAdmin 4 - Bug #5137] Focussing in and then out of numeric input enables the save button in dialog

2020-07-17 Thread Akshay Joshi
Thanks, patch applied. On Thu, Jul 16, 2020 at 5:08 PM Satish V wrote: > Hi Hackers, > > Please find the patch which fixes the bug related to save-button getting > enabled on hitting > tab key/focusing in and out of the numeric field(empty/non-empty). > Kindly review the patch. > > Thanks, > Sat

pgAdmin 4 commit: Replace the runtime themes with ones that don't have

2020-07-17 Thread Akshay Joshi
Replace the runtime themes with ones that don't have sizing issues. Fixes #5554 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=13d2f9131dc35b1afd49fa6d9f8e358d8a76afd0 Author: Dave Page Modified Files -- docs/en_US/release_notes_

pgAdmin 4 commit: Fixed cognitive complexity issues reported by SonarQu

2020-07-17 Thread Akshay Joshi
Fixed cognitive complexity issues reported by SonarQube. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4e2c4b049822fd7cb3b7c25a321bae6fe34a3195 Author: Nikhil Mohite Modified Files -- .../servers/resource_groups/__init__.py

pgAdmin 4 commit: Fixed save button enable issue when focusing in and o

2020-07-17 Thread Akshay Joshi
Fixed save button enable issue when focusing in and out of numeric input field. Fixes #5137 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=64cdd509b0d3c1d5a687d45c3fcdb3acff7848e5 Author: Satish V Modified Files -- docs/en_US/re

pgAdmin 4 commit: Fixed CSRF errors when pgAdmin opened in an iframe on

2020-07-17 Thread Akshay Joshi
Fixed CSRF errors when pgAdmin opened in an iframe on safari browser. Fixes #5675 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=bd15d2d0f7a5d2390dcd7763fa11215379c2c1fb Author: Aditya Toshniwal Modified Files -- docs/en_US/rele

pgAdmin 4 commit: Fix typo

2020-07-17 Thread Dave Page
Fix typo Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=64f5253bd30edfe3e3c30c3661a3ac5e5ee64a05 Modified Files -- docs/en_US/build_code_snippet.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)