pgAdmin 4 commit: Reverted fix for #5569 due to a couple of issues.

2020-07-11 Thread Akshay Joshi
Reverted fix for #5569 due to a couple of issues. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d3eaac8609df7f816421c86a800f95637d7b69ee Modified Files -- docs/en_US/release_notes_4_24.rst | 1 - .../servers/dat

Re: Use ISO date format in the runtime startup log

2020-07-11 Thread Akshay Joshi
Thanks, patch applied. On Fri, Jul 10, 2020 at 8:39 PM Dave Page wrote: > The attached minor patch adjusts the date format used in the runtime > startup log to ISO8601 (albeit without the T separator and timezone) to > avoid confusion for our US friends. > > Please review/commit. > > Thanks. > >

Re: Refactor config loading/saving for the runtime config dialogue

2020-07-11 Thread Akshay Joshi
Thanks, patch applied. On Fri, Jul 10, 2020 at 8:23 PM Dave Page wrote: > The attached patch refactors the config loading/saving in the > configuration dialogue to avoid code duplication and keep it confined to > the dialogue itself. > > Please review/commit. > > Thanks. > > -- > Dave Page > Blo

Re: Refactor server request code in the runtime

2020-07-11 Thread Akshay Joshi
Thanks, patch applied. On Fri, Jul 10, 2020 at 9:17 PM Dave Page wrote: > The attached patch removes some duplicated code in the runtime and > improves some of the debug logging, all around making requests to the > Python APIs. > > Please review/commit. > > Thanks. > > -- > Dave Page > Blog: htt

pgAdmin 4 commit: Refactor server request code by removing some duplica

2020-07-11 Thread Akshay Joshi
Refactor server request code by removing some duplicated code in the runtime and improves some of the debug logs. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e6edf400486544951e4f177d0cbe277ed61ff129 Author: Dave Page Modified Files -

pgAdmin 4 commit: Fixed reverse engineered SQL for partitions when stor

2020-07-11 Thread Akshay Joshi
Fixed reverse engineered SQL for partitions when storage parameters are specified. Fixes #5569 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=29175d7ec4259514486056aa1bb89a9513598912 Author: Rahul Shirsat Modified Files -- docs/

pgAdmin 4 commit: Use ISO8601 date format in the runtime startup log.

2020-07-11 Thread Akshay Joshi
Use ISO8601 date format in the runtime startup log. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=dd38fed6e08399413dfc087cd129466f1a10b51e Author: Dave Page Modified Files -- runtime/Logger.cpp | 3 ++- 1 file changed, 2 insertio

pgAdmin 4 commit: Refactor config loading/saving for the runtime config

2020-07-11 Thread Akshay Joshi
Refactor config loading/saving for the runtime config dialog to avoid code duplication. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5ac656c63856efb8154d68e6f0c92185fd0903a2 Author: Dave Page Modified Files -- runtime/ConfigWi

pgAdmin 4 commit: Use QStandardPaths::AppLocalDataLocation in the runti

2020-07-11 Thread Akshay Joshi
Use QStandardPaths::AppLocalDataLocation in the runtime to determine where to store runtime logs. Fixes #5414 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6855ac1d5eb670b36cbf758908b7e1f15cfc84ba Author: Dave Page Modified Files -

Re: RM5414 - Runtime paths

2020-07-11 Thread Akshay Joshi
Thanks, patch applied. On Fri, Jul 10, 2020 at 7:37 PM Dave Page wrote: > The attached patch changes the runtime to > use QStandardPaths::AppLocalDataLocation as the directory for the startup > and server logs, instead of $HOME. This should conform to platform > standards (XDG, in the case of Li