Refactor server request code in the runtime

2020-07-10 Thread Dave Page
The attached patch removes some duplicated code in the runtime and improves some of the debug logging, all around making requests to the Python APIs. Please review/commit. Thanks. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EDB: http://www.enterprisedb.com Refactor_Serve

Use ISO date format in the runtime startup log

2020-07-10 Thread Dave Page
The attached minor patch adjusts the date format used in the runtime startup log to ISO8601 (albeit without the T separator and timezone) to avoid confusion for our US friends. Please review/commit. Thanks. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EDB: http://www.enterp

Refactor config loading/saving for the runtime config dialogue

2020-07-10 Thread Dave Page
The attached patch refactors the config loading/saving in the configuration dialogue to avoid code duplication and keep it confined to the dialogue itself. Please review/commit. Thanks. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EDB: http://www.enterprisedb.com Refactor

RM5414 - Runtime paths

2020-07-10 Thread Dave Page
The attached patch changes the runtime to use QStandardPaths::AppLocalDataLocation as the directory for the startup and server logs, instead of $HOME. This should conform to platform standards (XDG, in the case of Linux). The actual filenames are now displayed on the log viewer for convenience. Pl

Re: [pgAdmin][RM5569] [SQL] Bad display of tables storage parameters in the "SQL" tab (correction of bug #5398 not complete)

2020-07-10 Thread Rahul Shirsat
Hi Khushboo, I had already corrected the patch as soon as I saw your mail, but couldn't send you as I went out on an urgency. Now sending it. On Fri, Jul 10, 2020 at 10:25 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Rahul, > > I am getting errors while applying the patch, pl