pgAdmin 4 commit: Fixed code smell 'Functions, methods, and lambdas sho

2020-07-07 Thread Akshay Joshi
Fixed code smell 'Functions, methods, and lambdas should not have too many parameters' reported by SonarQube. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b4c25bdc0a3d27540a1a9716384fc979d996f432 Modified Files -- .../servers/d

pgAdmin 4 commit: Added support for permissive/restricted policy type w

2020-07-07 Thread Akshay Joshi
Added support for permissive/restricted policy type while creating RLS Policy. Fixes #5622 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=36a2c073bd88c8ad55900daf390d1ef76af98cca Author: Pradip Parkale Modified Files -- docs/en_

Re: [pgAdmin][RM5622]: Permissive or restricted policy on table from PG 10 and above

2020-07-07 Thread Akshay Joshi
Thanks, patch applied. Also fixed some SonarQube issues. On Tue, Jul 7, 2020 at 4:04 PM Pradip Parkale < pradip.park...@enterprisedb.com> wrote: > Hi Akshay, > > Please find the updated patch. > > On Tue, Jul 7, 2020 at 10:23 AM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Patch no

Re: Patch for SonarQube code scan fixes

2020-07-07 Thread Akshay Joshi
Thanks, patch applied. On Tue, Jul 7, 2020 at 10:27 AM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Akshay, > > I have resolved the PEP8 issues, PFA updated patch. > > > Regards, > Nikhil Mohite. > > On Tue, Jul 7, 2020 at 10:19 AM Akshay Joshi < > akshay.jo...@enterprisedb.com> wr

Re: Re- Patch for SonarQube issues

2020-07-07 Thread Akshay Joshi
Thanks, patch applied. On Tue, Jul 7, 2020 at 10:19 AM Satish V wrote: > Hi Hackers, > > I have fixed some issues related to variable shadowing. Please find the > patch in the attachments. > Files changed import_export.js and maintenance.js > > Thanks, > Sathish V > -- *Thanks & Regards* *Aks

Re: [pgAdmin4][Patch] - SonarQube Issues - 9 (Variables and functions should not be redeclared, Variables should not be shadowed)

2020-07-07 Thread Akshay Joshi
Thanks, patch applied. On Tue, Jul 7, 2020 at 12:02 PM Yogesh Mahajan < yogesh.maha...@enterprisedb.com> wrote: > Hi, > > Please find a patch which fixes issues related to rule- >a.Variables should not be shadowed. >b.Variables and functions should not be redeclared. > > > Thanks, > Yoges

pgAdmin 4 commit: Fixed following SoanrQube issues:

2020-07-07 Thread Akshay Joshi
Fixed following SoanrQube issues:   1) Variables should not be shadowed.   2) Variables and functions should not be redeclared. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=776bec0d824eb9187e1a3eff2c401d422002f642 Author: Yogesh Mahajan Mo

pgAdmin 4 commit: Fixed the SoanrQube code smell 'Variables should not

2020-07-07 Thread Akshay Joshi
Fixed the SoanrQube code smell 'Variables should not be shadowed'. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ab2dc6009735663afe3bfd0bd1748439dffd6958 Author: Satish V Modified Files -- .../tools/import_export/static/js/impor

pgAdmin 4 commit: Fixed cognitive complexity code smell reported by Son

2020-07-07 Thread Akshay Joshi
Fixed cognitive complexity code smell reported by SonarQube. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=aee6bac5efb78b3720988536a692bca2abbefe64 Author: Nikhil Mohite Modified Files -- .../databases/schemas/tables/indexes/__i