pgAdmin 4 commit: Show horizontal scrollbar when needed in the menubar

Show horizontal scrollbar when needed in the menubar in the lower resolution, when navbar button is visible. Added appropriate CSS in the .navbar-collapse class to show scrollbar in screen resolution (992px widith) Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4

Re: [pgAdmin][RM5516]: Added support of Row Security Policies

Hi Akshay, Please find the attached patch. I have added hints for 'Using' and 'With check'. On Mon, Jun 22, 2020 at 5:45 PM Akshay Joshi wrote: > Thanks, patch applied. > > On Mon, Jun 22, 2020 at 3:23 PM Pradip Parkale < > pradip.park...@enterprisedb.com> wrote: > >> Hi Akshay, >> >> Please fi

patch review "split string to table"

Hi Pavel, I and Taylor Vesely (Greenplum) reviewed the patch "split string to table". as part of the June patch review workshop. Thanks It looks like you removed some unrelated documentation:

 | @@ -16717,21 +16738,6 @@ strict $.track.segments[*].location

pgAdmin 4 commit: Fixed database connection issue, regression of SonarQ

Fixed database connection issue, regression of SonarQube fixes. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0850db2a9be252fbcc67c543baf537a34516bd1f Modified Files -- .../servers/databases/static/js/database.js | 1

Re: Patch for SonarQube code scan fixes

On Wed, Jul 1, 2020 at 5:28 PM Dave Page wrote: > > > On Wed, Jul 1, 2020 at 12:55 PM Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> >> On Wed, Jul 1, 2020 at 5:23 PM Nikhil Mohite < >> nikhil.moh...@enterprisedb.com> wrote: >> >>> Hi Team, >>> >>> I have fixed some code smell issues

Re: Patch for SonarQube code scan fixes

On Wed, Jul 1, 2020 at 12:55 PM Ashesh Vashi wrote: > > On Wed, Jul 1, 2020 at 5:23 PM Nikhil Mohite < > nikhil.moh...@enterprisedb.com> wrote: > >> Hi Team, >> >> I have fixed some code smell issues in the SonarQube scan, PFA patch. >> Details as follows: >> 1. Functions files: >> >>- Remove

Re: Patch for SonarQube code scan fixes

On Wed, Jul 1, 2020 at 5:23 PM Nikhil Mohite wrote: > Hi Team, > > I have fixed some code smell issues in the SonarQube scan, PFA patch. > Details as follows: > 1. Functions files: > >- Remove the unused local variable "args" > > 2. node.js file in browser/static: > >- "j" hides or potent

Patch for SonarQube code scan fixes

Hi Team, I have fixed some code smell issues in the SonarQube scan, PFA patch. Details as follows: 1. Functions files: - Remove the unused local variable "args" 2. node.js file in browser/static: - "j" hides or potentially hides a variable declared in an outer scope at line 1080. 3. F

pgAdmin 4 commit: Fix PEP8

Fix PEP8 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a881e4e3f86a529c1136932f5735d26aaf63b124 Modified Files -- .../servers/databases/schemas/tables/tests/test_table_add.py| 2 -- 1 file changed, 2 deletions(-)

pgAdmin 4 commit: Fixed API test cases failing due to updating the serv

Fixed API test cases failing due to updating the server manager instance. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=192a446131d4f6e28451c6f8b92607a195e888de Author: Nikhil Mohite Modified Files -- .../schemas/tables/tests/te

Re: [pgAdmin][RM4235]: Tab indent on a selection of lines is deleting content

Thanks, patch applied. On Wed, Jul 1, 2020 at 11:39 AM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Team, > > I have done fixes for RM-4235. > Details as follows: > 1. Resolved issue with tab indent when a user set "use spaces == true" in > preferences > Querytool > Editor > Use sp

Re: [pgAdmin4][Patch] - SonarQube Issues07 (Variables should not be shadowed)

Thanks, patch applied. On Wed, Jul 1, 2020 at 12:18 PM Yogesh Mahajan < yogesh.maha...@enterprisedb.com> wrote: > Hi, > > Please find a patch which fixes issues related to rule- 'Variables should > not be shadowed'. > > > Thanks, > Yogesh Mahajan > QA - Team > EnterpriseDB Corporation > > Phone:

Re: [pgAdmin][RM5601] : [Schema Diff] Add RLS policy support in schema diff

Thanks, patch applied. On Wed, Jul 1, 2020 at 11:04 AM Pradip Parkale < pradip.park...@enterprisedb.com> wrote: > Hi Akshay, > > Please find the attached patch for following fixes, > >- RM5631 - [RLS Policy] can't execute an empty query. >- In case of more than one policy, all the headers

pgAdmin 4 commit: Fixed tab indent issue on a selection of lines is del

Fixed tab indent issue on a selection of lines is deleting the content when 'use spaces == true' in the preferences. Fixes #4235 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c2e875d54b0449b9e5035a7e2cb1f1154ea0ee22 Author: Nikhil Mohite M

pgAdmin 4 commit: Fixed SonarQube code smell 'Variables should not be s

Fixed SonarQube code smell 'Variables should not be shadowed'. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6dd3ca31becac0eac677292c1fa3ce8fd6eac3a8 Author: Yogesh Mahajan Modified Files -- .../static/js/fts_configuration.js

pgAdmin 4 commit: 1) Added RLS Policy support in Schema Diff. Fixes #56

1) Added RLS Policy support in Schema Diff. Fixes #5601 2) Fixed 'cant execute empty query' issue when remove the value of 'USING' or 'WITH CHECK' option of RLS Policy. Fixes #5631 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=979f8061619d

Re: [SonarQube]: Rename function and variable name to match the regular expression

Thanks, patch applied. On Wed, Jul 1, 2020 at 1:10 PM Pradip Parkale < pradip.park...@enterprisedb.com> wrote: > Hi Hackers, > > Please find the attached patch for : > >1. Rename function and variable name to match the regular expression. > > > -- > Thanks & Regards, > Pradip Parkale > QMG, E

pgAdmin 4 commit: Fixed SonarQube code smell 'Rename function and varia

Fixed SonarQube code smell 'Rename function and variable name to match the regular expression'. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b30c5908663d83b4610d6fc46a85333bb2090b13 Author: Pradip Parkale Modified Files -- ...

[SonarQube]: Rename function and variable name to match the regular expression

Hi Hackers, Please find the attached patch for : 1. Rename function and variable name to match the regular expression. -- Thanks & Regards, Pradip Parkale QMG, EnterpriseDB Corporation rename_function_variable_name.patch Description: Binary data