Re: [pgAdmin][RM3851] Add proper indentation to the code when generating a stored procedure

Hi Akshay, I have made the relevant changes for existing and the new procedure, functions & triggers. Please find the patch. On Thu, Jun 25, 2020 at 12:21 PM Akshay Joshi wrote: > Hi Rahul > > I have tested your patch and the issue is not fixed. Create one Procedure, > Function, and Trigger Fu

pgAdmin 4 commit: Fixed an issue where the semicolon is misplaced in RL

Fixed an issue where the semicolon is misplaced in RLS Policy SQL. Fixed one regression issue introduced by renaming the method 'gc' to 'gc_timeout'. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b91f6f0f5c3c7b45223dedaca020f2fec76dafa6 Mod

Patch for Redmine Bug 5630

Hello Dave, This is regarding issue #5630 (Installation on 32-bit Windows not working) https://redmine.postgresql.org/issues/5630 There was one condition missing - For system running a 32-bit version of Windows there should not be any checkfor HKLM64 in RegQueryStringValue (This get reproduce p

Re: [pgAdmin][RM5601] : [Schema Diff] Add RLS policy support in schema diff

Hi Pradip Following are the review comments: - For function arguments please make sure the right sequence is *gid, sid, did, scid, ... *All the parameters are not compulsory but the parameters should be in the mentioned order for consistency. Change it to all the functions of RLS Pol

Re: Reg-RM 5326[Code Coverage] Improve API test cases for Domain and Domain Constraints

Thanks, patch applied. On Thu, Jun 25, 2020 at 7:58 PM Satish V wrote: > Hi Hackers, > > Please find the attached patch which improves the code coverage for > domains and domain constraints. > coverage percentage for *domains *- 75 percentage from 56 > coverage percentage for *domains constraint

Re: Patch for SonarQube code scan.

Thanks, patch applied. On Fri, Jun 26, 2020 at 2:35 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Team, > > resolved PEP8 warnings PFA latest patch. > > On Fri, Jun 26, 2020 at 2:00 PM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> Please fix PEP8 issue

pgAdmin 4 commit: Improve code coverage and API test cases for Domain a

Improve code coverage and API test cases for Domain and Domain Constraints. Fixes #5326 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8e28e0a32b4c3a8bb7f3e149977afb34a0aebb24 Author: Satish V Modified Files -- docs/en_US/releas

pgAdmin 4 commit: Fixed following SonarQube issues:

Fixed following SonarQube issues: 1) Refactor function to reduce its Cognitive Complexity. 2) Rename variable to match the regular expression ^[_a-z][a-z0-9_]*$. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=115657a465405be94c8c25dab3f88c9a

Re: Patch for SonarQube code scan.

Hi Team, resolved PEP8 warnings PFA latest patch. On Fri, Jun 26, 2020 at 2:00 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please fix PEP8 issues. Other than PEP8, everything looks good to me. > > Thanks, > Khushboo > > On Fri, Jun 26, 2020 at 10:08 AM Khushboo Vashi <

Re: Patch for SonarQube code scan.

Hi, Please fix PEP8 issues. Other than PEP8, everything looks good to me. Thanks, Khushboo On Fri, Jun 26, 2020 at 10:08 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Fri, Jun 26, 2020 at 10:02 AM Nikhil Mohite < > nikhil.moh...@enterprisedb.com> wrote: > >> Hi Khushboo,

Re: [SonarQube]: Rename class name

Thanks, patch applied. On Fri, Jun 26, 2020 at 12:32 PM Pradip Parkale < pradip.park...@enterprisedb.com> wrote: > Hi Hackers, > > Please find the attached patch for : > >1. Rename class name to match the regular expression. > > -- > Thanks & Regards, > Pradip Parkale > QMG, EnterpriseDB Corp

Re: Re- [SonarQube][patch]- tagged suspicious, convention

Thanks, patch applied. On Fri, Jun 26, 2020 at 11:37 AM Satish V wrote: > Hi Hackers, > > Please find the patch which resolves the SonarQube scan issue stated below. > 1.Method/Field names should comply with a naming convention. > 2.Conditionals should start on new lines > -- *Thanks & Regard

Re: [pgAdmin4][Patch] - SonarQube Issues - 6 (A conditionally executed single line should be denoted by indentation, A "while" loop should be used instead of a "for" loop)

Thanks, patch applied. On Thu, Jun 25, 2020 at 5:05 PM Yogesh Mahajan < yogesh.maha...@enterprisedb.com> wrote: > Hi, > > Please find patch fixing the issues related to below rules - > 1.A conditionally executed single line should be denoted by indentation, > 2.A "while" loop should be used inste

Re: [pgAdmin4][Patch] SonarQube Fixes

Thanks, patch applied. On Thu, Jun 25, 2020 at 5:55 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to fix the code smells having rule (PYTHON) > NESTED BLOCKS OF CODE SHOULD NOT BE LEFT EMPTY. > > Thanks, > Khushboo > -- *Thanks & Regards*

Re: [pgAdmin4][Patch] - SonarQube Issues - 5 (Rule Boolean checks should not be inverted, Comma operator should not be used)

Thanks, patch applied. On Thu, Jun 25, 2020 at 3:53 PM Yogesh Mahajan < yogesh.maha...@enterprisedb.com> wrote: > Hi, > > Please find an updated patch. > > > Thanks, > Yogesh Mahajan > QA - Team > EnterpriseDB Corporation > > Phone: +91-9741705709 > > > On Thu, Jun 25, 2020 at 12:26 PM Akshay Jos

pgAdmin 4 commit: Fixed following SonarQube issues:

Fixed following SonarQube issues: 1. Boolean checks should not be inverted. 2. The comma operator should not be used. 3. Arguments to built-in functions should match documented types. 4. Redundant pairs of parentheses should be removed. 5. A conditionally executed single line should be denoted by i

pgAdmin 4 commit: Ensure that the OWNER should be quoted for foreign ta

Ensure that the OWNER should be quoted for foreign tables, procedures, and trigger functions. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6a632793962d03a61f409cd5998e2560f54c3697 Author: Diego Augusto Molina Modified Files --

pgAdmin 4 commit: Fixed code smells having rule 'Rename class name to m

Fixed code smells having rule 'Rename class name to match the regular expression'. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5206dafb3554d836b4cc477fe3a345174554d354 Author: Pradip Parkale Modified Files -- web/pgadmin/util

pgAdmin 4 commit: Fixed code smells having rule 'Nested blocks of code

Fixed code smells having rule 'Nested blocks of code should not be left empty'. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c7a16a4bd58d2dfb0257e5433031a2138c588e39 Author: Khushboo Vashi Modified Files -- tools/update_selenoi

pgAdmin 4 commit: Fixed following SonarQube issues:

Fixed following SonarQube issues: 1. Method/Field names should comply with a naming convention. 2. Conditionals should start on new lines Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=830ac1cc9177c8b9ebed2304924cec1db22e45c3 Author: Satish

Support schema level restrictions and edit connection properties when already connected.

Hi Team, PFA patch for 5583 support schema level restrictions and edit connection properties when already connected. Details as follows: 1. Schema restrictions : 1. Added a new tab "Advanced" in the database properties, with the "Schema restrictions"

[SonarQube]: Rename class name

Hi Hackers, Please find the attached patch for : 1. Rename class name to match the regular expression. -- Thanks & Regards, Pradip Parkale QMG, EnterpriseDB Corporation rename_class.patch Description: Binary data