[pgAdmin4] Fix RLS node dialog help link

2020-06-22 Thread Murtuza Zabuawala
Hi, PFA minor patch to fix the issue where RLS node dialog help is not opening. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company fix_RLS_dialog_help.diff Description: Binary data

pgAdmin4 v4.23 candidate builds

2020-06-22 Thread Akshay Joshi
Hi All, pgAdmin4 v4.23 candidate builds and source can be found at https://developer.pgadmin.org/builds/2020-06-22-1/ Team, can you please verify it for release on Thursday. -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91

[pgAdmin] : Patch fixing Feature Test failures.

2020-06-22 Thread Yogesh Mahajan
Hi Hackers, Please find the patch which fixes parallel test execution failures. Handled slowness when multiple sessions are logged in concurrently. Thanks, Yogesh Mahajan QA - Team EnterpriseDB Corporation Phone: +91-9741705709 fix_selenium_grid_failures_v3.0.patch Description: Binary data

Re: [pgAdmin][RM5516]: Added support of Row Security Policies

2020-06-22 Thread Akshay Joshi
Thanks, patch applied. On Mon, Jun 22, 2020 at 3:23 PM Pradip Parkale < pradip.park...@enterprisedb.com> wrote: > Hi Akshay, > > Please find the updated patch. I have added a new RLS policy event 'ALL'. > > > On Mon, Jun 15, 2020 at 3:48 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: >

Re: [pgAdmin][Patch] RM 3591 - Query tool is not displaying the proper error

2020-06-22 Thread Akshay Joshi
Thanks, patch applied. On Mon, Jun 22, 2020 at 2:58 PM Yogesh Mahajan < yogesh.maha...@enterprisedb.com> wrote: > Hi Hackers, > > Please find the patch fixing error shown in the query tool while in > progress query execution on session termination from dashboard. > > Thanks, > Yogesh Mahajan > QA

pgAdmin 4 commit: Ensure that the query tool should display the proper

2020-06-22 Thread Akshay Joshi
Ensure that the query tool should display the proper error message while terminating the active session. Fixes #3591 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=caebdcfa912e6e40f5823406745fdefcfe8d3389 Author: Yogesh Mahajan Modified Fil

pgAdmin 4 commit: Documentation of Row Level Security Policies. Fixes #

2020-06-22 Thread Akshay Joshi
Documentation of Row Level Security Policies. Fixes #5581 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d2f4a62bf36ea129a69aeea0fb27ae15f5bddc69 Author: Yogesh Mahajan Modified Files -- docs/en_US/images/rls_policy_commands_tab.

pgAdmin 4 commit: Added policy event 'ALL' in events drop-down list.

2020-06-22 Thread Akshay Joshi
Added policy event 'ALL' in events drop-down list. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6012f49919f9d9084fb697de2a28182ed50d3444 Author: Pradip Parkale Modified Files -- .../tables/row_security_policies/static/js/row_se

pgAdmin 4 commit: Update version for release.

2020-06-22 Thread Akshay Joshi
Update version for release. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c2268c82ee99221008c8b8eb075cd6b59ed6a550 Modified Files -- runtime/Info.plist | 4 ++-- runtime/pgAdmin4.pro | 2 +- web/config.py| 4 ++-- 3 files

Re: Patch for Redmine Bug 5587

2020-06-22 Thread Dave Page
Thanks, applied with some spelling fixes :-p Akshay, please have one of the team test this thoroughly. On Mon, Jun 22, 2020 at 8:31 AM Paresh More wrote: > Hello Dave, > > This is regarding issue #5587 (Handle Windows x32/x64 installation using > Innotool) > https://redmine.postgresql.org/issu

pgAdmin 4 commit: Disallow installation of the 32 and 64 bit builds at

2020-06-22 Thread Dave Page
Disallow installation of the 32 and 64 bit builds at the same time on Windows. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9d25973a779890787c35e91e9e664ade8ac95220 Author: Paresh More Modified Files -- pkg/win32/installer.iss.

[pgAdmin4][Patch] - SonarQube Issues - 5 (Rule Boolean checks should not be inverted, Comma operator should not be used)

2020-06-22 Thread Yogesh Mahajan
Hi Hackers, Please find patch fixing sonarqube issues related to below rules - 1.Boolean checks should not be inverted, 2.Comma operator should not be used, 3.Arguments to built-in functions should match documented types, 4.Redundant pairs of parentheses should be removed, Thanks, Yogesh Mahajan

Re: [pgAdmin][RM5516]: Added support of Row Security Policies

2020-06-22 Thread Pradip Parkale
Hi Akshay, Please find the updated patch. I have added a new RLS policy event 'ALL'. On Mon, Jun 15, 2020 at 3:48 PM Akshay Joshi wrote: > Thanks, patch applied with the following modifications: > > >- js file name should be "row_security_policy.js" instead of >"row_security_policies.j

[pgAdmin][Patch] RM 3591 - Query tool is not displaying the proper error

2020-06-22 Thread Yogesh Mahajan
Hi Hackers, Please find the patch fixing error shown in the query tool while in progress query execution on session termination from dashboard. Thanks, Yogesh Mahajan QA - Team EnterpriseDB Corporation Phone: +91-9741705709 RM3591_v1.patch Description: Binary data

Re: [pgAdmin][RM5492] Search Object - Unable to locate inherited tables and Constraints filter not working

2020-06-22 Thread Akshay Joshi
Thanks, patch applied. On Thu, Jun 11, 2020 at 4:58 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to fix the following search objects dialog issues: > 1) Unable to locate inherited tables. Fixed. > 2) "Constraints" type filter not working.

Re: [pgAdmin][patch]SonarQube tagged clumsy

2020-06-22 Thread Akshay Joshi
Thanks, patch applied. On Mon, Jun 22, 2020 at 10:38 AM Satish V wrote: > Hi Hackers, > > Please find the patch in the attachment which solves the problem related > to reducing if else statement to single return expression. > Kindly review and share the changes required.. > > Thanks, > Sathish V

Re: [pgAdmin][patch] SonarQube tagged bad-practice

2020-06-22 Thread Akshay Joshi
Thanks, patch applied. On Mon, Jun 22, 2020 at 10:18 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to fix issues reported by SonarQube with tag > "bad-practice". > Please review. > > -- > Thanks and Regards, > Aditya Toshniwal > pgAdmin Ha

Re: Translators: Release next week

2020-06-22 Thread Akshay Joshi
Thanks, patch applied. On Sat, Jun 20, 2020 at 12:59 PM fn ln wrote: > Hello. > Here's an updated Japanese translation for upcoming version 4.23 release. > (messages.pot revision; 7ce7808093) > > 2020年6月19日(金) 21:32 Akshay Joshi : > >> Hi Translators, >> >> We will have a release next week, so u

Re: Translators: Release next week

2020-06-22 Thread Akshay Joshi
Thanks, patch applied. On Sun, Jun 21, 2020 at 9:15 PM Domenico Sgarbossa wrote: > Hi, here italians files > Bye! > > Il venerdì 19 giugno 2020, 14:33:00 CEST, Akshay Joshi < > akshay.jo...@enterprisedb.com> ha scritto: > > > Hi Translators, > > We will have a release next week, so updates to tr

pgAdmin 4 commit: Update Japanese translation.

2020-06-22 Thread Akshay Joshi
Update Japanese translation. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9e40995ab0ed88c518e7b8980ffa5235d5bcf69b Author: Identifier Anonymous Modified Files -- .../translations/ja/LC_MESSAGES/messages.mo| Bin 193944 -

pgAdmin 4 commit: 1) Fixes parallel test execution failures.

2020-06-22 Thread Akshay Joshi
1) Fixes parallel test execution failures. 2) Added capability to pass browser-name via command line for parallel execution. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=34fbe756e854bc202c53abfa12e7257851415e7c Author: Yogesh Mahajan Modi

pgAdmin 4 commit: Fixed issue related to reducing the if-else statement

2020-06-22 Thread Akshay Joshi
Fixed issue related to reducing the if-else statement to single return expression. Reported by SonarQube. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=daad16ea93c778cd28d5df6c2ce48c0374448304 Author: Satish V Modified Files --

Re: [pgAdmin] : Patch fixing Feature Test failures.

2020-06-22 Thread Akshay Joshi
Thanks, patch applied. On Mon, Jun 22, 2020 at 12:01 PM Yogesh Mahajan < yogesh.maha...@enterprisedb.com> wrote: > Hi Hackers, > > Please find the patch which fixes parallel test execution failures. > Also, added capability to pass browser-name via command line for parallel > execution. > > Thank

pgAdmin 4 commit: Fixed an issue where the search object is unable to l

2020-06-22 Thread Akshay Joshi
Fixed an issue where the search object is unable to locate inherited tables and constraint filters are not working. Fixes #5492 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d6b22f1f4c631d969910d0ee09755fae0943785e Author: Aditya Toshniwal

pgAdmin 4 commit: Update Italian translation.

2020-06-22 Thread Akshay Joshi
Update Italian translation. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ecdd95d15afb281afe3bba0a6f137e34cc7f8009 Author: Domenico Sgarbossa Modified Files -- .../translations/it/LC_MESSAGES/messages.mo| Bin 180395 ->

pgAdmin 4 commit: Fixed issues reported by SonarQube with tag 'bad-prac

2020-06-22 Thread Akshay Joshi
Fixed issues reported by SonarQube with tag 'bad-practice'. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6620f9263d4061ab01a19e71f9e22940db9bb826 Author: Aditya Toshniwal Modified Files -- .../databases/schemas/tables/indexes/_

Patch for Redmine Bug 5587

2020-06-22 Thread Paresh More
Hello Dave, This is regarding issue #5587 (Handle Windows x32/x64 installation using Innotool) https://redmine.postgresql.org/issues/5587 This patch will make sure the following thing - pgAdmin4 windows installer should restrict the user not to install 32bit and 64bit parallelly. - It