Re: Re- [RM-3669]If user drop any object and click on create script, count rows and Truncate table, proper error should displayed that object is in present

2020-06-01 Thread Khushboo Vashi
Hi Satish, On Mon, Jun 1, 2020 at 2:16 PM Satish V wrote: > Hi Hackers, > > Attached is the patch which alerts the users when they try to consume the > options in the context menu of the deleted node. > Can you please specify the context menu options which you handled, so it will be easy for me

pgAdmin 4 commit: Disabled the Stop process button after clicking it an

2020-06-01 Thread Akshay Joshi
Disabled the Stop process button after clicking it and added a message 'Terminating the process...' to notify the user. Fixes #3787 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c932213abd12a151e18277c1acb417866095fdd6 Author: Nagesh Dhope

pgAdmin 4 commit: Improve error messaging if the storage and log direct

2020-06-01 Thread Akshay Joshi
Improve error messaging if the storage and log directories cannot be created. Fixes #5576 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a0c19252df129da0b6c223dbc6d91c4f6a010ce5 Author: Dave Page Modified Files -- docs/en_US/rel

Re: RM5576: Improve error messaging if the storage and log directories cannot be created

2020-06-01 Thread Akshay Joshi
Thanks, patch applied. On Mon, Jun 1, 2020 at 9:20 PM Dave Page wrote: > Patch for $SUBJECT attached. Sample output: > > python web/pgAdmin4.py > ERROR : Failed to create the directory /var/lib/pgadmin: >[Errno 13] Permission denied: '/var/lib/pgadmin' > HINT : Create the director

RM5576: Improve error messaging if the storage and log directories cannot be created

2020-06-01 Thread Dave Page
Patch for $SUBJECT attached. Sample output: python web/pgAdmin4.py ERROR : Failed to create the directory /var/lib/pgadmin: [Errno 13] Permission denied: '/var/lib/pgadmin' HINT : Create the directory /var/lib/pgadmin, ensure it is writeable by 'dpage', and try again, or, cr

pgAdmin 4 now available on PyPi

2020-06-01 Thread Dave Page
Hi Starting with v4.22 pgAdmin is available on PyPi ( https://pypi.org/project/pgadmin4/). To install it, create a virtual environment as required, and then use pip to install. Note that pgAdmin will run in server mode, using system-wide paths so you may need to create them first: $ sudo mkdir /v

pgAdmin 4 commit: Don't use virtualenv to create the venv on Windows.

2020-06-01 Thread Dave Page
Don't use virtualenv to create the venv on Windows. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=67c978b7a45c5c751df336f4d48fd7723e808a30 Modified Files -- Make.bat | 2 +- pkg/win32/README.txt | 6 ++ 2 files chan

pgAdmin 4 commit: Ignore venv directories in the tree.

2020-06-01 Thread Dave Page
Ignore venv directories in the tree. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f4750f00968aa6e54c836e29fc1f6c544c72fb1f Modified Files -- .gitignore | 1 + 1 file changed, 1 insertion(+)

Re: Windows build system cleanup

2020-06-01 Thread Dave Page
Thanks - committed. I've updated the Jenkins jobs that run Make.bat with the new variable names. I'll keep an eye out for any failures and fix anything that pops up. Once it's stable I'll remove all the old variables. On Mon, Jun 1, 2020 at 8:53 AM Akshay Joshi wrote: > Hi Dave > > Patch looks g

pgAdmin 4 commit: Cleanup Windows build scripts and ensure Windows x64

2020-06-01 Thread Dave Page
Cleanup Windows build scripts and ensure Windows x64 builds will work. Fixes #5574 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=676fec8694654141dad499c0de127c9df1689d85 Modified Files -- Make.bat | 302

Re- [RM-3669]If user drop any object and click on create script, count rows and Truncate table, proper error should displayed that object is in present

2020-06-01 Thread Satish V
Hi Hackers, Attached is the patch which alerts the users when they try to consume the options in the context menu of the deleted node. -fixed the opening of an empty query tool window for non existing nodes.(create/delete/update..) - handles the error like "list index out of range" with a reasonab

pgAdmin 4 commit: Conflict with postgresql-libs 9.2 and below as there

2020-06-01 Thread Dave Page
Conflict with postgresql-libs 9.2 and below as there won't be a suitable libpq. Per discussion with Devrim. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=60a0b66414d1baa0ee5de6d37a2b3c4384ba13e1 Modified Files -- pkg/redhat/buil

Re: Windows build system cleanup

2020-06-01 Thread Akshay Joshi
Hi Dave Patch looks good to me, did eyeball review. On Fri, May 29, 2020 at 1:43 PM Dave Page wrote: > Stupid line endings confusing git :-(. Here's another attempt. > > On Fri, May 29, 2020 at 7:30 AM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Dave >> >> Unable to apply the