Re: [pgAdmin4][Patch] - RM #5465 - [Microsoft Edge] Mensagem de Erro Indevida

2020-05-28 Thread Yogesh Mahajan
Hi Hackers, Comparing with 18 also will create the same issue as there are multiple Edge browser versions mapped to single EdgeHTML engine versions. Please find modified patch which will show exact detected browser version till Edge Version 40. For Edge version < 40, error message will show vers

Re: Windows build system cleanup

2020-05-28 Thread Akshay Joshi
Hi Dave Unable to apply the patch. Can you please rebase and send it again. On Thu, May 28, 2020 at 9:04 PM Dave Page wrote: > Here's a patch to cleanup the windows build system and make sure 64 bit > builds work with modern tools. It also updates the README with a new > from-scratch setup proc

Re: [pgAdmin][RM5521] pgAdmin dump servers issue in desktop mode

2020-05-28 Thread Akshay Joshi
Hi Aditya When I provide the wrong path of the SQLite DB file then it should not ask me an email address and password. python setup.py --sqlite-path "/Users/akshayjoshi/Downloads/pgadmin4-de.db" --dump-servers output.json Dumping servers with: User: pgadm...@pgadmin.org SQLite pgAdmin co

Re: [pgAdmin4][Patch] - RM #5465 - [Microsoft Edge] Mensagem de Erro Indevida

2020-05-28 Thread Aditya Toshniwal
Hi Yogesh, Your patch will fail if the edge version is older than 39. I would suggest comparing version > 18 directly. On Fri, May 29, 2020 at 10:57 AM Yogesh Mahajan < yogesh.maha...@enterprisedb.com> wrote: > Hi Hackers, > > Please find the attached patch which shows the actual Edge browser ve

[pgAdmin4][Patch] - RM #5465 - [Microsoft Edge] Mensagem de Erro Indevida

2020-05-28 Thread Yogesh Mahajan
Hi Hackers, Please find the attached patch which shows the actual Edge browser version when pgAdmin is launched Edge Version <43. Thanks, Yogesh Mahajan QA - Team EnterpriseDB Corporation Phone: +91-9741705709 RM5465_v1.patch Description: Binary data

Windows build system cleanup

2020-05-28 Thread Dave Page
Here's a patch to cleanup the windows build system and make sure 64 bit builds work with modern tools. It also updates the README with a new from-scratch setup process that makes it much easier to setup a Windows build/dev machine. Please review, but don't apply as I'll need to do that in conjunct

pgAdmin 4 commit: Require postgresql >= 9.5, and don't bother with Reco

2020-05-28 Thread Dave Page
Require postgresql >= 9.5, and don't bother with Recommends. Per discussion with Devrim. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ccb39bea1ad19ed7da0e3b5278e8fd557770962f Modified Files -- pkg/redhat/build.sh | 9 +++--

pgAdmin 4 commit: Don't try to import the signing key. YUM/RPM will do

2020-05-28 Thread Dave Page
Don't try to import the signing key. YUM/RPM will do that for us, per Devrim. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=bda62cb1f1f6c57fc3b651f986439e61dc1f9832 Modified Files -- pkg/redhat/repo-rpm.sh | 3 --- 1 file changed,

Re: [pgAdmin][RM5521] pgAdmin dump servers issue in desktop mode

2020-05-28 Thread Aditya Toshniwal
Hi Hackers, Attached is the updated patch. Please review. On Thu, May 28, 2020 at 5:38 PM Akshay Joshi wrote: > Hi Aditya > > When I run setup.py and specify the *--sqlite-path* parameter like below: > python setup.py --sqlite-path > "/Users/akshayjoshi/Downloads/pgadmin4-dev-env.db" --dump-ser

Re: [pgAdmin4][Patch] - RM 5416 Cannot close/remove a tab/panel without saving

2020-05-28 Thread Akshay Joshi
Thanks, patch applied. On Wed, May 27, 2020 at 12:08 PM Yogesh Mahajan < yogesh.maha...@enterprisedb.com> wrote: > Hi Hackers, > > Please find attached patch fixing 'Cannot close/remove a tab/panel without > saving' issue. > > Thanks, > Yogesh Mahajan > QA - Team > EnterpriseDB Corporation > > Ph

Re: [pgAdmin4][Patch] - RM 5539 - /usr/share/pgadmin4/web/pgadmin/utils/preferences.py contains 7 references to current_app.logger.exeception(e) and 1 to current_app.logger.exception(e)

2020-05-28 Thread Akshay Joshi
Thanks, patch applied. On Thu, May 28, 2020 at 5:16 PM Yogesh Mahajan < yogesh.maha...@enterprisedb.com> wrote: > Hi Hackers, > > Please find attached patch fixing exception errors. > > Thanks, > Yogesh Mahajan > QA - Team > EnterpriseDB Corporation > > Phone: +91-9741705709 > -- *Thanks & Reg

pgAdmin 4 commit: Ensure that the query tool panel gets closed when cli

2020-05-28 Thread Akshay Joshi
Ensure that the query tool panel gets closed when clicking on the 'Don't Save' button. Fixes #5416 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e10f1274dc01780b09663575fd5c20872391d12e Author: Yogesh Mahajan Modified Files --

pgAdmin 4 commit: Fixed typo in exception keyword. Fixes #5539

2020-05-28 Thread Akshay Joshi
Fixed typo in exception keyword. Fixes #5539 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=09b76b306c64e7ec81236974454087bd1a387b02 Author: Yogesh Mahajan Modified Files -- docs/en_US/release_notes_4_23.rst | 3 ++- web/pgadmin/

Re: [pgAdmin][RM5521] pgAdmin dump servers issue in desktop mode

2020-05-28 Thread Akshay Joshi
Hi Aditya When I run setup.py and specify the *--sqlite-path* parameter like below: python setup.py --sqlite-path "/Users/akshayjoshi/Downloads/pgadmin4-dev-env.db" --dump-servers output.json I got the following error: PermissionError: [Errno 13] Permission denied: '/var/lib/pgadmin' Please fix

[pgAdmin4][Patch] - RM 5539 - /usr/share/pgadmin4/web/pgadmin/utils/preferences.py contains 7 references to current_app.logger.exeception(e) and 1 to current_app.logger.exception(e)

2020-05-28 Thread Yogesh Mahajan
Hi Hackers, Please find attached patch fixing exception errors. Thanks, Yogesh Mahajan QA - Team EnterpriseDB Corporation Phone: +91-9741705709 RM5539_v1.patch Description: Binary data

pgAdmin 4 commit: Tag REL-4_22 has been created.

2020-05-28 Thread Akshay Joshi
Tag REL-4_22 has been created. View: https://git.postgresql.org/gitweb?p=pgadmin4.git;a=tag;h=refs/tags/REL-4_22 Log Message --- Tag v4.22

pgAdmin 4 v4.22 released

2020-05-28 Thread Akshay Joshi
The pgAdmin Development Team is pleased to announce pgAdmin 4 version 4.22. This release of pgAdmin 4 includes over 36 bug fixes and new features. For more details please see the release notes at: https://www.pgadmin.org/docs/pgadmin4/dev/release_notes_4_22.html. pgAdmin is the leading Open S

Re: pgAdmin4 v4.22 candidate builds

2020-05-28 Thread Fahar Abbas
@Akshay Joshi One Round of testing has been completed. Can you please release pgadmin4 4.22? On Mon, May 25, 2020 at 6:53 PM Akshay Joshi wrote: > > > On Mon, May 25, 2020 at 6:54 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi All, >> >> pgAdmin4 v4.21 candidate builds and

[pgAdmin][RM5521] pgAdmin dump servers issue in desktop mode

2020-05-28 Thread Aditya Toshniwal
Hi Hackers, Attached is the patch to: 1) Fix an issue when dumping servers from a desktop pgAdmin app by providing an option --sqlite-path. This will allow the user to dump a specific config db file. 2) While there is an option for --sqlite-path now, the other paths for session, storage, etc. were