Re: [pgAdmin][RM5333] : [Code Coverage] Improve API test cases for Indexes

2020-05-17 Thread Yogesh Mahajan
Hi Akshay, Please find modified patch fixing above issue. Command to run the test cases - - python runtests.py --pkg browser.server_groups.servers.databases.schemas.tables.indexes.tests Thanks, Yogesh Mahajan QA - Team EnterpriseDB Corporation Phone: +91-9741705709 On Mon, May 18, 202

[pgAdmin4][Patch] - RM 5487 - LDAP Configuration fix

2020-05-17 Thread Khushboo Vashi
Hi, Please find the attached patch to fix RM #5487 - [LDAP configuration settings] pgadmin4.21 LDAP authentication problems. Fix: If LDAP_SEARCH_BASE_DN is not set then, the value for LDAP_BASE_DN will be considered. The document updates are done by Abhilasha. Thanks, Khushboo RM_5487.patch D

Re: [pgAdmin4][Patch] - RM 5452 improvement

2020-05-17 Thread Akshay Joshi
Thanks, patch applied. On Fri, May 15, 2020 at 3:17 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > In order to find who query what, we have added pgadmin user identity ( > current_user.email ) in the log file. (RM 5452). In this > patch, current_user.email is changed to cur

pgAdmin 4 commit: Changed the user identity from email to username in t

2020-05-17 Thread Akshay Joshi
Changed the user identity from email to username in the log file. refs #5452 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0f56c258931565579fd3898abf1b7be1ca550ead Author: Khushboo Vashi Modified Files -- web/pgadmin/utils/driv

Re: [pgAdmin][RM5493] Search Object: UI improvement suggestions

2020-05-17 Thread Akshay Joshi
Thanks, patch applied. On Fri, May 15, 2020 at 5:14 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to make some UI improvements in search objects > dialog. > Docs updated. > > Please review. > > -- > Thanks and Regards, > Aditya Toshniwal >

pgAdmin 4 commit: Search object UI improvements. Fixes #5493

2020-05-17 Thread Akshay Joshi
Search object UI improvements. Fixes #5493 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d58c33dec04646121d3972ca464505d5ea0a07f9 Author: Aditya Toshniwal Modified Files -- docs/en_US/images/search_objects.png | Bi

Re: [pgAdmin][RM5333] : [Code Coverage] Improve API test cases for Indexes

2020-05-17 Thread Akshay Joshi
Hi Yogesh "Create index: With valid data while the server is down-2" test cases are failing for all the database servers (PG/EPAS). Please fix and resend the patch. On Fri, May 15, 2020 at 1:04 PM Yogesh Mahajan < yogesh.maha...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch t