Re: [pgAdmin 4 - Housekeeping #5255] Implement Selenium Grid using multi-threading & solenoid using current test framework

2020-05-08 Thread Akshay Joshi
Hi Yogesh Unable to apply the patch on the latest code. Please rebase and send it again. On Fri, May 8, 2020 at 2:05 PM Yogesh Mahajan < yogesh.maha...@enterprisedb.com> wrote: > Attaching patch > > Thanks, > Yogesh Mahajan > QA - Team > EnterpriseDB Corporation > > Phone: +91-9741705709 > > > O

pgAdmin 4 commit: Fixed generated SQL issue for auto vacuum options. Fi

2020-05-08 Thread Akshay Joshi
Fixed generated SQL issue for auto vacuum options. Fixes #5398 Fixed some more issues: 1) pgAdmin allows only true or false values for autovacuum_enabled, and there is no way to reset it individually without disabling a custom auto vacuum. To fix this, the control is changed from the sw

pgAdmin 4 commit: Fixed the errors, and warnings reported by pylama.

2020-05-08 Thread Ashesh Vashi
Fixed the errors, and warnings reported by pylama. TODO:: - Don't use unicode in Python 3 for removing the support of Python 2 ( psycopg2 driver - __init__.py, server_manager.py). - Merge the lastest pgcli (version: 3.0.0) for SQL autocompletion. Branch -- master Details --- https://gi

Re: [pgAdmin 4 - Housekeeping #5255] Implement Selenium Grid using multi-threading & solenoid using current test framework

2020-05-08 Thread Akshay Joshi
Hi Yogesh You forgot to attach patch :) On Fri, May 8, 2020 at 1:35 PM Yogesh Mahajan < yogesh.maha...@enterprisedb.com> wrote: > Hi, > > Please find the updates patch with above review comments. > Patch adds below functionality to existing framework - > 1.Ability to run features in parallel usi

Re: [pgAdmin 4 - Housekeeping #5255] Implement Selenium Grid using multi-threading & solenoid using current test framework

2020-05-08 Thread Yogesh Mahajan
Hi, Please find the updates patch with above review comments. Patch adds below functionality to existing framework - 1.Ability to run features in parallel using solenoid(selenium + docker). a.Selenoid setup steps are included in /regression/README b.'python runtests.py --pkg feature_tes

Re: [pgAdmin4][Patch] - Remove Python2 modules

2020-05-08 Thread Akshay Joshi
Thanks, patch applied. On Fri, May 8, 2020 at 11:30 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > We have added some of the Python modules in try and except to support > Python2 and Python3 both. Please find the attached patch to remove the > Python2 modules import stateme

pgAdmin 4 commit: Remove Python2 modules.

2020-05-08 Thread Akshay Joshi
Remove Python2 modules. refs #5443 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d68e6bd892e5cb88b849fd16412b2fe2adaa6d4a Author: Khushboo Vashi Modified Files -- web/pgadmin/__init__.py| 5

Re: RM-5434 (New table added is not alphabetically added to the tree)

2020-05-08 Thread Akshay Joshi
Thanks, patch applied. On Thu, May 7, 2020 at 1:15 PM Satish V wrote: > Hi Hackers, > > In the patch attached, > 1.Creation or updation of Tables and all other entities will be sorted > according to their names. > 2.Exception- Columns will be sorted according to their creation > order(position I

pgAdmin 4 commit: Fixed an issue where the newly added table is not alp

2020-05-08 Thread Akshay Joshi
Fixed an issue where the newly added table is not alphabetically added to the tree. Fixes #5434 Fixed an issue when renaming the column not added in the proper order. Fixes #5450 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9338bdcb3aae724