Re: RM3694-If database is already connected and click on database then connect database should not displayed in Menu

Hi Khushboo, In the attached patch, Fixed pep8 and made use of 'gettext' inside "database.js" file... Regarding *res.info ='Database already connected', **we are appending the database name and server name in front of 'res.info ' string in the very next line. So u

[pgAdmin][RM5455] Cleanup pgAdmin.py

Hi Hackers, Attached is the patch to restructure pgAdmin4.py so that the startup code can be imported by setup_pip.py. Code is also changed to tidy and restructure the code a bit. Changes won't affect other runners like runtime, WSGI, etc. Please review. -- Thanks and Regards, Aditya Toshniwal

Re: Raise an exception under Python < 3.4

Thanks, patch applied. Also, search PY2 and removed all the references by correcting the logic. On Thu, Apr 30, 2020 at 1:45 PM Dave Page wrote: > Hi Akshay, > > Sure, go for it. > > On Thu, Apr 30, 2020 at 9:14 AM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Dave >> >> Can we

Re: Remove Python 2 support from the Python tests

Thanks, patch applied. On Tue, Apr 28, 2020 at 5:52 PM Dave Page wrote: > Patch for $SUBJECT attached. > > Fixed a couple of other very minor typos along the way. > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Ent

Re: Remove Python 2 support from the desktop runtime

Thanks, patch applied. On Wed, Apr 29, 2020 at 11:08 AM Neel Patel wrote: > Hi Dave, > > I reviewed and tested and it looks good to me. > > Thanks, > Neel Patel > > On Tue, Apr 28, 2020 at 1:32 PM Dave Page wrote: > >> Apparently, yes :-( >> >> On Mon, Apr 27, 2020 at 9:15 PM Ashesh Vashi < >>

Re: Remove Python 2.7 support from the wheel package

Thanks, patch applied. On Mon, Apr 27, 2020 at 9:31 PM Dave Page wrote: > > > On Mon, Apr 27, 2020 at 4:59 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> >> On Mon, Apr 27, 2020 at 9:27 PM Dave Page wrote: >> >>> Thanks - I assume not for 4.21 though? >>> >> >> I thought it

pgAdmin 4 commit: Remove Python2 references from the source code.

Remove Python2 references from the source code. refs #5443 Initial patch: Neel Patel Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ad80217593d9e6ba1a3ffd052644aa5592429073 Modified Files -- docs/en_US/build_code_snippet.py

pgAdmin 4 commit: Raise an exception under Python < 3.4.

Raise an exception under Python < 3.4. It also cleans up the README to remove references to Python 2 and removes Python 2-isms from the main config. refs #5443 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7dd00a149448d84df061600364633d92dd

pgAdmin 4 commit: Remove Python 2 support from the desktop runtime

Remove Python 2 support from the desktop runtime refs #5443 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=109051e1d5e240c10ba620cfbdadd5fc5312d11b Author: Dave Page Modified Files -- runtime/Server.cpp | 39 --

pgAdmin 4 commit: Remove Python 2 support from the Python tests.

Remove Python 2 support from the Python tests. refs #5443 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=86afec860f456d313a0a10d017707e4dfe70002d Author: Dave Page Modified Files -- .../servers/databases/casts/tests/test_cast_cr

pgAdmin 4 commit: Remove Python 2.7 support from the wheel package.

Remove Python 2.7 support from the wheel package. refs #5443 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=393741fd9d22589c7981398cd6898b441e5e78c1 Author: Dave Page Modified Files -- pkg/pip/build.sh | 2 +- pkg/pip/setup_

Re: RM3694-If database is already connected and click on database then connect database should not displayed in Menu

Hi Satish, Some minor comments: - Fix PEP8 issues. - Use gettext in database.js file for the info message. - No need to assign text value in res object (res.info = 'Database already connected.'), use this text directly in Alertify.info. Thanks, Khushboo On Thu, Apr 30, 2020 at 1:59 PM Satis

pgAdmin 4 commit: Tag REL-4_21 has been created.

Tag REL-4_21 has been created. View: https://git.postgresql.org/gitweb?p=pgadmin4.git;a=tag;h=refs/tags/REL-4_21 Log Message --- Tag v4.21

pgAdmin 4 v4.21 released

The pgAdmin Development Team is pleased to announce pgAdmin 4 version 4.21. This release of pgAdmin 4 includes over 74 bug fixes and new features. For more details please see the release notes at: https://www.pgadmin.org/docs/pgadmin4/dev/release_notes_4_21.html. *Note: *The next release of p

Re: pgAdmin4 v4.21 candidate builds

Hi, One Round of testing has been completed, Can you please release pgadmin4 4.21? On Tue, Apr 28, 2020 at 11:48 AM Akshay Joshi wrote: > Hi All, > > Due to RM #5447 , we will > have respin the candidate build. New candidate builds and source can be >

Re: RM3694-If database is already connected and click on database then connect database should not displayed in Menu

Hi, I made the changes to the code such that conn.connect() will happen only when there is no prior connection exist. In short, connection via context menu will not trigger this conn.connect(). In the client side code, instead of error alert, info alert is used to inform the user. Kindly review t

Re: Raise an exception under Python < 3.4

Hi Akshay, Sure, go for it. On Thu, Apr 30, 2020 at 9:14 AM Akshay Joshi wrote: > Hi Dave > > Can we add a similar exception in our test suites? Instead of throwing > import error, it would be good. If you agree I'll modify the logic. > > On Mon, Apr 27, 2020 at 9:27 PM Dave Page wrote: > >> T

Re: Raise an exception under Python < 3.4

Hi Dave Can we add a similar exception in our test suites? Instead of throwing import error, it would be good. If you agree I'll modify the logic. On Mon, Apr 27, 2020 at 9:27 PM Dave Page wrote: > The attached patch raises an exception if run under Python < 3.4. It also > cleans up the README