Re: [pgAdmin][RM5043] Column names not in creation order during - refresh via context menu required to resort them properly

Hello, Patch looks good to me. Newly created columns sorted according to their creation order without context refresh. Thanks! On Thu, Apr 23, 2020 at 10:13 AM navnath gadakh < navnath.gad...@enterprisedb.com> wrote: > Hi, > > I'm reviewing this patch. > > On Wed, Apr 22, 2020 at 6:54 PM Sati

pgAdmin 4 commit: Recreate the node item in the tree, when 'id' has bee

Recreate the node item in the tree, when 'id' has been changed of the node. Fixes #5053 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=637c80c38b7929c4c3153b2628bcb80a8b3d625c Modified Files -- web/pgadmin/browser/static/js/brows

Re: [pgAdmin][RM5043] Column names not in creation order during - refresh via context menu required to resort them properly

Hi, I'm reviewing this patch. On Wed, Apr 22, 2020 at 6:54 PM Satish V wrote: > > Hi Hackers, > > In the attached patch, newly created columns in a table are sorted > according to their creation order rather than the alphanumerical order. > Previously this was not happening without context ref

Can't save data after edit in View/Edit Data mode

Browser: Firefox 75.0 (64-bit) OS: OSX 10.15.4 (19E287) Reproduce: Open pgadmin4, navigate to a table, right click -> View/Edit -> All Rows. Scroll to bottom, enter data (2 columns in this case). Save button is disabled.

[pgAdmin][RM5043] Column names not in creation order during - refresh via context menu required to resort them properly

Hi Hackers, In the attached patch, newly created columns in a table are sorted according to their creation order rather than the alphanumerical order. Previously this was not happening without context refresh. Please review. Thanks Sathish V diff --git a/web/pgadmin/browser/static/js/browser.j

Re: [pgAdmin][RM3269] Slider jumps up issue in DataView panel

Thanks, patch applied. On Wed, Apr 22, 2020 at 5:38 PM Nagesh Dhope wrote: > Hi Hackers, > The attached patch makes an API call to fetch the next batch of rows only > after a user stops scrolling down(to detect added timeout of 250ms) using > the slider. > > On Tue, Apr 21, 2020 at 1:32 PM Aksha

Re: [pgAdmin4][Patch] - RM 3900 - Delete/Drop option is disabled for the constraints

Thanks, patch applied. On Wed, Apr 22, 2020 at 3:28 PM navnath gadakh < navnath.gad...@enterprisedb.com> wrote: > Patch looks good to me. > > On Wed, Apr 22, 2020 at 1:54 PM navnath gadakh < > navnath.gad...@enterprisedb.com> wrote: > >> Hello, >> >> I'm reviewing this RM. >> >> On Wed, Apr 22,

Re: [pgAdmin4][Patch] - RM 5419, RM 5420, RM 5432 - LDAP User Management Fixes

Thanks, patch applied. On Wed, Apr 22, 2020 at 5:11 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to fix the issues below. > > # 5419 - [Ldap] User should not allow to change with internal if user > created with ldap > # 5420 - [Ldap] Error s

Re: [pgAdmin][RM5352] : Rightmost & Bottom tooltip crop issues in Explain Query Plan

Thanks, patch applied. On Wed, Apr 22, 2020 at 4:58 PM navnath gadakh < navnath.gad...@enterprisedb.com> wrote: > Please commit the second patch as there is an issue with first one for the > zoom factor. > > On Wed, Apr 22, 2020 at 4:50 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: >

pgAdmin 4 commit: Ensure that the user should not be able to change the

Ensure that the user should not be able to change the authentication source. Fixes #5419 Ensure error should be handled properly when LDAP user is created with the same name. Fixes #5420 Fixed an issue where an internal user is not created if the authentication source is set to internal and ldap

pgAdmin 4 commit: Fixed slider jump issue by making an API call to fetc

Fixed slider jump issue by making an API call to fetch the next batch of rows only after a user stops scrolling down. Fixes #3269 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5e91ed2bb1123b7bc7a96ee783d50b8b8b2f716b Author: Nagesh Dhope M

pgAdmin 4 commit: Fixed tooltip crop issue for the large complex query

Fixed tooltip crop issue for the large complex query with zoom factor. Fixes #5352 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=553eeb034dbcdfb613a9e8d99b030e64090bda54 Author: Yogesh Jain Modified Files -- web/pgadmin/misc/st

pgAdmin 4 commit: Added multiple drop/delete functionality for the tabl

Added multiple drop/delete functionality for the table constraints. Fixes #3900 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6e5dbf7beb251d685788e08de477b5e17c50ed94 Author: Khushboo Vashi Modified Files -- docs/en_US/release_n

pgAdmin 4 commit: SVG image format plugin is added to render the image

SVG image format plugin is added to render the image file from stylesheet. And also removed the theme components staging files used during windows and Mac bundling. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=870bcbd932cc5164964dfa9b273c2

pgAdmin 4 commit: Ensure that default sort order should be using the pr

Ensure that default sort order should be using the primary key in View/Edit data. Fixes #5157 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c76732e3e74108a1ebcc0090f1f259ca0ad2f69b Author: navnath gadakh Modified Files -- docs/

Re: [pgAdmin][RM3269] Slider jumps up issue in DataView panel

Hi Hackers, The attached patch makes an API call to fetch the next batch of rows only after a user stops scrolling down(to detect added timeout of 250ms) using the slider. On Tue, Apr 21, 2020 at 1:32 PM Akshay Joshi wrote: > Thanks, patch applied. > > On Tue, Apr 21, 2020 at 12:10 PM Nagesh Dho

pgAdmin 4 commit: Fixed validation errors in view/materialized view jav

Fixed validation errors in view/materialized view javascript to determine the number columns chagned. It was trying to execute 'replace' and 'includes' function on undefined values instead of string value. Also - changed the warning message, and separated the 'Do you want to continue?' syntax in s

[pgAdmin4][Patch] - RM 5419, RM 5420, RM 5432 - LDAP User Management Fixes

Hi, Please find the attached patch to fix the issues below. # 5419 - [Ldap] User should not allow to change with internal if user created with ldap # 5420 - [Ldap] Error should be handled properly if user provides ldap user with same name # 5432 - [Ldap]User can not create internal user if intern

Re: [pgAdmin][RM5352] : Rightmost & Bottom tooltip crop issues in Explain Query Plan

Please commit the second patch as there is an issue with first one for the zoom factor. On Wed, Apr 22, 2020 at 4:50 PM Akshay Joshi wrote: > Patch is committed :). Not pushed > > On Wed, 22 Apr, 2020, 16:46 navnath gadakh, < > navnath.gad...@enterprisedb.com> wrote: > >> Hi, >> >> I'm reviewin

Re: [pgAdmin][RM5352] : Rightmost & Bottom tooltip crop issues in Explain Query Plan

Patch is committed :). Not pushed On Wed, 22 Apr, 2020, 16:46 navnath gadakh, wrote: > Hi, > > I'm reviewing this patch. > > On Wed, Apr 22, 2020 at 3:09 PM Yogesh Jain > wrote: > >> Hi Hackers, >> >> Here is an updated patch which solves the problem of more large query >> which deals fine wit

Re: [pgAdmin][RM5352] : Rightmost & Bottom tooltip crop issues in Explain Query Plan

Hi, I'm reviewing this patch. On Wed, Apr 22, 2020 at 3:09 PM Yogesh Jain wrote: > Hi Hackers, > > Here is an updated patch which solves the problem of more large query > which deals fine with zoom factor as well . > > FYI: During testing it was found that the previous patch was only working >

Re: [pgAdmin4][Patch] - RM 3900 - Delete/Drop option is disabled for the constraints

Patch looks good to me. On Wed, Apr 22, 2020 at 1:54 PM navnath gadakh < navnath.gad...@enterprisedb.com> wrote: > Hello, > > I'm reviewing this RM. > > On Wed, Apr 22, 2020 at 10:55 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> Please find the attached patch to fi

Re: [pgAdmin][RM5352] : Rightmost & Bottom tooltip crop issues in Explain Query Plan

Hi Hackers, Here is an updated patch which solves the problem of more large query which deals fine with zoom factor as well . FYI: During testing it was found that the previous patch was only working for mid sized query and not more large complex query due to zoom factor issue. Please review the

Re: [pgAdmin][RM3947] Fixes related rows copy-paste in Query Tool.

Thanks, patch applied. On Wed, Apr 22, 2020 at 10:09 AM Nagesh Dhope wrote: > Hi, > Please find a patch, which will allow copying *[null]* and *[default] > cell values.* > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91

Re: Exclude RESQL test cases

Thanks, patch applied. On Wed, Apr 22, 2020 at 11:32 AM navnath gadakh < navnath.gad...@enterprisedb.com> wrote: > Hello Hackers, > > Please review the small patch to exclude RESQL test cases. > resql param is added to --exclude. > > Thanks! > > -- > Regards, > Navnath Gadakh > -- *T

pgAdmin 4 commit: 1) Fixed feature test and API test cases.

1) Fixed feature test and API test cases. 2) Added logic to exclude RESQL test cases. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4c616f32eb5afe9afdf56a9cd584f7798266c085 Modified Files -- .../servers/pgagent/templates/macros/p

pgAdmin 4 commit: Fixed an issue where [null] and [default] values are

Fixed an issue where [null] and [default] values are not get copied. Part of #3947 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b29bc6868c074511b3fa91089213abd31be03b2b Author: Nagesh Dhope Modified Files -- web/pgadmin/tools/

Re: [pgAdmin4][Patch] - RM 3900 - Delete/Drop option is disabled for the constraints

Hello, I'm reviewing this RM. On Wed, Apr 22, 2020 at 10:55 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to fix the RM #3900 - Delete/Drop option > is disabled for the constraints. > > - Implemented multiple drop/delete functionality for t