pgAdmin is freezing

2020-04-17 Thread Nagaraj Raj
Hi, pgAdmin is freezing for other activities when dropping any table or index if command is held because of any lock occurring. In this state unable to access any other objects like stats, SQL statements, descriptions or query tool for other objects. pgAdmin resume to start working fine after ei

[pgAdmin][RM5396] Unable to locate this object in the browser in search objects

2020-04-17 Thread Aditya Toshniwal
Hi Hackers, Attached is the patch to fix the issues raised in the RM and other issues which I encountered while fixing. Following are the details: 1) Not able to locate indexes, trigger under partition of partitioned table. 2) Not able to locate columns under catalog schemas other than pg_catalog.

Re: [pgAdmin][RM5157] Default sort order at start in view table data by primary key by default

2020-04-17 Thread navnath gadakh
Hello Hackers, Please find the modified patch with an option in Preferences for data sorting by the primary key. Also, the previous patch was not working with table has no primary key. Thanks! On Thu, Apr 16, 2020 at 5:01 PM Dave Page wrote: > > > On Thu, Apr 16, 2020 at 12:08 PM navnath

Re: [pgAdmin][RM4573] Download csv as .csv when delimeter set comma(,)

2020-04-17 Thread Akshay Joshi
Thanks, patch applied. On Fri, Apr 17, 2020 at 5:08 PM Nagesh Dhope wrote: > Hi Akshay, > Please find an updated patch with updated screenshots and documentation > changes. > > On Fri, Apr 17, 2020 at 12:28 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Nagesh >> >> Patch look

Re: [pgAdmin][RM4684] : Python encoding issue while saving data in charset other than 'utf-8'

2020-04-17 Thread Akshay Joshi
Thanks, patch applied. On Fri, Apr 17, 2020 at 1:01 PM Yogesh Jain wrote: > Hi Hackers, > > Attached is the patch to fix encoding issues while saving data in encoded > charset other than 'utf-8'. > > FYI : While using the local charset latin-9 (ISO 8859-15), if a record > contains an umlaut *ü *

pgAdmin 4 commit: Fixed encoding issue while saving data in encoded cha

2020-04-17 Thread Akshay Joshi
Fixed encoding issue while saving data in encoded charset other than 'utf-8'. Fixes #4684 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=52d031f2d052804dae27ab24551e9eb44146738f Author: Yogesh Jain Modified Files -- docs/en_US/r

pgAdmin 4 commit: Ensure that if the delimiter is set other than comma

2020-04-17 Thread Akshay Joshi
Ensure that if the delimiter is set other than comma then download the file as '.txt' file. Fixes #4573 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8bdfa18efb4430e646162e530f7aec87d48ac29f Author: Nagesh Dhope Modified Files

Re: [pgAdmin][RM4946] Issue with temporary tables on commit drop as.

2020-04-17 Thread Amol Vyavahare
Hi Khushboo, Please find attached the updated patch with the latest changes as suggested along with API test cases for the RM4946 issue fix. Thank You. On Wed, Apr 15, 2020 at 2:26 PM Amol Vyavahare < amol.vyavah...@enterprisedb.com> wrote: > Sure, will do that. > > On Wed, Apr 15, 2020 at 1:33

Re: [pgAdmin4][RM#3495] Do not check for binary content if BOM marker is present in the file

2020-04-17 Thread Akshay Joshi
Thanks, patch applied. On Thu, Apr 16, 2020 at 5:23 PM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA patch to fix the issue where the user was not able to load the file in > the Query tool which contains the BOM marker, The sample file with BOM > marker is already a

pgAdmin 4 commit: Fixed an issue while removing the package body showin

2020-04-17 Thread Akshay Joshi
Fixed an issue while removing the package body showing wrong modified SQL. Fixes #5410 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c6deb9393cf7e1773060e0f07eb24a8b18283828 Modified Files -- docs/en_US/release_notes_4_21.rst

pgAdmin 4 commit: Fixed validation issue in Synonyms node. Fixes #5409

2020-04-17 Thread Akshay Joshi
Fixed validation issue in Synonyms node. Fixes #5409 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d8ad0b8faf2330c4679443cb888e526f91df Modified Files -- docs/en_US/release_notes_4_21.rst | 1 + .../datab

pgAdmin 4 commit: Fixed an issue where the query tool unable to load th

2020-04-17 Thread Akshay Joshi
Fixed an issue where the query tool unable to load the file which contains the BOM marker. Fixes #3495 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d35433d0b87d47f4d590010ba498de567aaf8b04 Author: Murtuza Zabuawala Modified Files

[pgAdmin][RM4684] : Python encoding issue while saving data in charset other than 'utf-8'

2020-04-17 Thread Yogesh Jain
Hi Hackers, Attached is the patch to fix encoding issues while saving data in encoded charset other than 'utf-8'. FYI : While using the local charset latin-9 (ISO 8859-15), if a record contains an umlaut *ü *and dataset was updated, then there was error message 'utf-8' codec can't decode byte 0xf

Re: [pgAdmin][RM4573] Download csv as .csv when delimeter set comma(,)

2020-04-17 Thread Akshay Joshi
Hi Nagesh Patch looks good to me. Please update the screenshot and documentation for the Preferences and Query Tool. On Thu, Apr 16, 2020 at 4:43 PM Nagesh Dhope wrote: > Hi Hackers, > This patch allows user to download CSV as a '.csv' file if > delimiter character is set to comma(,) else it wi