Re: [pgAdmin4][RM#4858] Allow user to reconnect to DB server when connection is drop

Hi Akshay, PFA updated patch. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Apr 13, 2020 at 2:28 PM Akshay Joshi wrote: > Hi Murtuza > > The issue has been fixed with your patch, but there is an existing issue > discover wi

Re: [pgAdmin][RM4946] Issue with temporary tables on commit drop as.

Hi, I am reviewing this patch. Thanks, Khushboo On Wed, Apr 15, 2020 at 11:45 AM Amol Vyavahare < amol.vyavah...@enterprisedb.com> wrote: > Hi Hackers, > Attached is the patch to fix the Issue with temporary tables on commit > drop as. This patch fixes the issue where an error was thrown when t

[pgAdmin4][Patch] - RM 4957 - Constraint Trigger, Deferrable, Deferred option should be disbled if user select EDB-SPL function for trigger for EPAS.

Hi, Please find the attached small patch to fix the issue #4957 - Constraint Trigger, Deferrable, Deferred option should be disbled if user select EDB-SPL function for trigger for EPAS. Thanks, Khushboo RM_4957.patch Description: Binary data

Re: pgAdmin 4 - next gettext usage fixes

On Wed, Apr 15, 2020 at 11:38 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers/Libor, > > The changes like below are incorrect. Try "Count rows" from a table's > context menu. > > -info=gettext("Table rows counted: %s" % count), > > +info=gettext

[pgAdmin][RM4946] Issue with temporary tables on commit drop as.

Hi Hackers, Attached is the patch to fix the Issue with temporary tables on commit drop as. This patch fixes the issue where an error was thrown when the user tried to create a temporary table via query tool and no result was displayed when the query was executed. Please review. -- *Regards,* *A

Re: pgAdmin 4 - next gettext usage fixes

Hi Hackers/Libor, The changes like below are incorrect. Try "Count rows" from a table's context menu. -info=gettext("Table rows counted: %s" % count), +info=gettext("Table rows counted: %s") % count, Attached is the patch to fix all such changes in pgAdmin, to use format

[pgAdmin4][Patch]: RM 5366 - PgAdmin hangs in 'loading' state after trying to preview the first 100 records

Hi, Please find the attached patch to fix the RM #5366 - PgAdmin hangs in ' loading' state after trying to preview the first 100 records. Many users reported this issue but the root cause of the issue has not been found yet and with the Reset Layout option, this issue is getting fixed. So, in or

[pgAdmin][RM3947] Fixes related rows copy-paste in Query Tool.

Hi Hackers, Please find a patch which fixes, 1. Copy table rows across two or more active query tool sessions. 2. Copied rows can be pasted multiple times without selecting a row in the query tool grid. 3. Adds an empty row at the end in the query tool grid after pasting rows. --

Re: Proposal: Drop support for Internet Explorer

On Tue, 14 Apr 2020 at 18:51, Darren Duncan wrote: > You have a typo `elif browser != 'chrom'` but otherwise I see no problems > with > the patch, thank you. -- Darren Duncan Well spotted. That was an intentional testing artefact (deliberating causing Chrome to not be recognised), but Akshay al

Re: Proposal: Drop support for Internet Explorer

You have a typo `elif browser != 'chrom'` but otherwise I see no problems with the patch, thank you. -- Darren Duncan On 2020-04-14 7:46 a.m., Dave Page wrote: Ooops. Thanks for catching that. Here it is. On Tue, Apr 14, 2020 at 3:45 PM Neel Patel > wrote:

Re: Proposal: Drop support for Internet Explorer

Thanks, patch applied. On Tue, Apr 14, 2020 at 8:17 PM Dave Page wrote: > Ooops. Thanks for catching that. Here it is. > > On Tue, Apr 14, 2020 at 3:45 PM Neel Patel > wrote: > >> Hi Dave, >> >> Looks like patch is missing in attachment. >> >> Thanks, >> Neel Patel >> >> >> On Tue 14 Apr, 2020,

pgAdmin 4 commit: Fixed Mac OSX build by adding the prefix in qrc file.

Fixed Mac OSX build by adding the prefix in qrc file. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ee29e6403926fd4d757012958a190f55715eeaf1 Author: Neel Patel Modified Files -- runtime/breeze.qrc | 2 +- 1 file changed, 1 insert

pgAdmin 4 commit: Warn the user if an unsupported, deprecated or unknow

Warn the user if an unsupported, deprecated or unknown browser is detected. Fixes #5399 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=74b349554282545dd7fed26bc39ef5b9b571c629 Author: Dave Page Modified Files -- docs/en_US/relea

Re: Proposal: Drop support for Internet Explorer

Ooops. Thanks for catching that. Here it is. On Tue, Apr 14, 2020 at 3:45 PM Neel Patel wrote: > Hi Dave, > > Looks like patch is missing in attachment. > > Thanks, > Neel Patel > > > On Tue 14 Apr, 2020, 6:53 PM Dave Page, wrote: > >> Here's an updated patch that gives a slightly different mes

Re: Proposal: Drop support for Internet Explorer

Hi Dave, Looks like patch is missing in attachment. Thanks, Neel Patel On Tue 14 Apr, 2020, 6:53 PM Dave Page, wrote: > Here's an updated patch that gives a slightly different message if the > browser is unknown vs. unsupported/deprecated. As with the previous patch, > the check can be disabl

Re: Proposal: Drop support for Internet Explorer

Here's an updated patch that gives a slightly different message if the browser is unknown vs. unsupported/deprecated. As with the previous patch, the check can be disabled in the config. On Fri, Apr 10, 2020 at 5:07 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Thu, Apr 9,

pgAdmin 4 commit: Using 'is_valid_ipaddress' utility function everywher

Using 'is_valid_ipaddress' utility function everywhere Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3a4641889c3798e0509a360bf2070305c30fb245 Modified Files -- web/pgadmin/browser/server_groups/servers/__init__.py | 13 ++

pgAdmin 4 commit: A valid ip address can be IPv4/IPv6

A valid ip address can be IPv4/IPv6 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d9c84edf9a6714dbb73b771745831ff55c46f818 Modified Files -- web/pgadmin/utils/ip.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgAdmin 4 commit: Merged adjustanct 'if' statements when allowed.

Merged adjustanct 'if' statements when allowed. Also - removed the unused variables. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a930c6617b0a788093346860da76f2467bdd3a3b Modified Files -- web/pgAdmin4.py | 13 ++

pgAdmin 4 commit: We don't need to pass gettext for inline CSS transfor

We don't need to pass gettext for inline CSS transforation Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6c5883bce0cf885579a5e8a813716fc25df0f3d1 Modified Files -- .../databases/schemas/tables/constraints/foreign_key/__init__.py

pgAdmin 4 commit: [Authentication] Some of the base class functions are

[Authentication] Some of the base class functions are not static function, but - methods. Hence - 'self' should be used, and not 'cls'. Also - use a constant for duplicate string literal in LDAP authentication implementation. Branch -- master Details --- https://git.postgresql.org/gitweb

pgAdmin 4 commit: [Foreign Key] Removed 1 unexpected arguments; 'get_no

[Foreign Key] Removed 1 unexpected arguments; 'get_node_list' expects 5 positional arguments. Also, - Using 'gettext' instead of '_'. - Using constant string for 'foreign_key not found' error message. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitd

[pgAdmin][RM4873] Change comment of a procedure with arguments

Hi Hackers, Attached is a patch to fix following issues: 1) Change comment of procedure with arguments as a procedure can be overloaded. Note that on EPAS servers, procedure overloading works only for v11+ . 2) The save button of a procedure dialog is enabled without any change. Fixed. 3) Fixed fo

[pgAdmin][4709] Invalid FTS configuration token dictionaries

Hi Hackers, Attached is the patch to add schema qualified dictionary names in FTS configuration to overcome the confusion of duplicate dictionary names. Also modified the resql test cases accordingly. Please review. Regards, Ganesh Jaybhay diff --git a/web/pgadmin/browser/server_groups/servers/

Re: [pgAdmin][RM5210] pgAdmin4 silently truncates text larger than underlying field size

Hi Navnath, You have compared the column's internal size with the length of the value given by the user. For example, column having integer would have internal size 4 and if I give the value 12121 which is the correct input for the field will fail here because as per your logic column internal siz

Re: [pgAdmin][RM5210] pgAdmin4 silently truncates text larger than underlying field size

Hi, I am reviewing this patch. Thanks, Khushboo On Tue, Apr 14, 2020 at 4:33 PM navnath gadakh < navnath.gad...@enterprisedb.com> wrote: > Hello Hackers, > Please find the attached patch for below fixes: > > - Added validation for table row data that should not be larger than the > field size.

[pgAdmin][RM5210] pgAdmin4 silently truncates text larger than underlying field size

Hello Hackers, Please find the attached patch for below fixes: - Added validation for table row data that should not be larger than the field size. - Rearrange the existing functions to add validation. - Added test cases. Regards, Navnath Gadakh rm_5210_v1.patch Description: Binary data

[pgAdmin4 - Bug #5387]

Hi Team, PFA the patch for displaying mode in properties of func/proc if all args are "IN" -- Thanks & Regards, Shubham Agarwal EnterpriseDB Corporation The Postgres Database Company rm_5387_v1.patch Description: Binary data

pgAdmin 4 commit: Fix the bundling issue of dark mode runtime support f

Fix the bundling issue of dark mode runtime support for Windows and Mac. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=65bc196ebab314178bf9523f91ef9f9f07d5e4e8 Author: Neel Patel Modified Files -- Make.bat | 6

Re: [pgAdmin4][Patch] - RM 5383 - Error related to OID displayed if Click on properties of synonym and Click on refresh button

Thanks, patch applied. On Tue, Apr 14, 2020 at 11:29 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached small patch to fix the RM #5383 - Error related > to OID displayed if Click on properties of synonym and Click on refresh > button. > > Thanks, > Khu

Re: [pgAdmin][RM5007] Index should be visible using unique constraints

Thanks, patch applied. On Mon, Apr 13, 2020 at 5:51 PM Ganesh Jaybhay < ganesh.jayb...@enterprisedb.com> wrote: > Hi Hackers, > Please find the attached patch with below fixes: > > - Index dropdown should have existing indexes while creating unique > constraint > - On selecting index from index d

pgAdmin 4 commit: Fixed syntax error while refreshing the existing syno

Fixed syntax error while refreshing the existing synonyms. Fixes #5383 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a0fcb38e6802fe43ec54c2c102b96d82f9e5f6f3 Author: Khushboo Vashi Modified Files -- docs/en_US/release_notes_4_21

pgAdmin 4 commit: Ensure index dropdown should have existing indexes wh

Ensure index dropdown should have existing indexes while creating unique constraints. Fixes #5007 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=12530cd973dd7e4adf7b1a2461ad00bdd5e1054d Author: Ganesh Jaybhay Modified Files -- d

Re: [pgAdmin4][Patch]: RM 4445 - Ensure all object names in the title line of the reverse-engineered SQL are *not* quoted.

Thanks, patch applied. On Mon, Apr 13, 2020 at 5:00 PM Shubham Agarwal < shubham.agar...@enterprisedb.com> wrote: > Hi Team, > > Please find the patch attached for RM-4445. > The patch contains following things- > 1. Fixes for each node. > 2. Fixes for Resql test cases > > > -- > Thanks & Regards

Re: [Patch]: Typo in 'test_config.json.in' file

Thanks, patch applied. On Tue, Apr 14, 2020 at 11:19 AM Neel Patel wrote: > Hi, > > Fix the typo in the test configuration json file while running the test > cases. Currently if someone uses the latest file to run the test cases, it > will fail to run. > > Please find the attached patch. > > Tha

Re: [pgAdmin][RM5371] : Tab key navigation is not working in some of the dialogs

Thanks, patch applied. On Mon, Apr 13, 2020 at 5:48 PM Pradip Parkale < pradip.park...@enterprisedb.com> wrote: > Hi Hackers, > > Please find the attached path. I have fixed tab key navigation in some of > the dialogs. > > This patch includes the fixes for: > > 1 Login/Group roles >> Group parame

pgAdmin 4 commit: Fixed tab key navigation for some dialogs. Fixes #537

Fixed tab key navigation for some dialogs. Fixes #5371 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a05acb4f992da954be8c59e3af26393988a672df Author: Pradip Parkale Modified Files -- docs/en_US/release_notes_4_21.rst

pgAdmin 4 commit: Ensure all object names in the title line of the reve

Ensure all object names in the title line of the reverse-engineered SQL are not quoted. Fixes #4445 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=41521a9b986a1e8331dd452e05bfd2dd0ee53847 Author: Shubham Agarwal Modified Files -

pgAdmin 4 commit: Fix the typo in the test configuration json file.

Fix the typo in the test configuration json file. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=21cb1a01669ba72cbe4e134b499ecbdac1887eb5 Author: Neel Patel Modified Files -- web/regression/test_config.json.in | 6 +++--- 1 file c

Re: [pgAdmin RM#1257] Show system XX properties for sequences node

On Tue, Apr 14, 2020 at 1:26 PM Akshay Joshi wrote: > Hi Vishal > > There are so many nodes where "System " property is missing. > Please verify all the nodes and resend the patch. > Sure, shall check for other nodes and send the revised patch. > > On Mon, Apr 13, 2020 at 5:32 PM Vishal Sawale

Re: [pgAdmin RM#1257] Show system XX properties for sequences node

Hi Vishal There are so many nodes where "System " property is missing. Please verify all the nodes and resend the patch. On Mon, Apr 13, 2020 at 5:32 PM Vishal Sawale < vishal.saw...@enterprisedb.com> wrote: > Hi Hackers, > > PFA the patch for showing the System sequence properties for sequences