pgAdmin 4 commit: [LDAP Authentication] Use more secure protocol TSL v1

2020-04-07 Thread Ashesh Vashi
[LDAP Authentication] Use more secure protocol TSL v1.2 for security reason Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d9e95d13e6f86a284037b10cb739095f09e8b4ee Modified Files -- web/pgadmin/authenticate/ldap.py | 2 +- 1 file c

Re: [pgAdmin4][Patch]: RM 5053 - Getting an error while changing the columns in the existing view

2020-04-07 Thread Akshay Joshi
Thanks, patch applied. On Wed, Apr 8, 2020 at 10:58 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Akshay, > > Please find the attached updated patch. > > Thanks, > Khushboo > > On Tue, Apr 7, 2020 at 11:43 AM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Khushb

Re: [pgAdmin][RM5361] pgAdmin breaks on IE 11 with @simonwep/pickr

2020-04-07 Thread Akshay Joshi
Thanks, patch applied. On Tue, Apr 7, 2020 at 4:59 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to use the ES5 dist of @simonwep/pickr when bundling > pgAdmin to make it work on IE. > Please review. > > -- > Thanks and Regards, > Aditya T

pgAdmin 4 commit: Fixed an issue where changing the columns in the exis

2020-04-07 Thread Akshay Joshi
Fixed an issue where changing the columns in the existing view throws an error. Fixes #5053 PostgreSQL doesn't allow to change the view columns. So the view should be dropped first and then recreate it and also the user will get a warning first. Branch -- master Details --- https://git

pgAdmin 4 commit: Fixes an issue where pgAdmin4 GUI does not display pr

2020-04-07 Thread Akshay Joshi
Fixes an issue where pgAdmin4 GUI does not display properly in IE 11. Fixes #5361 Use the ES5 dist of @simonwep/pickr to make it work on IE. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=03f4109ac4d0049ccca8635b1e24046b32b0ac43 Author: Adit

Re: [pgAdmin4][Patch]: RM 5053 - Getting an error while changing the columns in the existing view

2020-04-07 Thread Khushboo Vashi
Hi Akshay, Please find the attached updated patch. Thanks, Khushboo On Tue, Apr 7, 2020 at 11:43 AM Akshay Joshi wrote: > Hi Khushboo > > The warning message is not showing up. Please fix and resend the patch. > > On Tue, Apr 7, 2020 at 10:00 AM Khushboo Vashi < > khushboo.va...@enterprisedb.c

RE: Proposal: Drop support for Internet Explorer

2020-04-07 Thread Ken Benson
From: Jack Royal-Gordon Sent: Tuesday, April 7, 2020 11:45 AM To: Dave Caughey Cc: Dave Page ; pgAdmin Support ; pgadmin-hackers Subject: Re: Proposal: Drop support for Internet Explorer I’ve had a similar response from not supporting IE since about 2016. A couple users asked about it a

Re: Proposal: Drop support for Internet Explorer

2020-04-07 Thread Jack Royal-Gordon
I’ve had a similar response from not supporting IE since about 2016. A couple users asked about it and had no problem when I told them we didn’t support it. Mostly, they switched to Chrome. 👍👍 > On Apr 7, 2020, at 4:41 AM, Dave Caughey wrote: > > Check the analytics... I think you'll find dro

Re: Proposal: Drop support for Internet Explorer

2020-04-07 Thread richard coleman
Dave, Seeing that IE isn't standards compliant and not only is not being further developed, but Microsoft is actively discouraging its use, it is probably time to drop support for it. I would caution *against* using browser analytics as any sort of proxy for use. Since pgAdmin 4 lacks a UI of it

Re: Proposal: Drop support for Internet Explorer

2020-04-07 Thread Dave Page
On Tue, Apr 7, 2020 at 12:41 PM Dave Caughey wrote: > Check the analytics... I think you'll find dropping it is a non-issue. In > my own web service, I found that IE (all versions) constituted only about > 1% of my users. > Good point - 1.9% of the visitors to the website were on IE this week. 1

Re: Proposal: Drop support for Internet Explorer

2020-04-07 Thread Dave Caughey
Check the analytics... I think you'll find dropping it is a non-issue. In my own web service, I found that IE (all versions) constituted only about 1% of my users. So I dropped support for IE (since it was preventing me from fully adopting ES6), and there was not a single complaint from my users.

[pgAdmin][RM5361] pgAdmin breaks on IE 11 with @simonwep/pickr

2020-04-07 Thread Aditya Toshniwal
Hi Hackers, Attached is the patch to use the ES5 dist of @simonwep/pickr when bundling pgAdmin to make it work on IE. Please review. -- Thanks and Regards, Aditya Toshniwal pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE" RM5361.patch

pgAdmin 4 commit: Update yarn.lock

2020-04-07 Thread Dave Page
Update yarn.lock Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=bd0aaf766575d74188b6824f67b775f7ae3550e5 Modified Files -- web/yarn.lock | 236 +++--- 1 file changed, 11 insertion

Re: [pgAdmin][RM4206]: Grant wizard does not close when we press ESC key

2020-04-07 Thread Akshay Joshi
Thanks, patch applied. On Tue, Apr 7, 2020 at 1:42 PM Pradip Parkale < pradip.park...@enterprisedb.com> wrote: > Hi Akshay, > Please find the updated patch. > > On Mon, Apr 6, 2020 at 3:26 PM Akshay Joshi > wrote: > >> Hi Pradip >> >> Patch not working, please check one more time. >> >> On Mon,

Re: [pgAdmin][RM4856] Saving the contents of the "Query Editor"

2020-04-07 Thread Akshay Joshi
Thanks, patch applied. On Tue, Apr 7, 2020 at 1:47 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to enable the save button by default when a query > tool is opened with CREATE or other scripts. > Code is changed to consider it as a change

pgAdmin 4 commit: Enable the save button by default when a query tool i

2020-04-07 Thread Akshay Joshi
Enable the save button by default when a query tool is opened with CREATE or other scripts. Fixes #4856 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=134c1802e7bc8924f11721eb3834b3e869680b07 Author: Aditya Toshniwal Modified Files

pgAdmin 4 commit: Ensure that the grant wizard should be closed on pres

2020-04-07 Thread Akshay Joshi
Ensure that the grant wizard should be closed on pressing the ESC key. Fixes #4206 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=33deacaceedac32645c5c68f8a69e2a7a28f9080 Author: Pradip Parkale Modified Files -- docs/en_US/relea

[pgAdmin][RM4856] Saving the contents of the "Query Editor"

2020-04-07 Thread Aditya Toshniwal
Hi Hackers, Attached is the patch to enable the save button by default when a query tool is opened with CREATE or other scripts. Code is changed to consider it as a change when the script text is set. This will enable the save button automatically. -- Thanks and Regards, Aditya Toshniwal pgAdmin

Re: [pgAdmin][RM4206]: Grant wizard does not close when we press ESC key

2020-04-07 Thread Pradip Parkale
Hi Akshay, Please find the updated patch. On Mon, Apr 6, 2020 at 3:26 PM Akshay Joshi wrote: > Hi Pradip > > Patch not working, please check one more time. > > On Mon, Apr 6, 2020 at 2:20 PM Pradip Parkale < > pradip.park...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Please find the attache

Re: [pgAdmin][RM3988] Cursor disappears in Query Editor

2020-04-07 Thread Akshay Joshi
Thanks, patch applied. On Mon, Apr 6, 2020 at 5:59 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is a small patch to fix a cursor issue in the query editor. > The cursor disappears for some of the characters when zoomed out. > > Please review. > > -- >

pgAdmin 4 commit: Fixed cursor disappeared issue in the query editor fo

2020-04-07 Thread Akshay Joshi
Fixed cursor disappeared issue in the query editor for some of the characters when zoomed out. Fixes #3988 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d6bc3ccc8ba72bc7a1d1d420ddeda76d66d90a83 Author: Aditya Toshniwal Modified Files -

Proposal: Drop support for Internet Explorer

2020-04-07 Thread Dave Page
All, Internet Explorer has long been superseded by Microsoft Edge, and even that has recently moved to using Chromium as it's core engine. Version 11 was originally released in 2013, and though Microsoft have committed to supporting it until 2025, as far as I can tell there have been no notable ne