Re: pgAdmin4 v4.20 candidate builds

2020-04-01 Thread Fahar Abbas
@Akshay Joshi One Round of testing has been done, Can you please publish it? On Mon, Mar 30, 2020 at 7:12 PM Akshay Joshi wrote: > Hi All, > > pgAdmin4 v4.20 candidate builds and source can be found at > https://developer.pgadmin.org/builds/2020-03-30-1/ > > Fahar, can you please verify it fo

Re: [pgAdmin][RM2172] Search Objects Functionality

2020-04-01 Thread Khushboo Vashi
On Wed, Apr 1, 2020 at 6:00 PM Akshay Joshi wrote: > Hi Khushboo, > > Can you please review it. > I am on it. > > On Mon, Mar 30, 2020 at 2:39 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch to implement search objects functionality

[Accessibility] Parse & validate the web pages

2020-04-01 Thread Vishal Sawale
Hi Hackers, Attached is a patch for accessibility issue for table header label missing. If it is not present, then it will add span for screen reader. Please review. Regards, Vishal pgadmin_diff.patch Description: Binary data

[pgAdmin4][RM#5314] Make Switch cell sync with Switch control for accessibility

2020-04-01 Thread Murtuza Zabuawala
Hi, This patch will allow the screen reader software to read the actual value from Switch cell like Yes/No same as we have for Switch control. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company pgadmin4_switch_cell.diff Description: Binary

Re: [pgAdmin][RM5181] Add support for parameters toast_tuple_target and parallel_workers of table

2020-04-01 Thread Akshay Joshi
Thanks, patch applied. On Wed, Apr 1, 2020 at 6:05 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the updated patch. The issue was on PG9.6, fixed that. > Docs updated. > > Please review. > > On Wed, Apr 1, 2020 at 5:37 PM Akshay Joshi > wrote: > >>

pgAdmin 4 commit: Updated psutil to the latest version 5.7.0 to fix vul

2020-04-01 Thread Akshay Joshi
Updated psutil to the latest version 5.7.0 to fix vulnerability issue. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a09ada18ee01ea5979e85b3eb4352ce88f9f4a10 Modified Files -- requirements.txt | 2 +- 1 file changed, 1 insertion(+

pgAdmin 4 commit: Added support for parameter toast_tuple_target and pa

2020-04-01 Thread Akshay Joshi
Added support for parameter toast_tuple_target and parallel_workers of the table. Fixes #5181 Fixed an issue where the autovacuum_enabled parameter is added automatically in the RE-SQL when the table has been created using the WITH clause. Fixes #5180 Branch -- master Details --- https

Re: [pgAdmin][RM2172] Search Objects Functionality

2020-04-01 Thread Akshay Joshi
Hi Khushboo, Can you please review it. On Mon, Mar 30, 2020 at 2:39 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to implement search objects functionality in pgadmin. > The feature will allow a user to search for any object in a database

Re: [pgAdmin][RM2172] Search Objects Functionality

2020-04-01 Thread Akshay Joshi
Hi Khsuboo, Can you please review it. On Mon, Mar 30, 2020 at 2:39 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to implement search objects functionality in pgadmin. > The feature will allow a user to search for any object in a database.

Re: [pgAdmin4][Patch] - RM 2186 - Support external authentication sources [LDAP]

2020-04-01 Thread Khushboo Vashi
Hi, Please find the attached updated patch which includes the review comments given in the review meeting: 1. Do not store password for ldap user in sqlite database 2. Forgot Password : Give error to ldap users 3. User Management dialog changes 4. Authentication source display besides username /

Re: [pgAdmin][RM5181] Add support for parameters toast_tuple_target and parallel_workers of table

2020-04-01 Thread Akshay Joshi
Documentation and Screenshot need to be updated. On Wed, Apr 1, 2020 at 5:10 PM Akshay Joshi wrote: > Hi Aditya > > Tested on 9.6, test cases are fixed but wrong SQL generated for tables: > CREATE TABLE public.test > ( > col1 bigint > ) > WITH ( > OIDS = FALSE,, > parallel_workers =

Re: [pgAdmin][RM5181] Add support for parameters toast_tuple_target and parallel_workers of table

2020-04-01 Thread Akshay Joshi
Hi Aditya Tested on 9.6, test cases are fixed but wrong SQL generated for tables: CREATE TABLE public.test ( col1 bigint ) WITH ( OIDS = FALSE,, parallel_workers = 56autovacuum_enabled = TRUE, Also parameter parallel_workers is not showing until we enabled the autovacuum parameter

Re: [pgAdmin][RM5181] Add support for parameters toast_tuple_target and parallel_workers of table

2020-04-01 Thread Aditya Toshniwal
Hi Akshay, On Wed, Apr 1, 2020 at 2:51 PM Akshay Joshi wrote: > Hi Aditya > > API/RESQL test cases are failing for EPAS/PG 9.6 and maybe above. Please > fix and resend the patch. > The SQL is corrected for 9.6 versions. Others seems to be working fine. Attached is the updated patch. Please revie

Re: [pgAdmin][RM5268] Wrong SQL generated when we update FTS Configuration and FTS Dictionary

2020-04-01 Thread Akshay Joshi
Thanks, patch applied. On Tue, Mar 31, 2020 at 11:22 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is a tiny patch to fix SQL generated when any token in FTS > Configuration or any option in FTS Dictionary is changed. > > Please review. > > -- > Thank

pgAdmin 4 commit: Fixed generated SQL when any token in FTS Configurati

2020-04-01 Thread Akshay Joshi
Fixed generated SQL when any token in FTS Configuration or any option in FTS Dictionary is changed. Fixes #5268 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=88a1e03314759b4b7d5a3fb91095e4fd47939c14 Author: Aditya Toshniwal Modified Files

pgAdmin 4 commit: Ensure that the start and end date should be deleted

2020-04-01 Thread Akshay Joshi
Ensure that the start and end date should be deleted when clear the selection for pgAgent Job. Fixes #3645 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=75b6341a84b93a1674b39a5044ef206dff6cd715 Author: Rahul Shirsat Modified Files

Re: [pgAdmin][RM5181] Add support for parameters toast_tuple_target and parallel_workers of table

2020-04-01 Thread Akshay Joshi
Hi Aditya API/RESQL test cases are failing for EPAS/PG 9.6 and maybe above. Please fix and resend the patch. On Mon, Mar 30, 2020 at 7:47 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is a patch to add support for parameters toast_tuple_target (PG > v