pgAdmin 4 commit: Don't offer to configure Apache on Redhat platforms a

2020-03-24 Thread Dave Page
Don't offer to configure Apache on Redhat platforms as there's nothing to do. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f97d29243d5a400bfba82bd7cce3de3743446c0d Modified Files -- pkg/linux/setup-web.sh | 22 ++

pgAdmin 4 commit: Use NodeJS v12.

2020-03-24 Thread Dave Page
Use NodeJS v12. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=17d0d5e0a2fabae075cb01f6b076a3550f0f3d04 Modified Files -- pkg/debian/setup.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [pgAdmin4][Patch] - RM 2186 - Support external authentication sources [LDAP]

2020-03-24 Thread Khushboo Vashi
Please disregard my previous patch, attached the updated patch. :) On Tue, Mar 24, 2020 at 10:32 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Please disregard my previous patch, attached the updated patch. > > On Tue, Mar 24, 2020 at 10:29 AM Khushboo Vashi < > khushboo.va...@en

Re: [pgAdmin4][Patch]: RM 5053 - Getting an error while changing the columns in the existing view

2020-03-24 Thread Akshay Joshi
Hi Khushboo On Tue, Mar 24, 2020 at 1:47 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Akshay, > > On Tue, Jan 14, 2020 at 11:47 AM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Khushboo >> >> Following are the review comments: >> >>- Fix the PEP8 issue. >>

Re: [pgAdmin4][Patch]: RM 5053 - Getting an error while changing the columns in the existing view

2020-03-24 Thread Khushboo Vashi
Hi Akshay, On Tue, Jan 14, 2020 at 11:47 AM Akshay Joshi wrote: > Hi Khushboo > > Following are the review comments: > >- Fix the PEP8 issue. >- Drop query should be part of the jinja template for consistency. >Currently, it is added through the python file. > > The Delete query is a