Re: [pgAdmin4][RM 5271] To change the switch control colors

2020-03-18 Thread Murtuza Zabuawala
Hello, PFA updated patch with new colors provided by Chethana, As discussed we will be using the same primary success color in both theme so we don't have add new variable. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Mar 18

pgAdmin 4 commit: Don't ask to continue when installing deps.

2020-03-18 Thread Dave Page
Don't ask to continue when installing deps. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6105fc861d8eab99c2eda730e46beb8b2ea96fe3 Modified Files -- pkg/redhat/setup.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgAdmin 4 commit: Add support for building RHEL/CentOS 8 RPMs.

2020-03-18 Thread Dave Page
Add support for building RHEL/CentOS 8 RPMs. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f156696339bf9fda7ad0fa474ecd3d5225b1116f Modified Files -- .gitignore | 1 + Makefile | 10 ++- pkg

[pgAdmin4][RM#5261] Support for Collation, FTS Templates, FTS Dictionaries, FTS Configurations and FTS Parsers

2020-03-18 Thread Akshay Joshi
Hi Hackers, Attached is the patch to add support for Collation, FTS Templates, FTS Dictionaries, FTS Configurations and FTS Parsers in Schema Diff Tool. The patch contains some minor fix where parameters are added in the difference list even though it's size is zero. I have also added the test ca

Re: [pgAdmin4][RM 5271] To change the switch control colors

2020-03-18 Thread Aditya Toshniwal
Hi Murtuza/Chethana, Irrespective of what color you suggest, there is no need to add new variables for switch buttons. It should use success for on and ternary for off. Having a separate green color for each and every control is absurd. If the green changes, it should change for all. On Wed, Mar

Re: [pgAdmin4][RM 5271] To change the switch control colors

2020-03-18 Thread Chethana Kumar
Let us discuss on a call for better clarity and the conclusion part we can put it on mail. --- Chethana kumar On Wed, Mar 18, 2020 at 2:12 PM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Chethana, > > No it is not, As per current dark theme implementation we have used > pr

Re: [pgAdmin4][RM 5271] To change the switch control colors

2020-03-18 Thread Murtuza Zabuawala
Hi Chethana, No it is not, As per current dark theme implementation we have used primary color '#1a522b' for switch but the color you suggested is '#43A047' for both theme. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Mar 18

Re: [pgAdmin4][RM 5271] To change the switch control colors

2020-03-18 Thread Murtuza Zabuawala
Hi Aditya, On Wed, Mar 18, 2020 at 1:52 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Murtuza, > > Why do we need to add new variable swith-ternary ? What was the issue you > were facing ? > Just to make both class names consistent, I missed to git add those changes in the

Re: [pgAdmin4][RM 5271] To change the switch control colors

2020-03-18 Thread Chethana Kumar
Hi Murtuza, The changes are already incorporated so no worries :) Thanks, --- Chethana kumar On Wed, Mar 18, 2020 at 12:43 PM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hello, > > As per discussion with Chethana, We need to make switch box color change > for light and dar

Re: [pgAdmin4][RM 5271] To change the switch control colors

2020-03-18 Thread Aditya Toshniwal
Hi Murtuza, Why do we need to add new variable swith-ternary ? What was the issue you were facing ? On Wed, Mar 18, 2020 at 12:43 PM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hello, > > As per discussion with Chethana, We need to make switch box color change > for light an

[pgAdmin4][RM 5271] To change the switch control colors

2020-03-18 Thread Murtuza Zabuawala
Hello, As per discussion with Chethana, We need to make switch box color change for light and dark theme, Color details provided by Chethana is updated on ticket. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company pgadmin4_switch_changes.d