Re: PgAgent leap year problem

2020-03-03 Thread Ashesh Vashi
On Wed, Mar 4, 2020 at 12:36 PM Neel Patel wrote: > Hi Ashesh, > > I have reviewed it and looks good. I have updated the sql version in > header of each sql file. > Thanks Neel. Committed the patch with the change suggested offline regarding the updated version in the windows resource (.rc) file

pgAgent commit: Use 'YEAR' part of a date to determine the leap year.

2020-03-03 Thread Ashesh Vashi
Use 'YEAR' part of a date to determine the leap year. In order to calculate the last day of the month, we were using 'DAY' part of a date to determine the leap year, which was wrong. We should have used 'YEAR' part for the date for that caculation as proposed in this change. Original Patch by: Me

Re: PgAgent leap year problem

2020-03-03 Thread Neel Patel
Hi Ashesh, I have reviewed it and looks good. I have updated the sql version in header of each sql file. Thanks, Neel Patel On Wed, Mar 4, 2020 at 12:22 PM Ashesh Vashi wrote: > On Wed, Mar 4, 2020 at 10:53 AM Neel Patel > wrote: > >> Hi Mehmet, >> >> It was a bug in pgAgent. Thank you for s

Re: PgAgent leap year problem

2020-03-03 Thread Ashesh Vashi
On Wed, Mar 4, 2020 at 10:53 AM Neel Patel wrote: > Hi Mehmet, > > It was a bug in pgAgent. Thank you for sharing the patch. I have reviewed > and tested, it is working fine. > > Dave/Ashesh:- Can we commit this patch ? > Mehmet, Thanks for your patch. Changes look good except it does not take

Re: PgAgent leap year problem

2020-03-03 Thread Neel Patel
Hi Mehmet, It was a bug in pgAgent. Thank you for sharing the patch. I have reviewed and tested, it is working fine. Dave/Ashesh:- Can we commit this patch ? Thanks, Neel Patel On Mon, Mar 2, 2020 at 5:26 PM Mehmet Emin KARAKAŞ wrote: > Hi, > > Scheduled tasks set as the last day of February