Re: [pgAdmin][RM5050] Language node code coverage.

2020-01-19 Thread Akshay Joshi
Thanks, patch applied. On Mon, Jan 20, 2020 at 11:43 AM Pradip Parkale < pradip.park...@enterprisedb.com> wrote: > Hi Akshay, > > Please find the updated patch. > I have accommodated all the changes mentioned in the review. > > On Thu, Jan 16, 2020 at 5:54 PM Akshay Joshi < > akshay.jo...@enterpr

pgAdmin 4 commit: Improve code coverage and API test cases for the LANG

2020-01-19 Thread Akshay Joshi
Improve code coverage and API test cases for the LANGUAGE module. Fixes #5050. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=30b4b5b3491dde285e3fc9bcaf90f8a5bee6245f Author: Pradip Parkale Modified Files -- docs/en_US/release_no

[pgAdmin][RM4511] Grant Wizard: Unable to handle multiple objects when query string parameter exceeds its limit

2020-01-19 Thread Aditya Toshniwal
Hi Hackers, Attached is a patch to change the REST API method for getting SQL in grant wizard. It will accept POST instead of GET now so that data can be sent using "data" instead of URL args which was breaking for large dataset. Also fixed a minor console error. Kindly review. -- Thanks and R

Re: [pgAdmin][RM5050] Language node code coverage.

2020-01-19 Thread Pradip Parkale
Hi Akshay, Please find the updated patch. I have accommodated all the changes mentioned in the review. On Thu, Jan 16, 2020 at 5:54 PM Akshay Joshi wrote: > Hi Pradip > > Below are the review comments: > >- Format the JSON file. Rename the JSON file from >'language_testcases.json' to 'l