Re: pgAdmin4 v4.16 candidate builds

@Akshay Joshi 1 Round of testing has been completed for v4.16 and it's ready for the release. Kind Regards, On Mon, Dec 9, 2019 at 10:02 PM Akshay Joshi wrote: > Hi All, > > pgAdmin4 v4.16 candidate builds and source can be found at > https://developer.pgadmin.org/builds/2019-12-09-1/ > > F

Re: Re : [BUG #4943]

Thanks, patch applied. On Wed, Dec 11, 2019 at 5:41 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > I've updated your patch further to escape the info prefix so that it > doesn't break if db name is something like - "alert(1)". > Fixed a pep8 issue. > Otherwise, the patc

pgAdmin 4 commit: Added more information to the 'Database connected/dis

Added more information to the 'Database connected/disconnected' message. Fixes #4943. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=53f418b9a2701abc2a6300382734b72dcd6d3ecc Author: Karan Takalkar Modified Files -- docs/en_US/re

Re: Re : [BUG #4943]

Hi, I've updated your patch further to escape the info prefix so that it doesn't break if db name is something like - "alert(1)". Fixed a pep8 issue. Otherwise, the patch looks good to me and test cases works fine. On Wed, Dec 11, 2019 at 5:19 PM Karan Takalkar wrote: > Hi, > > I have updated

Re: Re : [BUG #4943]

Hi, I have updated the disconnect messages. Databases/extension tests are failing , i have attached the log below. They are also failing if i undo the modifications. i do not know if this a problem with my setup or i maybe not following a convention. Please check the updated patch. Regards, Kara

Re: Re : [BUG #4943]

Hi Karan, I've updated your patch a bit. Kindly test and share the logs if test cases fail. Test cases seems to be working fine for me. Kindly also change disconnected messages. On Tue, Dec 10, 2019 at 6:51 PM Karan Takalkar wrote: > Hi, > > "add more variables to the response along with info a

Re: [pgAdmin][RM4762] [Accessibility] Allow screenreader to read label & description of non-textable elements

Thanks, patch applied. On Tue, Dec 10, 2019 at 5:27 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to add aria-label to the buttons in debugger. All > others were taken care in #4772. > > Kindly review. > > -- > Thanks and Regards, > Aditya

Re: [pgAdmin][RM4506] "can't execute an empty query" message displayed if user remove fill factor of any existing table

Thanks, patch applied. On Tue, Dec 10, 2019 at 12:57 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the updated patch. The modified SQL missed the reset clause > for FILLFACTOR. That's added now. > I've changed the int/numeric field validation to dis

pgAdmin 4 commit: Added aria-label to the buttons in the debugger.

Added aria-label to the buttons in the debugger. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9bda583d5bc69675802f8e442a999265bb911fd0 Author: Aditya Toshniwal Modified Files -- web/pgadmin/tools/debugger/static/js/direct.js |

pgAdmin 4 commit: Fix an issue where clicking on an empty textbox like

Fix an issue where clicking on an empty textbox like fill factor or comments,  considers it as change and enabled the save button. Fixes #4506. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=11bf5fc679471f64ae32d47c44f22bfaff9e1b62 Author: Adi

Re: [pgAdmin][RM5004] Fix yarn audit issues and remove deprecated uglifyjs-webpack-plugin

Thanks, patch applied. On Wed, Dec 11, 2019 at 12:53 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to fix the issues reported by "yarn audit", which > required few package updates. > Also, replace the deprecated uglifyjs-webpack-plugin > w

pgAdmin 4 commit: Fix vulnerability issues reported by 'yarn audit'. Re

Fix vulnerability issues reported by 'yarn audit'. Replace the deprecated  uglifyjs-webpack-plugin with a terser-webpack-plugin. Fixes #5004. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=43d37e3b4c737ca8e1500b2b59514e21036013c2 Author: Adity