Re: pgAdmin 4 commit: Use a 'play' icon for the Execute Query button in the

2019-12-03 Thread Akshay Joshi
Hi Dave, Should I commit this patch, are you happy with the new icons? On Tue, Dec 3, 2019 at 4:13 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Dave, > > I've sent a patch for the new icon. It is not a play icon but thoughts on > the sent patch ? Below is the icon: > [ima

RM4939 - Running in the container as non-root user

2019-12-03 Thread Dave Page
The attached patch fixes $SUBJECT. I'm a little concerned about upgrades though, mostly when using mapped storage or session data. Fahar, can you test such scenarios please? Patch review is also needed please :-) -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK:

Re: Fixes for pgAdmin feature tests

2019-12-03 Thread Akshay Joshi
Thanks, patch applied. On Tue, Dec 3, 2019 at 6:09 PM Shubham Agarwal < shubham.agar...@enterprisedb.com> wrote: > Hi Team, > > PFA patch for feature tests containing following fixes- > > 1. Modified the get_chromedriver utility for supporting python version > below 3.5. > 2. Handled some excepti

pgAdmin 4 commit: Fixed following issues for feature test:

2019-12-03 Thread Akshay Joshi
Fixed following issues for feature test: 1. Modified the get_chromedriver utility for supporting python version below 3.5. 2. Handled some exceptions getting intermittently on some databases. 3. Generalized some functions with additional parameters. 4. Disabled the auto-expansion of the children n

pgAdmin 4 commit: Fix an issue where the inherited table name with quot

2019-12-03 Thread Akshay Joshi
Fix an issue where the inherited table name with quotes did not escape correctly. Fixes #4985. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f7cc79fab1241ca023d868ab2fc85cceef674ff9 Modified Files -- docs/en_US/release_notes_4_1

Re: Fixes for pgAdmin feature tests

2019-12-03 Thread Shubham Agarwal
Hi Team, PFA patch for feature tests containing following fixes- 1. Modified the get_chromedriver utility for supporting python version below 3.5. 2. Handled some exceptions getting intermittently on some databases. 3. Generalized some functions with additional parameters. 4. Disabled the auto-ex

Re: pgAdmin 4 commit: Use a 'play' icon for the Execute Query button in the

2019-12-03 Thread Aditya Toshniwal
Hi Dave, I've sent a patch for the new icon. It is not a play icon but thoughts on the sent patch ? Below is the icon: [image: toolbar.png] On Tue, Dec 3, 2019 at 4:09 PM Dave Page wrote: > I intentionally didn't change that one as I wasn't sure what icon would be > better. I'm far from convinc

Re: pgAdmin 4 commit: Use a 'play' icon for the Execute Query button in the

2019-12-03 Thread Dave Page
I intentionally didn't change that one as I wasn't sure what icon would be better. I'm far from convinced that it should also be a play icon. On Tue, Dec 3, 2019 at 5:08 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to change toolbar icon

pgAdmin 4 commit: Fix 'Could not find the object on the server.' error

2019-12-03 Thread Akshay Joshi
Fix 'Could not find the object on the server.' error while refreshing the check constraint. Fixes #4966. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9110703aaa100840b7bed4820c3a6c59884b0c7b Modified Files -- docs/en_US/release