Re: Fixes for pgAdmin feature tests

2019-11-21 Thread Akshay Joshi
Thanks, patch applied. On Thu, Nov 21, 2019 at 3:40 PM Shubham Agarwal < shubham.agar...@enterprisedb.com> wrote: > Hi Team, > Attach is the patch for feature test fix containing the following: > 1. Handled click event in query tool due to intermediate clicking issue. > 2. Observed that the datab

pgAdmin 4 commit: Fixed following feature tests:

2019-11-21 Thread Akshay Joshi
Fixed following feature tests: 1) Handled click event in query tool due to intermediate clicking issue. 2) Observed that the database is not getting created in a test case, so failed the test case there only. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a

Re: [pgAdmin][RM4818] Unable to handle loss of connection to server

2019-11-21 Thread Akshay Joshi
Hi Aditya Following are the review comments: - Update the timeout in the comment section from 30 seconds to 10 seconds in aff1436e3c8c_.py. - Asking for the database server password even if it is saved. Reproduction steps: - Connect to the database server, saved the password. - Disable

Re: Fixes for pgAdmin feature tests

2019-11-21 Thread Shubham Agarwal
Hi Team, Attach is the patch for feature test fix containing the following: 1. Handled click event in query tool due to intermediate clicking issue. 2. Observed that the database is not getting created in a test case, so failed the test case there only. On Wed, Nov 20, 2019 at 1:09 PM Akshay Joshi