Re: [pgAdmin][RM4696] Add RE-SQL/MSQL test cases for Materialized View

Hi Rahul Some more review comments: - Don't create new file test_view.json as I tested and committed the old code. - Remove hardcoded "oid: 17869" from JSON file. - MSQL endpoints and file name missing in some test cases. - Cover all the controls in create and alter as much as poss

Re: [pgAdmin][RM4818] Unable to handle loss of connection to server

Hi, I forgot to mention, I've also changed the dashboard code. The dashboard was sending graph data requests, but when the server lost connection the requests remains pending for longer time. Because of this the server gets flooded with lot of pending request and in turn slowing down the entire ap

Re: [pgAdmin][RM4818] Unable to handle loss of connection to server

Hi Hackers, Attached is the updated patch to fix the review comments. Please note, there is some problem with psycopg2/libpq where it hangs when network is lost - https://github.com/psycopg/psycopg2/issues/561 I've also changed the code to make connections after the "Servers" node is expanded to f

Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme

Thanks all! On Wed, Nov 20, 2019 at 4:37 AM Akshay Joshi wrote: > Thanks, patch applied. > > On Wed, Nov 20, 2019 at 11:59 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> pgadmin.themes.json is created in web/pgadmin/misc/themes on "yarn run >> bundle" an

Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme

Thanks, patch applied. On Wed, Nov 20, 2019 at 11:59 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > pgadmin.themes.json is created in web/pgadmin/misc/themes on "yarn run > bundle" and is copied to generated directory also. This file is required > for themes to

pgAdmin 4 commit: Fixed issue where Dark Theme is unavailable in python

Fixed issue where Dark Theme is unavailable in python wheel distro. pgAdmin wheel distro is not having pgadmin.themes.json file in 'web/pgadmin/misc/themes' directory, so it's better to refer this file from the generated directory. Branch -- master Details --- https://git.postgresql.org

pgAdmin 4 commit: Fix vulnerability issue for package 'mem', which is a

Fix vulnerability issue for package 'mem', which is a dependency module for eclint. Remove unused eclint module from the package.json Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=bb845817d671e873a2f4ef65b03f10943ddd79c4 Modified Files ---