Re: [pgAdmin][RM4895] Possible issue in reset function for nested objects

2019-11-05 Thread Akshay Joshi
Thanks, patch applied. On Tue, Nov 5, 2019 at 12:28 PM Ganesh Jaybhay < ganesh.jayb...@enterprisedb.com> wrote: > Hi Hackers, > > Please find the attached patch to fix the possible issue in reset function > for nested objects. > > Regards, > Ganesh Jaybhay > -- *Thanks & Regards* *Akshay Joshi

[pgAdmin][RM3279] the Drop and Disconnect connection menupoints are too close for each others

2019-11-05 Thread Rahul Shirsat
Hi Hackers, Attached is the patch to move "Delete/Drop" menu option away from "Disconnect Servers" for server node. Additionally, I have renamed the "Delete/Drop" menu option to "Remove Server" for server node against issue RM3859. -- *Rahul Shirsat* Software Engineer | EnterpriseDB Corporation

pgAdmin 4 commit: Fixed potential issue in reset function for nested ob

2019-11-05 Thread Akshay Joshi
Fixed potential issue in reset function for nested objects. Reset function clears the model instead of storing previous values. Fixes #4895 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=69fba93152b988e79b4d360753a50e09815387a6 Author: Ganes

Re: [pgAdmin][RM4351] Confirm before close of properties dialog if changes not saved

2019-11-05 Thread Akshay Joshi
Thanks, patch applied. On Tue, Nov 5, 2019 at 12:46 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > Please find the attached updated patch. > > On Tue, Nov 5, 2019 at 11:01 AM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Aditya >> >> I have tested it. R

pgAdmin 4 commit: Add an option to request confirmation before cancelli

2019-11-05 Thread Akshay Joshi
Add an option to request confirmation before cancelling/resetting changes on a Properties dialog. Fixes #4351 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=570ee58f5390c5212e139380a8477da7f0841abc Author: Aditya Toshniwal Modified Files --