Re: [pgAdmin][RM4351] Confirm before close of properties dialog if changes not saved

2019-10-30 Thread Aditya Toshniwal
On Wed, Oct 30, 2019 at 3:44 PM Dave Page wrote: > Hi > > On Wed, Oct 30, 2019 at 4:40 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi, >> >> On Tue, Oct 29, 2019 at 9:01 PM Dave Page wrote: >> >>> Hi >>> >>> I just found an, umm, embarrassing issue with this. It asks f

Re: [pgAdmin][RM4610] Enter key on search box for dropdown intercepted by modal

2019-10-30 Thread Dave Page
Thanks, patch applied. On Wed, Oct 30, 2019 at 6:32 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to suppress enter key events from the select2 boxes > when in an alertify dialog. > Alertfiy takes reads the enter keyup event and triggers S

pgAdmin 4 commit: Suppress Enter key presses in Alertify dialogues when

2019-10-30 Thread Dave Page
Suppress Enter key presses in Alertify dialogues when the come from Select2 controls to allow item selection with Enter. Fixes #4610 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4bec7df33b01bcb356d131a55d2cce9fd8c22483 Author: Aditya Toshni

Re: [pgAdmin][RM4351] Confirm before close of properties dialog if changes not saved

2019-10-30 Thread Dave Page
Hi On Wed, Oct 30, 2019 at 4:40 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > On Tue, Oct 29, 2019 at 9:01 PM Dave Page wrote: > >> Hi >> >> I just found an, umm, embarrassing issue with this. It asks for the >> cancel confirmation even when pressing the OK button :-o

pgAdmin 4 commit: Don't warn the user before saving changes.

2019-10-30 Thread Dave Page
Don't warn the user before saving changes. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fbc3e2d0e76699f6fef6240902ae3790c5ca47fd Author: Aditya Toshniwal Modified Files -- web/pgadmin/browser/static/js/node.js | 18 +++-