[pgAdmin][RM4610] Enter key on search box for dropdown intercepted by modal

Hi Hackers, Attached is the patch to suppress enter key events from the select2 boxes when in an alertify dialog. Alertfiy takes reads the enter keyup event and triggers Save. Kindly review. -- Thanks and Regards, Aditya Toshniwal Sr. Software Engineer | EnterpriseDB India | Pune "Don't Complai

Re: [pgAdmin][RM4351] Confirm before close of properties dialog if changes not saved

Hi, On Tue, Oct 29, 2019 at 9:01 PM Dave Page wrote: > Hi > > I just found an, umm, embarrassing issue with this. It asks for the cancel > confirmation even when pressing the OK button :-o > Tested all but missed the obvious. Bad miss :/ Attached is the patch to fix the issue. > > Can you fix t

Re: [pgAdmin][RM4564] JS errors in the Query Tool are caught as ajax errors

Thanks, patch applied. On Tue, Oct 29, 2019 at 12:13 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to throw JS errors to browser consoles. JS errors > after execute are now caught by axios catch which shows a false message - > "Not connect

pgAdmin 4 commit: Ensure Javascript errors during Query Tool execution

Ensure Javascript errors during Query Tool execution are reported as such and not as Ajax errors.. Fixes #4564 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4f9d2de8cdddbce63489310346d8c94141e249b7 Author: Aditya Toshniwal Modified Files -

Re: [pgAdmin][RM4351] Confirm before close of properties dialog if changes not saved

Hi I just found an, umm, embarrassing issue with this. It asks for the cancel confirmation even when pressing the OK button :-o Can you fix that ASAP please? On Tue, Oct 29, 2019 at 2:35 PM Dave Page wrote: > Thanks, applied. > > On Tue, Oct 29, 2019 at 6:40 AM Aditya Toshniwal < > aditya.tosh

Re: [pgAdmin][RM4351] Confirm before close of properties dialog if changes not saved

Thanks, applied. On Tue, Oct 29, 2019 at 6:40 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to warn the user before closing an unsaved > properties dialog. > Additionally, I have added a preference option in Browser->Display where > the us

pgAdmin 4 commit: Correct the issue number for the previous commit (c25

Correct the issue number for the previous commit (c25034a8). Fixes #4351 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=18b7483cc417ea377eeae703b5a77c6abac4f723 Modified Files -- docs/en_US/release_notes_4_15.rst | 2 +- 1 file cha

pgAdmin 4 commit: Add an option to request confirmation before cancelli

Add an option to request confirmation before cancelling changes on a Properties dialog. Fixes #4315 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c25034a86dbb6ba44aa7f4a85c3151f8abda08a5 Author: Aditya Toshniwal Modified Files

pgAdmin 4 commit: PEP-8 fix.

PEP-8 fix. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7408b8c8d9a48b7e44c535c333ce530b0535a0ec Modified Files -- web/pgadmin/browser/__init__.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

[pgAdmin][RM4564] JS errors in the Query Tool are caught as ajax errors

Hi Hackers, Attached is the patch to throw JS errors to browser consoles. JS errors after execute are now caught by axios catch which shows a false message - "Not connected to the server or the connection to the server has been closed." This will help is debugging in case of JS erors. Kindly revi

Re: [pgAdmin][RM3915] Executing a specific query will break keyboard shorcuts for Query Tool

Thanks, applied. On Tue, Oct 29, 2019 at 5:14 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to fix the issue where delayed exceptions raised by > functions breaks few shortcuts of query tool. > > Kindly review. > > -- > Thanks and Regards,

pgAdmin 4 commit: Fix an issue in the Query Tool where shortcut keys co

Fix an issue in the Query Tool where shortcut keys could be ignored following a query error. Fixes #3915 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=06022dfd7e69a4ea058621df79c543290140dbbf Author: Aditya Toshniwal Modified Files ---