pgAdmin 4 commit: Fix issue where VALID foreign keys show as NOT VALID

2019-10-10 Thread Akshay Joshi
Fix issue where VALID foreign keys show as NOT VALID in the SQL tab for tables. Corrected the condition for valid foreign key. Fixes #4791 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c3e11bd3903fb4ad05b583040519a207c0abadb1 Modified File

Re: [pgAdmin][RM4590] Schema Backup fails with names that requires quoting

2019-10-10 Thread Akshay Joshi
Thanks, patch applied. On Wed, Oct 9, 2019 at 2:21 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the updated patch. Tested on MacOS, Windows 7, Ubuntu 16 and > works fine. > Kindly review. > > On Wed, Oct 9, 2019 at 1:48 PM Akshay Joshi > wrote: >

pgAdmin 4 commit: popen() function strips the quotes from the arguments

2019-10-10 Thread Akshay Joshi
popen() function strips the quotes from the arguments, so backup fails for the schema name that needs quoting. Code is changed to add escapers. Fixes #4590 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d056a94f0c30b44c4bab680a63f318de3226e9