pgAdmin 4 commit: Feature test should work with Python 2.7.

2019-10-08 Thread Akshay Joshi
Feature test should work with Python 2.7. Import print_function from __future__ Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e5638b520dbfe02fd869aeb129abcb4730c3676f Modified Files -- web/regression/feature_utils/pgadmin_page.p

Re: [pgAdmin][RM4590] Schema Backup fails with names that requires quoting

2019-10-08 Thread Aditya Toshniwal
Hi Hackers, Turned out to be an issue only on Mac. Backup works fine for other OS. Attached is the patch to fix the issue on Mac. Code is changed to add extra pairs of quotes wherever required on MacOS. Kindly review. On Thu, Oct 3, 2019 at 3:53 PM Aditya Toshniwal < aditya.toshni...@enterprised

Re: pgAdmin 4 commit: Fixes # 4778 - Implement the query plan analyzer

2019-10-08 Thread Dave Page
Very cool - but I didn't see any tests? On Tue, Oct 8, 2019 at 12:15 PM Ashesh Vashi wrote: > Fixes # 4778 - Implement the query plan analyzer > > Look 'n' Feel and implementation logic are inspired from > 'http://explain.depsez.com'. > > It now creates three tabs under the 'Explain' panel when

pgAdmin 4 commit: Fixes # 4778 - Implement the query plan analyzer

2019-10-08 Thread Ashesh Vashi
Fixes # 4778 - Implement the query plan analyzer Look 'n' Feel and implementation logic are inspired from 'http://explain.depsez.com'. It now creates three tabs under the 'Explain' panel when executing a query using the Explain Analyze/Explain button from the toolbar of the Query tool. Graphical